Re: [PR] Support ethernet without MDIO & MDC lines [nuttx]

2025-04-15 Thread via GitHub


azerupi commented on code in PR #16215:
URL: https://github.com/apache/nuttx/pull/16215#discussion_r2045129208


##
arch/arm/src/stm32h5/stm32_ethernet.c:
##
@@ -3604,9 +3604,10 @@ static inline void stm32_ethgpioconfig(struct 
stm32_ethmac_s *priv)
 #if defined(CONFIG_STM32H5_MII) || defined(CONFIG_STM32H5_RMII)
 
   /* MDC and MDIO are common to both modes */
-
+# ifndef CONFIG_STM32H5_NO_PHY

Review Comment:
   It is defined in `arch/arm/src/stm32h5/Kconfig` 
   
   ```
   rg ".+_NO_PHY"
   arch/arm/src/stm32h7/stm32_ethernet.c
   807:#ifndef CONFIG_STM32H7_NO_PHY
   3002:#ifndef CONFIG_STM32H7_NO_PHY
   3066:#ifndef CONFIG_STM32H7_NO_PHY
   3702:# ifndef CONFIG_STM32H7_NO_PHY
   4197:#ifdef CONFIG_STM32H7_NO_PHY
   
   arch/arm/src/stm32h7/Kconfig
   5545:config STM32H7_NO_PHY
   
   arch/arm/src/stm32h5/stm32_ethernet.c
   748:#ifndef CONFIG_STM32H5_NO_PHY
   2943:#ifndef CONFIG_STM32H5_NO_PHY
   3007:#ifndef CONFIG_STM32H5_NO_PHY
   3607:# ifndef CONFIG_STM32H5_NO_PHY
   4102:#ifdef CONFIG_STM32H5_NO_PHY
   
   arch/arm/src/stm32h5/Kconfig
   4734:config STM32H5_NO_PHY
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Support ethernet without MDIO & MDC lines [nuttx]

2025-04-15 Thread via GitHub


xiaoxiang781216 merged PR #16215:
URL: https://github.com/apache/nuttx/pull/16215


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Support ethernet without MDIO & MDC lines [nuttx]

2025-04-15 Thread via GitHub


xiaoxiang781216 commented on code in PR #16215:
URL: https://github.com/apache/nuttx/pull/16215#discussion_r2045120472


##
arch/arm/src/stm32h5/stm32_ethernet.c:
##
@@ -3604,9 +3604,10 @@ static inline void stm32_ethgpioconfig(struct 
stm32_ethmac_s *priv)
 #if defined(CONFIG_STM32H5_MII) || defined(CONFIG_STM32H5_RMII)
 
   /* MDC and MDIO are common to both modes */
-
+# ifndef CONFIG_STM32H5_NO_PHY

Review Comment:
   where do we define CONFIG_STM32H5_NO_PHY



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Support ethernet without MDIO & MDC lines [nuttx]

2025-04-15 Thread via GitHub


azerupi commented on PR #16215:
URL: https://github.com/apache/nuttx/pull/16215#issuecomment-2806597299

   We are using the RTL8364NBI-CG. I don't think I can share a screenshot of 
the schematic but here is a simplified diagram if that helps.
   
   
![image](https://github.com/user-attachments/assets/fba28e3b-c824-4848-a8f6-03b641f03a47)
   
   The pins where the MDIO and MDC would be usually connected on the STM32 
(NuttX) are being used for something else unrelated to ethernet.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] Support ethernet without MDIO & MDC lines [nuttx]

2025-04-15 Thread via GitHub


acassis commented on PR #16215:
URL: https://github.com/apache/nuttx/pull/16215#issuecomment-2805169172

   Hi @azerupi that is interesting. Sometime ago some people asking in the list 
how to do something similar, but in that case they were willing to communicate 
two MCUs directly using Ethernet without PHY (it was ESP32). Could you please 
share more info about your switch part-number or a single diagram showing it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]