Re: [PR] adding "edit on github" option in docs [nuttx]

2025-06-02 Thread via GitHub


linguini1 commented on PR #16440:
URL: https://github.com/apache/nuttx/pull/16440#issuecomment-2932944689

   This change has broken the `make autobuild` option, since it re-defines 
`html_context` without adding the `nuttx_versions` key.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] adding "edit on github" option in docs [nuttx]

2025-05-25 Thread via GitHub


linguini1 commented on PR #16440:
URL: https://github.com/apache/nuttx/pull/16440#issuecomment-2907977989

   I really like this idea!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] adding "edit on github" option in docs [nuttx]

2025-05-25 Thread via GitHub


michallenc commented on PR #16440:
URL: https://github.com/apache/nuttx/pull/16440#issuecomment-2907800776

   > @michallenc it will only direct user to the github page associated with 
the document. User will edit and create PR. For reference - 
https://docs.zephyrproject.org/latest/index.html
   
   Oh, cool!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] adding "edit on github" option in docs [nuttx]

2025-05-25 Thread via GitHub


acassis merged PR #16440:
URL: https://github.com/apache/nuttx/pull/16440


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] adding "edit on github" option in docs [nuttx]

2025-05-25 Thread via GitHub


abisop commented on PR #16440:
URL: https://github.com/apache/nuttx/pull/16440#issuecomment-2907728091

   @michallenc it will only direct user to the github page associated with the 
document. User will edit and create PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [PR] adding "edit on github" option in docs [nuttx]

2025-05-25 Thread via GitHub


michallenc commented on PR #16440:
URL: https://github.com/apache/nuttx/pull/16440#issuecomment-2907696397

   How does this work? Does it create a new pull request or push directly to 
master? We should definitely avoid the latter.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]