Re: [PR] apps/cmake: Fix aarch64 NuttX Rust target specs [nuttx-apps]
jerpelea merged PR #3510: URL: https://github.com/apache/nuttx-apps/pull/3510 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] apps/cmake: Fix aarch64 NuttX Rust target specs [nuttx-apps]
toku-mac commented on PR #3510: URL: https://github.com/apache/nuttx-apps/pull/3510#issuecomment-4587584582 @xiaoxiang781216 I have moved the json file. Please check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] apps/cmake: Fix aarch64 NuttX Rust target specs [nuttx-apps]
xiaoxiang781216 commented on PR #3510: URL: https://github.com/apache/nuttx-apps/pull/3510#issuecomment-4585621504 > @xiaoxiang781216 Should I move the files below along with it? > > * i486-unknown-nuttx.json > * x86_64-unknown-nuttx.json yes, either keep all json in apps/ or nuttx/, but not both location if the content is same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] apps/cmake: Fix aarch64 NuttX Rust target specs [nuttx-apps]
toku-mac commented on PR #3510: URL: https://github.com/apache/nuttx-apps/pull/3510#issuecomment-4581649422 @xiaoxiang781216 Should I move the files below along with it? * i486-unknown-nuttx.json * x86_64-unknown-nuttx.json -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] apps/cmake: Fix aarch64 NuttX Rust target specs [nuttx-apps]
xiaoxiang781216 commented on PR #3510: URL: https://github.com/apache/nuttx-apps/pull/3510#issuecomment-4581599713 > Since the PR on the nuttx git repository has been merged into master, I've decided not to move the `tools/aarch64-unknown-nuttx.json` file from the apps git. Please review commit [6e58319](https://github.com/apache/nuttx-apps/commit/6e583191c26cb57a7ddadff83daf0a6f28910972). but it's better to create a new patch to put all json config in one place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] apps/cmake: Fix aarch64 NuttX Rust target specs [nuttx-apps]
toku-mac commented on PR #3510: URL: https://github.com/apache/nuttx-apps/pull/3510#issuecomment-4576165150 Since the PR on the nuttx git repository has been merged into master, I've decided not to move the `tools/aarch64-unknown-nuttx.json` file from the apps git. Please review commit 6e583191. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] apps/cmake: Fix aarch64 NuttX Rust target specs [nuttx-apps]
toku-mac commented on code in PR #3510:
URL: https://github.com/apache/nuttx-apps/pull/3510#discussion_r3322558993
##
tools/aarch64-unknown-nuttx-macho.json:
##
@@ -0,0 +1,35 @@
+{
+ "arch": "aarch64",
+ "archive-format": "darwin",
+ "binary-format": "mach-o",
+ "crt-objects-fallback": "false",
Review Comment:
Is your intention the same as the patch below?
Also, should I move `tools/aarch64-unknown-nuttx.json` to the nuttx git as
well?
```diff
diff --git a/cmake/nuttx_add_rust.cmake b/cmake/nuttx_add_rust.cmake
index dfa91c31c..2c28983f0 100644
--- a/cmake/nuttx_add_rust.cmake
+++ b/cmake/nuttx_add_rust.cmake
@@ -57,7 +57,8 @@ function(nuttx_rust_target_triple ARCHTYPE ABITYPE CPUTYPE
OUTPUT)
set(TARGET_TRIPLE "${APPDIR}/tools/i486-unknown-nuttx.json")
elseif(ARCHTYPE STREQUAL "aarch64")
if(CONFIG_ARCH_SIM AND CONFIG_HOST_MACOS)
- set(TARGET_TRIPLE "${APPDIR}/tools/aarch64-unknown-nuttx-macho.json")
+ set(TARGET_TRIPLE
+ "${PROJECT_SOURCE_DIR}/tools/aarch64-unknown-nuttx-macho.json")
else()
set(TARGET_TRIPLE "${APPDIR}/tools/aarch64-unknown-nuttx.json")
endif()
diff --git a/tools/Rust.mk b/tools/Rust.mk
index 9ca03bdac..4fc74af4e 100644
--- a/tools/Rust.mk
+++ b/tools/Rust.mk
@@ -56,7 +56,7 @@ $(or \
), \
$(and $(filter aarch64,$(LLVM_ARCHTYPE)), \
$(if $(and $(filter sim,$(CONFIG_ARCH)),$(filter
y,$(CONFIG_HOST_MACOS))), \
- $(APPDIR)/tools/aarch64-unknown-nuttx-macho.json, \
+ $(TOPDIR)/tools/aarch64-unknown-nuttx-macho.json, \
$(APPDIR)/tools/aarch64-unknown-nuttx.json \
) \
), \
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Re: [PR] apps/cmake: Fix aarch64 NuttX Rust target specs [nuttx-apps]
xiaoxiang781216 commented on code in PR #3510:
URL: https://github.com/apache/nuttx-apps/pull/3510#discussion_r3322417631
##
tools/aarch64-unknown-nuttx-macho.json:
##
@@ -0,0 +1,35 @@
+{
+ "arch": "aarch64",
+ "archive-format": "darwin",
+ "binary-format": "mach-o",
+ "crt-objects-fallback": "false",
Review Comment:
should we reuse the same file from nuttx git?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
