nuttxpr commented on PR #16204:
URL: https://github.com/apache/nuttx/pull/16204#issuecomment-2803084354
[**\[Experimental Bot, please feedback
here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues)
No. The PR description lacks crucial details required by the NuttX
guidelines. Here's why and what's missing:
* **Insufficient Summary:** "Just switches the order of initialization" is
vague. *Which* initialization? What was the original order, and what is the
new order? What specific errors were occurring? A clear explanation of the
functional change is needed. Mentioning the specific files modified is also
helpful.
* **Missing Issue References:** Are there related NuttX issues? If not, one
should probably be created to track the bug this PR fixes.
* **Impact Under-Specified:** While it mentions fixing runtime assertions,
it doesn't specify which assertions. More detail is needed. Most of the
impact sections are simply marked "NO" without justification. This needs to be
reviewed carefully. At minimum, since the change affects startup, "Impact on
hardware" is likely "YES" and requires a more detailed description beyond
"Custom board, STM32H563ZI." Which other boards might be affected? Does this
change affect any existing drivers? "Impact on compatibility" should also be
considered—does this change break anything for existing users?
* **Insufficient Testing Details:** "Testing logs before change" and
"Testing logs after change" are empty. Provide actual logs or test output
demonstrating the problem before the change and the successful operation after
the change. "Build Host(s)" information is also missing. While the target is
mentioned, more details about the configuration used are helpful (e.g.,
specific defconfig).
In short, the PR needs to be much more detailed to meet the NuttX
requirements. @ArrestedLightning needs to expand on all sections to clearly
explain the problem, the solution, and its impact. Clear, verifiable testing
evidence is essential.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
