Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]
tkaratapanis commented on PR #16332: URL: https://github.com/apache/nuttx/pull/16332#issuecomment-2865258872 @jerpelea @acassis I think the PR is ready to be re-reviewed. If you have any suggestions please tell me, otherwise I will not make more edits. PS: Sorry if you got extra notifications yesterday, I changed some comments. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]
xiaoxiang781216 merged PR #16332: URL: https://github.com/apache/nuttx/pull/16332 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]
acassis commented on code in PR #16332: URL: https://github.com/apache/nuttx/pull/16332#discussion_r2078196870 ## .codespellrc: ## @@ -47,3 +47,4 @@ ignore-words-list = tolen, UE, WRON, + infor, Review Comment: @tkaratapanis I think you missed the alphabetic order, not a big issue, but since it is already organized it is better to keep this way. I did it yesterday when I added LCALL word. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]
xiaoxiang781216 commented on code in PR #16332: URL: https://github.com/apache/nuttx/pull/16332#discussion_r2078063224 ## .codespellrc: ## @@ -47,3 +47,4 @@ ignore-words-list = tolen, UE, WRON, + infor, Review Comment: OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]
tkaratapanis commented on PR #16332: URL: https://github.com/apache/nuttx/pull/16332#issuecomment-2858567369 > Hi @tkaratapanis please fix the CMake format and typos: > > ``` > ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/cmake/Toolchain.cmake > > cmake-format check failed, run following command to update the style: > $ cmake-format -o > > ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/cmake/Toolchain.cmake > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:67: implemet ==> implement > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:68: booloader ==> bootloader > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:842: mumber ==> number > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_ele.h:129: envents ==> events, invents > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_ele.h:146: envents ==> events, invents > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_romapi.c:78: infor ==> info, inform, in for > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_romapi.c:83: infor ==> info, inform, in for > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_romapi.c:84: infor ==> info, inform, in for > `` > ``` The spellchecker seems to check the whole file and not my changes. Additionally the imx9_romapi checks happen to the parameters i.e: `line 78: uint32_t imx9_romapi_query_boot_infor(uint32_t infor_type, uint32_t *infor)` I used the same convention as chosen by NXP:  The rest of the changes are not introduced by me: > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:67: implemet ==> implement > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:68: booloader ==> bootloader > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:842: mumber ==> number > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_ele.h:129: envents ==> events, invents > /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_ele.h:146: envents ==> events, invents Should I create a new commit just for spellchecks to pass this PR? In general I don't like to mix my PR with unrelated spellchecks but if the workflow works like this, I will do so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]
xiaoxiang781216 commented on code in PR #16332: URL: https://github.com/apache/nuttx/pull/16332#discussion_r2077905822 ## .codespellrc: ## @@ -47,3 +47,4 @@ ignore-words-list = tolen, UE, WRON, + infor, Review Comment: why the short isn't info, but infor? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]
tkaratapanis commented on code in PR #16332: URL: https://github.com/apache/nuttx/pull/16332#discussion_r2077908272 ## .codespellrc: ## @@ -47,3 +47,4 @@ ignore-words-list = tolen, UE, WRON, + infor, Review Comment: It is just to match the NXP reference manual for the ROM API:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]
acassis commented on PR #16332: URL: https://github.com/apache/nuttx/pull/16332#issuecomment-2858707197 @tkaratapanis yes, the codespell will verify all issues existing in any life you modify. Same apply to code style. Case there is some life in the mainline that never passed by the nxstyle check and you modify it, the CI will generated an error. Please add "infor" to ignore-words-list of .codespellrc file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]
acassis commented on PR #16332: URL: https://github.com/apache/nuttx/pull/16332#issuecomment-2858504952 Hi @tkaratapanis please fix the CMake format and typos: ``` ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/cmake/Toolchain.cmake cmake-format check failed, run following command to update the style: $ cmake-format -o ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/cmake/Toolchain.cmake /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:67: implemet ==> implement /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:68: booloader ==> bootloader /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/Kconfig:842: mumber ==> number /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_ele.h:129: envents ==> events, invents /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_ele.h:146: envents ==> events, invents /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_romapi.c:78: infor ==> info, inform, in for /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_romapi.c:83: infor ==> info, inform, in for /home/runner/work/nuttx/nuttx/nuttx/arch/arm64/src/imx9/imx9_romapi.c:84: infor ==> info, inform, in for `` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]
xiaoxiang781216 commented on PR #16332: URL: https://github.com/apache/nuttx/pull/16332#issuecomment-2857447621 @tkaratapanis please drop the last merge patch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] arch/arm64/imx9: Support for AHAB authentication + ROMAPI [nuttx]
xiaoxiang781216 commented on code in PR #16332: URL: https://github.com/apache/nuttx/pull/16332#discussion_r2076996895 ## tools/imx9/Config.mk: ## @@ -47,6 +47,13 @@ ifeq ($(CONFIG_IMX9_BOOTLOADER),y) FCB_TOOL_PATH = $(BASE_PATH)$(FCB_TOOL) EXTRAFLAGS += -mstrict-align +# If we don't use MMU all memory is treated as device memory and can't handle alignment faults. +# Some compiler builtins like memset() can introduce alignment faults, so we need to disable them +# if we don't use the MMU. +ifneq ($(CONFIG_ARCH_USE_MMU),y) Review Comment: let's move to common places for both cmake and makefile under arch/arm64/ ## arch/arm64/src/imx9/imx9_boot.c: ## @@ -142,9 +142,11 @@ void arm64_chip_boot(void) #endif #endif +#if defined(CONFIG_ARCH_USE_MMU) Review Comment: `#ifdef CONFIG_ARCH_USE_MMU` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
