Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
simbit18 commented on PR #16195: URL: https://github.com/apache/nuttx/pull/16195#issuecomment-2812994831 I was trying some tests with CMake with this board there seems to be some problem. ``` D:\nuttx>cmake --build build ninja: error: 'D:/nuttx/boards/arm/tiva/tm4c123g-launchpad/scripts/ld.script', needed by 'ld.script.tmp', missing and no known rule to make it ``` https://github.com/apache/nuttx/blob/edaa074e5160357f1b2f9a14c91af26d382df34e/boards/arm/tiva/tm4c123g-launchpad/src/CMakeLists.txt#L64 https://github.com/apache/nuttx/tree/master/boards/arm/tiva/tm4c123g-launchpad/scripts @roskuttan Please, could you check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
xiaoxiang781216 merged PR #16195: URL: https://github.com/apache/nuttx/pull/16195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
roskuttan closed pull request #16195: boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt URL: https://github.com/apache/nuttx/pull/16195 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
xiaoxiang781216 commented on PR #16195: URL: https://github.com/apache/nuttx/pull/16195#issuecomment-2800524404 > > @roskuttan please remove the merge patch from PR. > > What you mean? remove this patch: https://github.com/apache/nuttx/pull/16195/commits/589019aa4a0376d4e260a27c60a0f290734cc3b9 you have two patches in this pr: https://github.com/apache/nuttx/pull/16195/commits but it should be only one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
roskuttan commented on PR #16195: URL: https://github.com/apache/nuttx/pull/16195#issuecomment-2800443483 > @roskuttan please remove the merge patch from PR. What you mean? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
xiaoxiang781216 commented on PR #16195: URL: https://github.com/apache/nuttx/pull/16195#issuecomment-288401 @roskuttan please remove the merge patch from PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
roskuttan commented on PR #16195: URL: https://github.com/apache/nuttx/pull/16195#issuecomment-2799780508 > @roskuttan the CI detected some issues in your CMake file: > > ``` > ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/tiva/tm4c123g-launchpad/CMakeLists.txt > > cmake-format check failed, run following command to update the style: > $ cmake-format -o > > ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/tiva/tm4c123g-launchpad/CMakeLists.txt > ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/tiva/tm4c123g-launchpad/src/CMakeLists.txt > ``` > > As suggested you can use: > > $ cmake-format CMakelists.txt -o /tmp/CMakelists.txt > > The copy this CMake created at /tmp/ over your original CMakelists.txt file Fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
acassis commented on PR #16195: URL: https://github.com/apache/nuttx/pull/16195#issuecomment-2798862346 @roskuttan the CI detected some issues in your CMake file: ``` ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/tiva/tm4c123g-launchpad/CMakeLists.txt cmake-format check failed, run following command to update the style: $ cmake-format -o ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/tiva/tm4c123g-launchpad/CMakeLists.txt ERROR __main__.py:618: Check failed: /home/runner/work/nuttx/nuttx/nuttx/boards/arm/tiva/tm4c123g-launchpad/src/CMakeLists.txt ``` As suggested you can use: $ cmake-format CMakelists.txt -o /tmp/CMakelists.txt The copy this CMake created at /tmp/ over your original CMakelists.txt file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
lupyuen commented on PR #16195: URL: https://github.com/apache/nuttx/pull/16195#issuecomment-2797861049 Hi @roskuttan: Please sign off your commit with `git commit -s ; git push`. Thanks :-) - https://github.com/apache/nuttx/pull/16195/commits/63e7c237ff6ac37ee3fae0cd9e1ed3e9053b63da -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
nuttxpr commented on PR #16195: URL: https://github.com/apache/nuttx/pull/16195#issuecomment-2797408721 [**\[Experimental Bot, please feedback here\]**](https://github.com/search?q=repo%3Aapache%2Fnuttx+13552&type=issues) Yes, this PR appears to meet the NuttX requirements, although some minor improvements could be made. **Strengths:** * The summary clearly explains the change, its purpose, and how it works. * The impact section addresses key areas and notes the lack of impact on users relying on the existing build system. * Testing information includes the host and target details. **Areas for Improvement (to make it even better):** * **Summary:** Add a link to the relevant NuttX issue if one exists. Even if this PR doesn't directly address a specific issue, it might be related to ongoing CMake build system improvements. Mentioning this connection can be helpful. * **Impact:** Explicitly state NO for all other impact categories (user, hardware, documentation, security, compatibility) if they truly are not affected. This adds clarity. * **Testing:** * The CMake command should be the exact command used. Don't say "likely similar to." Provide the precise command so it's reproducible. * "Flashed and ran different programs many times without any errors" is vague. Be specific! Which programs? What functionality was tested? What constituted a successful test? Consider providing snippets of output showing expected behavior. Ideally, the logs before/after wouldn't be empty. While they might not be applicable in all scenarios, if there's any relevant output showing the change's effect, include it. Even a simple "Hello, World" example running successfully via CMake vs. make would be better than nothing. * Be explicit about the tools used: "Flashed using OpenOCD (version X.Y.Z)" or similar. **Example of improved testing section:** ``` ## Testing I confirm that changes are verified on the local setup and work as intended: * **Build Host:** WSL2 Ubuntu 24.04, Intel Core i5 10th Gen (Hexacore), CMake version X.Y.Z, Ninja version A.B.C * **Target:** `tm4c123g-launchpad`, OpenOCD version P.Q.R * **Verification Steps:** 1. Navigated to the root NuttX directory: `nuttxspace/nuttx`. 2. Executed the following CMake command: `cmake -B build -DBOARD_CONFIG=tm4c123g-launchpad:nsh -GNinja` 3. Built NuttX: `ninja -C build` 4. Flashed the built `nuttx.bin` to the tm4c123g-launchpad using OpenOCD: `openocd -f interface/stlink-v2.cfg -f target/tm4c123gh6pm.cfg -c "program build/nuttx.bin verify reset exit"` (Replace with your actual OpenOCD command and config files.) 5. Connected to the board's serial console. 6. Verified the NSH console started successfully by observing the NSH prompt: `nsh>` 7. Executed the `hello` command within NSH and observed the expected output: `Hello, World!` Testing logs after change (NSH interaction): ``` nsh> hello Hello, World! nsh> ``` ``` By adding this level of detail, reviewers can easily reproduce your testing and have more confidence in the changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
roskuttan closed pull request #16182: boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt URL: https://github.com/apache/nuttx/pull/16182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
simbit18 commented on code in PR #16182: URL: https://github.com/apache/nuttx/pull/16182#discussion_r2039684951 ## boards/arm/tiva/tm4c123g-launchpad/CMakeLists.txt: ## @@ -0,0 +1,22 @@ + +# boards/arm/tiva/tm4c123g-launchpad/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + Review Comment: hi @roskuttan add new line ``` add_subdirectory(src) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] boards/arm/tiva/tm4c123g-launchpad: add CMakeLists.txt [nuttx]
simbit18 commented on code in PR #16182: URL: https://github.com/apache/nuttx/pull/16182#discussion_r2039684951 ## boards/arm/tiva/tm4c123g-launchpad/CMakeLists.txt: ## @@ -0,0 +1,22 @@ + +# boards/arm/tiva/tm4c123g-launchpad/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# Licensed to the Apache Software Foundation (ASF) under one or more +# contributor license agreements. See the NOTICE file distributed with +# this work for additional information regarding copyright ownership. The +# ASF licenses this file to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance with the +# License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, WITHOUT +# WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the +# License for the specific language governing permissions and limitations +# under the License. +# + Review Comment: hi @roskuttan add new line -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
