Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
anchao merged PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
simbit18 commented on PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#issuecomment-4150355895 Hi @JianyuWang0623, please rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
simbit18 commented on PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#issuecomment-4141423932 @JianyuWang0623 This error is not related to this PR You will need to wait for this PR https://github.com/apache/nuttx-apps/pull/3440 to be merged, after which you will need to rebase ``` Configuration/Tool: sim/citest 2026-03-27 02:48:55 Cleaning... Configuring... Building NuttX... % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 % Total% Received % Xferd Average Speed TimeTime Time Current Dload Upload Total SpentLeft Speed 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 0 00 00 0 0 0 --:--:-- --:--:-- --:--:-- 0 100 1646k 100 1646k0 0 3078k 0 --:--:-- --:--:-- --:--:-- 5899k 100 143k0 143k0 0 286k 0 --:--:-- --:--:-- --:--:-- 286k Running NuttX... ++ pwd + olddir=/github/workspace/sources/nuttx + nuttdir=/github/workspace/sources/nuttx/boards/sim/sim/sim/configs/citest/../../../../../../ + cd /github/workspace/sources/nuttx/boards/sim/sim/sim/configs/citest/../../../../../../ + confpath=/github/workspace/sources/nuttx/boards/sim/sim/sim/configs/citest/config.yaml + jsonconf=/github/workspace/sources/nuttx/boards/sim/sim/sim/configs/citest/session.json + testpath=/github/workspace/nuttx-ntfc/external/nuttx-testing + ntfc test --testpath=/github/workspace/nuttx-ntfc/external/nuttx-testing --confpath=/github/workspace/sources/nuttx/boards/sim/sim/sim/configs/citest/config.yaml --jsonconf=/github/workspace/sources/nuttx/boards/sim/sim/sim/configs/citest/session.json /github/workspace/sources/nuttx/../nuttx/boards/sim/sim/sim/configs/citest/run.sh: line 35: ntfc: command not found + ret=127 + echo 127 + artifacts=/github/workspace/buildartifacts/sim/citest//ntfc + mkdir -p /github/workspace/buildartifacts/sim/citest//ntfc 127 + rm -f pytest.debug.log + mv result /github/workspace/buildartifacts/sim/citest//ntfc mv: cannot stat 'result': No such file or directory + cd /github/workspace/sources/nuttx + exit 127 [1/1] Normalize sim/citest ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
cederom commented on PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#issuecomment-4139799447 > > Awesome! @JianyuWang0623 could you also please add Documentation on how to use this application as part of documentation in [apache/nuttx#18609](https://github.com/apache/nuttx/pull/18609) bundle? :-) > > @cederom Will do! I’ve just added the usage documentation here: https://github.com/apache/nuttx/compare/9d2ec9642d7bf0c41699f104c06948febeac64b4..e4babac55082a02feef90ad9ed128a5c5ad84648 TANK U SIR! =) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
JianyuWang0623 commented on PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#issuecomment-4139793462 > Awesome! @JianyuWang0623 could you also please add Documentation on how to use this application as part of documentation in [apache/nuttx#18609](https://github.com/apache/nuttx/pull/18609) bundle? :-) @cederom Will do! I’ve just added the usage documentation here: https://github.com/apache/nuttx/compare/9d2ec9642d7bf0c41699f104c06948febeac64b4..e4babac55082a02feef90ad9ed128a5c5ad84648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
JianyuWang0623 commented on code in PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#discussion_r2998674659 ## examples/uvc_cam/CMakeLists.txt: ## @@ -0,0 +1,20 @@ +# ## +# apps/examples/uvc_cam/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# ## Review Comment: done, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
cederom commented on code in PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#discussion_r2998673015 ## examples/uvc_cam/Kconfig: ## @@ -0,0 +1,32 @@ +# Review Comment: for me examples/uvc_cam is okay :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
JianyuWang0623 commented on code in PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#discussion_r2998665077 ## examples/uvc_cam/Kconfig: ## @@ -0,0 +1,32 @@ +# Review Comment: @acassis @cederom I'd lean toward keeping it under `examples/` since it's a standalone demo app (similar to `examples/camera`) rather than a reusable library, which is what `videoutils/` typically hosts (openh264, x264). That said, I'm open to moving it if you feel `videoutils/` is a better fit — happy to discuss. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
cederom commented on code in PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#discussion_r2998112270 ## examples/uvc_cam/Kconfig: ## @@ -0,0 +1,32 @@ +# Review Comment: I guess the idea is to provide example code to serve as uvc_cam.. but videoutils can be a good place too :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
cederom commented on PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#issuecomment-4138833251 Awesome! @JianyuWang0623 could you also please add Documentation on how to use this application as part of documentation in https://github.com/apache/nuttx/pull/18609 bundle? :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
acassis commented on code in PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#discussion_r2996663911 ## examples/uvc_cam/Kconfig: ## @@ -0,0 +1,32 @@ +# Review Comment: @JianyuWang0623 I'm not sure if apps/examples is the best place to add this app. Maybe it should be inside apps/videoutils. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
simbit18 commented on code in PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#discussion_r2996132125 ## examples/uvc_cam/uvc_cam_main.c: ## @@ -0,0 +1,465 @@ +/ + * apps/examples/uvc_cam/uvc_cam_main.c + * + * SPDX-License-Identifier: Apache-2.0 + * Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
simbit18 commented on code in PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#discussion_r2996128578 ## examples/uvc_cam/Makefile: ## @@ -0,0 +1,19 @@ + +# apps/examples/uvc_cam/Makefile +# +# SPDX-License-Identifier: Apache-2.0 +# Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
simbit18 commented on code in PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#discussion_r2996126368 ## examples/uvc_cam/Make.defs: ## @@ -0,0 +1,10 @@ + +# apps/examples/uvc_cam/Make.defs +# +# SPDX-License-Identifier: Apache-2.0 +# + Review Comment: ditto -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] examples/uvc_cam: add UVC camera streaming app [nuttx-apps]
simbit18 commented on code in PR #3438: URL: https://github.com/apache/nuttx-apps/pull/3438#discussion_r2996119402 ## examples/uvc_cam/CMakeLists.txt: ## @@ -0,0 +1,20 @@ +# ## +# apps/examples/uvc_cam/CMakeLists.txt +# +# SPDX-License-Identifier: Apache-2.0 +# +# ## Review Comment: @JianyuWang0623 , please add the correct licence header https://github.com/apache/nuttx-apps/blob/master/CMakeLists.txt#L4-L21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
