Re: [PR] github: master branch protection tune. [nuttx]
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2861008024 Thank you @Humbedooh for help! :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] github: master branch protection tune. [nuttx]
Humbedooh merged PR #16336: URL: https://github.com/apache/nuttx/pull/16336 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] github: master branch protection tune. [nuttx]
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2860088035 Folks please approve this PR so it can be merged ;-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] github: master branch protection tune. [nuttx]
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2859804869 Yes @xiaoxiang781216, @Humbedooh is from Apache Infra Team.. please go ahead and merge this PR :-) As we can see here "contexts" block CI completion, thus we are commenting them out, hope that helps :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] github: master branch protection tune. [nuttx]
Humbedooh commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858927876 Am I correct in understanding that this is blocking your workflow right now and the project needs this PR force-merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] github: master branch protection tune. [nuttx]
xiaoxiang781216 commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2859299882 > Am I correct in understanding that this is blocking your workflow right now and the project needs this PR force-merged? @Humbedooh yes, do you have right to merge this pr to unblock our work. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] github: master branch protection tune. [nuttx]
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2859113555 > @Humbedooh: Am I correct in understanding that this is blocking your workflow right now and the project needs this PR force-merged? Yes Sir! Unfortunately :-P -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] github: master branch protection tune. [nuttx]
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858714562 Allright I commented out whole "contexts" section, as noted by @simbit18 it causes CI hangs, and @raiden00pl it may cause problems with nuttx and nuttx-apps updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] github: master branch protection tune. [nuttx]
simbit18 commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858573966 @cederom I am not very convinced about this check ``` protected_branches: master: required_status_checks: strict: false contexts: - Check - Lint - Build ``` How will a commit with only documentation be checked? PR https://github.com/apache/nuttx/pull/16328 see here https://github.com/apache/nuttx/pull/16328/checks I think it is necessary to leave only **- Lint** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] github: master branch protection tune. [nuttx]
cederom commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858526938 > @shtirlic: It's also interesting that I have my commits GPG verified in my pull branch, but they appear as unverified after the merge. We are in short window of testing and tuning repo protection settings that may be the cause, in general we do not enforce gpg crypto signatures, just a simple email signature, PR created before changes are applied may behave different :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
Re: [PR] github: master branch protection tune. [nuttx]
shtirlic commented on PR #16336: URL: https://github.com/apache/nuttx/pull/16336#issuecomment-2858466914 It's also interesting that I have my commits GPG verified in my pull branch, but they appear as unverified after the merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
