Re: [I] System group filtering hides valid consumer groups [rocketmq-dashboard]

2026-09-04 Thread via GitHub


lizhimins closed issue #2912: System group filtering hides valid consumer groups
URL: https://github.com/apache/rocketmq-dashboard/issues/2912


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] System group filtering hides valid consumer groups [rocketmq-dashboard]

2026-09-04 Thread via GitHub


lizhimins commented on issue #2912:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/2912#issuecomment-5536534654

   Resolved by #2907 (merged into rocketmq-studio as 0b131e63).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



Re: [I] System group filtering hides valid consumer groups [rocketmq-dashboard]

2026-09-01 Thread via GitHub


RockteMQ-AI commented on issue #2912:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/2912#issuecomment-5498248451

   **Issue Evaluation**
   
   Category: `bug` | Status: **Needs Info**
   
   The issue claims `SystemGroupFilter` "matches any group that starts with 
`CID_` or contains `_MONITOR`", but the actual implementation in 
`SystemGroupFilter.isSystem()` uses specific prefix matching:
   
   ```java
   return group.startsWith("CID_RMQ_SYS_")
   || group.startsWith("CID_ONSAPI_")
   || group.startsWith("CID_SYS_")
   || group.startsWith("CID_HOUSEKEEPING")
   || group.startsWith("rmq_sys_")
   || group.startsWith("%RETRY%")
   || group.startsWith("%DLQ%")
   || group.startsWith("TOOLS_CONSUMER")
   || group.startsWith("FILTERSRV_CONSUMER")
   || group.startsWith("SELF_TEST_");
   ```
   
   The filter does **not** match all `CID_` prefixed groups — only specific 
system prefixes (`CID_RMQ_SYS_`, `CID_ONSAPI_`, `CID_SYS_`, 
`CID_HOUSEKEEPING`). There is also no `_MONITOR` pattern in the current 
implementation.
   
   Could you clarify:
   1. Which version/branch exhibits the broader matching behavior you describe?
   2. Are you reporting a regression from an older implementation, or proposing 
a change to the current filter?
   
   The current implementation appears to correctly distinguish system groups 
from legitimate application groups that happen to use `CID_` prefixes.
   
   ---
   *Automated evaluation by RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



[I] System group filtering hides valid consumer groups [rocketmq-dashboard]

2026-09-01 Thread via GitHub


yuluo-yx opened a new issue, #2912:
URL: https://github.com/apache/rocketmq-dashboard/issues/2912

   SystemGroupFilter uses startsWith for TOOLS_CONSUMER, FILTERSRV_CONSUMER, 
and SELF_TEST_. RocketMQ allows suffixes in group names, while 
MixAll.isSysConsumerGroupPullMessage treats the reserved groups as exact names. 
As a result, legal user groups such as TOOLS_CONSUMER_monitor disappear from 
listings and dashboard counts.
   
   Reproduction:
   1. Create or discover a consumer group named TOOLS_CONSUMER_monitor.
   2. List consumer groups through the Apache provider or inspect dashboard 
totals.
   
   Actual: the group is classified as a system group and hidden.
   Expected: use RocketMQ MixAll canonical system-group classification while 
preserving Studio-specific reserved prefixes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]