[GitHub] [hadoop] bharatviswa504 commented on issue #634: HDDS-939. Add S3 access check to Ozone manager. Contributed by Ajay Kumar.

2019-03-26 Thread GitBox
bharatviswa504 commented on issue #634: HDDS-939. Add S3 access check to Ozone manager. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/634#issuecomment-476718602 +1 LGTM. Will commit this shortly. Th

[GitHub] [hadoop] bharatviswa504 commented on issue #634: HDDS-939. Add S3 access check to Ozone manager. Contributed by Ajay Kumar.

2019-03-25 Thread GitBox
bharatviswa504 commented on issue #634: HDDS-939. Add S3 access check to Ozone manager. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/634#issuecomment-476463735 @ajayydv Can you fix Jenkins reported issue and one minor NIT in the test. --

[GitHub] [hadoop] bharatviswa504 commented on issue #634: HDDS-939. Add S3 access check to Ozone manager. Contributed by Ajay Kumar.

2019-03-25 Thread GitBox
bharatviswa504 commented on issue #634: HDDS-939. Add S3 access check to Ozone manager. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/634#issuecomment-476328617 And also we can add few tests to verify the volumeName generated from the newly added function validates

[GitHub] [hadoop] bharatviswa504 commented on issue #634: HDDS-939. Add S3 access check to Ozone manager. Contributed by Ajay Kumar.

2019-03-21 Thread GitBox
bharatviswa504 commented on issue #634: HDDS-939. Add S3 access check to Ozone manager. Contributed by Ajay Kumar. URL: https://github.com/apache/hadoop/pull/634#issuecomment-475485998 > > I think if the awsAccessKey will not have realm, if it has just name we shall not see the issue. >