[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-28 Thread Hudson (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122734#comment-15122734 ] Hudson commented on HADOOP-12702: - FAILURE: Integrated in Hadoop-trunk-Commit #9203 (See

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-28 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122704#comment-15122704 ] Karthik Kambatla commented on HADOOP-12702: --- The unit test failures look unrel

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-28 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122671#comment-15122671 ] Hadoop QA commented on HADOOP-12702: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-28 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122394#comment-15122394 ] Karthik Kambatla commented on HADOOP-12702: --- bq. Should close() call flush()?

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120425#comment-15120425 ] Hadoop QA commented on HADOOP-12702: | (/) *{color:green}+1 overall{color}* | \\ \\

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120263#comment-15120263 ] Hadoop QA commented on HADOOP-12702: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-27 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15120115#comment-15120115 ] Karthik Kambatla commented on HADOOP-12702: --- Looks mostly good. Few minor comm

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119658#comment-15119658 ] Hadoop QA commented on HADOOP-12702: | (/) *{color:green}+1 overall{color}* | \\ \\

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119662#comment-15119662 ] Hadoop QA commented on HADOOP-12702: | (/) *{color:green}+1 overall{color}* | \\ \\

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-27 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15119645#comment-15119645 ] Hadoop QA commented on HADOOP-12702: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-26 Thread Karthik Kambatla (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15118451#comment-15118451 ] Karthik Kambatla commented on HADOOP-12702: --- Thanks for filing and working on

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117292#comment-15117292 ] Daniel Templeton commented on HADOOP-12702: --- [~steve_l], that's why HADOOP-127

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-26 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15117279#comment-15117279 ] Steve Loughran commented on HADOOP-12702: - ...we really need an IOE subclass for

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-25 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116255#comment-15116255 ] Hadoop QA commented on HADOOP-12702: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113891#comment-15113891 ] Hadoop QA commented on HADOOP-12702: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-23 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15113823#comment-15113823 ] Hadoop QA commented on HADOOP-12702: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112947#comment-15112947 ] Hadoop QA commented on HADOOP-12702: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112844#comment-15112844 ] Hadoop QA commented on HADOOP-12702: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-22 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15112739#comment-15112739 ] Hadoop QA commented on HADOOP-12702: | (x) *{color:red}-1 overall{color}* | \\ \\ ||

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-17 Thread Vikram Srivastava (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104060#comment-15104060 ] Vikram Srivastava commented on HADOOP-12702: FileSystem.create(Path) will de

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-17 Thread Vikram Srivastava (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104047#comment-15104047 ] Vikram Srivastava commented on HADOOP-12702: Also AbstractMetric.value retur

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-17 Thread Vikram Srivastava (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15104029#comment-15104029 ] Vikram Srivastava commented on HADOOP-12702: [~templedf] Can you please crea

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-13 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096999#comment-15096999 ] Steve Loughran commented on HADOOP-12702: - If it's hard, leave it out. I just th

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096974#comment-15096974 ] Daniel Templeton commented on HADOOP-12702: --- I dug into what it would take to

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15096230#comment-15096230 ] Daniel Templeton commented on HADOOP-12702: --- If {{NetUtils.getHostname()}} get

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-12 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095191#comment-15095191 ] Steve Loughran commented on HADOOP-12702: - It's conceivable for things to not kn

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15095050#comment-15095050 ] Daniel Templeton commented on HADOOP-12702: --- Please define "a complete mess."

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-11 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15093028#comment-15093028 ] Steve Loughran commented on HADOOP-12702: - fine, just handle the failure which c

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-11 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092977#comment-15092977 ] Daniel Templeton commented on HADOOP-12702: --- I originally used {{NetUtils.getH

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-11 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092939#comment-15092939 ] Steve Loughran commented on HADOOP-12702: - + use {{NetUtils.getHostname()}} to r

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-11 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092931#comment-15092931 ] Steve Loughran commented on HADOOP-12702: - Have you thought of writing as avro r

[jira] [Commented] (HADOOP-12702) Add an HDFS metrics sink

2016-01-11 Thread Steve Loughran (JIRA)
[ https://issues.apache.org/jira/browse/HADOOP-12702?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15092885#comment-15092885 ] Steve Loughran commented on HADOOP-12702: - line 91: include the exception in th