Re: [configuration] Closing opened input streams

2004-04-02 Thread Emmanuel Bourg
There is another stream in ClassPropertiesConfiguration if you can get a look Eric. Emmanuel - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [configuration] Closing opened input streams

2004-03-30 Thread Emmanuel Bourg
Eric Pugh wrote: I don't know, it seems though that if we can't close the stream, should we keep going? Yes I think so, the configuration is usable even if the stream cannot be closed. It's not a fatal error, but the user has to be notified to take the necessary measures. We may prefer using com

RE: [configuration] Closing opened input streams

2004-03-29 Thread Eric Pugh
ns Developers List > Subject: Re: [configuration] Closing opened input streams > > > Eric Pugh wrote: > > > We can do that.. Just need to trap and throw the resulting > IOException as a > > ConfigurationException then... > > I wouldn't throw an exception if close() f

Re: [configuration] Closing opened input streams

2004-03-29 Thread Emmanuel Bourg
Eric Pugh wrote: We can do that.. Just need to trap and throw the resulting IOException as a ConfigurationException then... I wouldn't throw an exception if close() fails, it doesn't prevent using the configuration since we have finished reading the stream at this point. A warning or a stack tr

RE: [configuration] Closing opened input streams

2004-03-29 Thread Eric Pugh
gt; Subject: Re: [configuration] Closing opened input streams > > > I just looked at the patch : > > --- PropertiesConfiguration.java 28 Mar 2004 14:43:04 - 1.5 > +++ PropertiesConfiguration.java 28 Mar 2004 15:34:23 - 1.6 > @@ -99,7 +99,9 @@ > p

Re: [configuration] Closing opened input streams

2004-03-29 Thread Emmanuel Bourg
resolved the problem! Thanks for sending it. Eric -Original Message- From: Stephen Colebourne [mailto:[EMAIL PROTECTED] Sent: Wednesday, March 17, 2004 9:30 PM To: Jakarta Commons Developers List Subject: [configuration] Closing opened input streams A bug was reported against [collections

RE: [configuration] Closing opened input streams

2004-03-28 Thread Eric Pugh
Hi Stephen, I think I have just resolved the problem! Thanks for sending it. Eric > -Original Message- > From: Stephen Colebourne [mailto:[EMAIL PROTECTED] > Sent: Wednesday, March 17, 2004 9:30 PM > To: Jakarta Commons Developers List > Subject: [configuration] Closi

Re: [configuration] Closing opened input streams

2004-03-22 Thread Emmanuel Bourg
I think this patch will fix the issue for [configuration]. Emmanuel Bourg Stephen Colebourne wrote: A bug was reported against [collections] ExtendedProperties http://issues.apache.org/bugzilla/show_bug.cgi?id=27737 I found that the input stream created in the constructor was not closed. I just

[configuration] Closing opened input streams

2004-03-17 Thread Stephen Colebourne
A bug was reported against [collections] ExtendedProperties http://issues.apache.org/bugzilla/show_bug.cgi?id=27737 I found that the input stream created in the constructor was not closed. I just checked PropertiesConfiguration, and the load() methods seem to have the same problem. Stephen