[jira] Commented: (DIGESTER-107) Provide ability to capture namespace snapshots

2006-09-25 Thread Simon Kitching (JIRA)
[ http://issues.apache.org/jira/browse/DIGESTER-107?page=comments#action_12437643 ] Simon Kitching commented on DIGESTER-107: - Looks good to me. I´d be happy for this to be committed. I guess you'll be asking about when a new Digester r

[jira] Commented: (DIGESTER-107) Provide ability to capture namespace snapshots

2006-09-24 Thread Rahul Akolkar (JIRA)
[ http://issues.apache.org/jira/browse/DIGESTER-107?page=comments#action_12437217 ] Rahul Akolkar commented on DIGESTER-107: Correct, I should've checked the type heirarchy for ESE. In any case, a RuntimeException shouldn't happen if th

[jira] Commented: (DIGESTER-107) Provide ability to capture namespace snapshots

2006-09-23 Thread Simon Kitching (JIRA)
[ http://issues.apache.org/jira/browse/DIGESTER-107?page=comments#action_12437190 ] Simon Kitching commented on DIGESTER-107: - Ok, let's go with the simplest patch (no caching). I don't think the code should be catching and ignoring Ex

[jira] Commented: (DIGESTER-107) Provide ability to capture namespace snapshots

2006-09-23 Thread Rahul Akolkar (JIRA)
[ http://issues.apache.org/jira/browse/DIGESTER-107?page=comments#action_12437150 ] Rahul Akolkar commented on DIGESTER-107: Thanks for the feedback. WRT the earlier patch: * I had the new members protected since to achieve the "cachin

[jira] Commented: (DIGESTER-107) Provide ability to capture namespace snapshots

2006-09-23 Thread Simon Kitching (JIRA)
[ http://issues.apache.org/jira/browse/DIGESTER-107?page=comments#action_12437112 ] Simon Kitching commented on DIGESTER-107: - This looks pretty good to me. The only question I have is whether the new members of the Digester class shoul