[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12447997
]
Stephen Colebourne commented on IO-86:
--
I may also need to add the collection of results to the exception. Without it,
the code that receives the exception can't s
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12447992
]
Niall Pemberton commented on IO-86:
---
I'm happy with what you propose.
As a side note, although my first planned real use for this is in a non
multi-threaded task (a
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12441912
]
Niall Pemberton commented on IO-86:
---
OK, changed committed. IMO internal and external cancellation are now well
documented and the exception is called "CancelExceptio
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12441855
]
Stephen Colebourne commented on IO-86:
--
It sounds like you have a use case for this which I don't have at present. I
suggest that you commit your code and we make
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12441815
]
Niall Pemberton commented on IO-86:
---
I see using an exception as a better mechanism for stopping the processing
(unwinding from the recursively called walk method) -
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12441581
]
Stephen Colebourne commented on IO-86:
--
This is beginning to feel like a can of worms.
With the exception/handleCancelled combination, why do we need handleCancell
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12441483
]
Stephen Colebourne commented on IO-86:
--
Why a boolean? Firstly, because it reduces the jar file size slightly (each
class is an overhead), but secondly because I w
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12440737
]
Niall Pemberton commented on IO-86:
---
IMO using an Exception to control the cancellation process was a (slightly)
more elegant way to implement that behaviour. It also
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12440679
]
Stephen Colebourne commented on IO-86:
--
I've comitted a change for cancellation based on this patch but without the
exception. I used a boolean instead. It also al
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12440680
]
Stephen Colebourne commented on IO-86:
--
Next question. What about exceptions, notably IOException, which is a checked
exception. Should DirectoryWalker
- allow eac
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12436582
]
Niall Pemberton commented on IO-86:
---
Providing something for cancellation is a good idea, but I agree we shouldn't
introduce any performance penalty when many impleme
[ http://issues.apache.org/jira/browse/IO-86?page=comments#action_12435308
]
Stephen Colebourne commented on IO-86:
--
Should we have cancel() functionality in DirectoryWalker?
This could be achieved by having a volatile boolean cancel flag a
12 matches
Mail list logo
