[jira] Commented: (POOL-91) StackObjectPool.borrowObject infinate loop when makeObject returns null

2006-12-15 Thread Sandy McArthur (JIRA)
[ http://issues.apache.org/jira/browse/POOL-91?page=comments#action_12458935 ] Sandy McArthur commented on POOL-91: Ben, a pool can pool any "Poolable Object". That could be a Thread or just about any other reusable object. There is a differ

[jira] Commented: (POOL-91) StackObjectPool.borrowObject infinate loop when makeObject returns null

2006-12-15 Thread Ben Speakmon (JIRA)
[ http://issues.apache.org/jira/browse/POOL-91?page=comments#action_12458919 ] Ben Speakmon commented on POOL-91: -- I'm interested in the decorated factory approach -- how would you see that API working? Sandy, your point about the concurrent l

[jira] Commented: (POOL-91) StackObjectPool.borrowObject infinate loop when makeObject returns null

2006-12-15 Thread Sandy McArthur (JIRA)
[ http://issues.apache.org/jira/browse/POOL-91?page=comments#action_12458847 ] Sandy McArthur commented on POOL-91: I think there is a fundamental difference between a ThreadPoolExecutor and ObjectPool. Mainly that with a Executor your clien

[jira] Commented: (POOL-91) StackObjectPool.borrowObject infinate loop when makeObject returns null

2006-12-15 Thread JIRA
[ http://issues.apache.org/jira/browse/POOL-91?page=comments#action_12458821 ] Holger Hoffstätte commented on POOL-91: --- Hi - I've been following this thread for a while and understand the pros and cons of both the lenient and strict approa

[jira] Commented: (POOL-91) StackObjectPool.borrowObject infinate loop when makeObject returns null

2006-12-08 Thread Ben Speakmon (JIRA)
[ http://issues.apache.org/jira/browse/POOL-91?page=comments#action_12456990 ] Ben Speakmon commented on POOL-91: -- Also, I'd be happy to come up with some sample policies that implement such an interface. I'll put together an example that does

[jira] Commented: (POOL-91) StackObjectPool.borrowObject infinate loop when makeObject returns null

2006-12-08 Thread Ben Speakmon (JIRA)
[ http://issues.apache.org/jira/browse/POOL-91?page=comments#action_12456971 ] Ben Speakmon commented on POOL-91: -- I'm not sure I like throwing the exception either. I can think of situations where I might want borrowings to fail silently or ev

[jira] Commented: (POOL-91) StackObjectPool.borrowObject infinate loop when makeObject returns null

2006-12-07 Thread Sandy McArthur (JIRA)
[ http://issues.apache.org/jira/browse/POOL-91?page=comments#action_12456609 ] Sandy McArthur commented on POOL-91: For me it's an issue of usability. I view a pool as a source of reusable heavyweight objects. If the pool is unable to provid

[jira] Commented: (POOL-91) StackObjectPool.borrowObject infinate loop when makeObject returns null

2006-12-07 Thread Henri Yandell (JIRA)
[ http://issues.apache.org/jira/browse/POOL-91?page=comments#action_12456578 ] Henri Yandell commented on POOL-91: --- What would be bad about returning null again? [Sorry for the dumb question - I've not done much Pool dev in the past so new to

[jira] Commented: (POOL-91) StackObjectPool.borrowObject infinate loop when makeObject returns null

2006-11-22 Thread Sandy McArthur (JIRA)
[ http://issues.apache.org/jira/browse/POOL-91?page=comments#action_12452008 ] Sandy McArthur commented on POOL-91: makeObject returning null is definitely bogus behavior, but in older version of Pool (1.2 and before) StackObjectPool would r

[jira] Commented: (POOL-91) StackObjectPool.borrowObject infinate loop when makeObject returns null

2006-11-22 Thread Henri Yandell (JIRA)
[ http://issues.apache.org/jira/browse/POOL-91?page=comments#action_12451983 ] Henri Yandell commented on POOL-91: --- Is there any reason for null to be a legal makeObject return? ie) could we throw a RuntimeException of some kind when null is r