RE: [dbcp] PoolableConnectionFactory validation and synchronized methods

2003-11-24 Thread Brad Johnson
Re: [dbcp] PoolableConnectionFactory validation and synchronized methods Hello Brad, There is indeed no technical reason why PoolableConnectionFactory should be synchronized but I didn't want to include this change in 1.1. First it should be tested by multiple people / multiple database systems to see how th

Re: [dbcp] PoolableConnectionFactory validation and synchronized methods

2003-11-22 Thread Dirk Verbeeck
Todd, Your issue is a different from the performance increase Brad proposes. He is talking about a BasicDataSource pool like system with PoolableConnectionFactory and a GenericObjectPool. This pool is already optimized, the GenericKeyedObjectPool isn't. I don't agree with your statement that the

Re: [dbcp] PoolableConnectionFactory validation and synchronized methods

2003-11-22 Thread Dirk Verbeeck
Hello Brad, There is indeed no technical reason why PoolableConnectionFactory should be synchronized but I didn't want to include this change in 1.1. First it should be tested by multiple people / multiple database systems to see how the system reacts in the real world. There is indeed a good c

RE: [dbcp] PoolableConnectionFactory validation and synchronized methods

2003-11-21 Thread Todd Carmichael
The issue of high concurrency is very important to us as well. What I would like to see is the narrowing of the synchronization in borrowObject to include only grabbing a idle object or to making a new object and placing it the pool. Activation of the object should NOT be sychronized. This is b