Re: [digester] variable expansion

2003-12-04 Thread robert burrell donkin
On 3 Dec 2003, at 22:46, Simon Kitching wrote: On Fri, 2003-12-05 at 11:17, Simon Kitching wrote: Hi Robert, I think the code committed is just fine. On further thought, I have a more significant change to suggest. I think the VariableSubstitutor and MultiVariableExpander classes should be merg

Re: [digester] variable expansion

2003-12-03 Thread robert burrell donkin
hi simon On 4 Dec 2003, at 09:17, Simon Kitching wrote: In VariableSubstitutor, you use lazy creation for variableAttributes. I'm not sure there is much point to that. Given that the user has set up var expansion in the first place, the object will almost certainly be created sometime. However

Re: [digester] variable expansion

2003-12-03 Thread robert burrell donkin
hi ash On 3 Dec 2003, at 09:59, ASHWIN Suresh wrote: Sorry to jump in to this thread this way, and perhaps it is too late now. But, have the people here considered using the term "resolve" for this concept? Perhaps the interface could be named Resolver, with the method resolve(). I can think of

RE: [digester] variable expansion

2003-12-03 Thread Ash ..
-Original Message- From: Simon Kitching [mailto:[EMAIL PROTECTED] On Wed, 2003-12-03 at 22:59, ASHWIN Suresh wrote: > Sorry to jump in to this thread this way, and perhaps it is too late now. > But, have the people here considered using the term "resolve" > for this concept? I don't thi

Re: [digester] variable expansion

2003-12-03 Thread Simon Kitching
On Fri, 2003-12-05 at 11:17, Simon Kitching wrote: > Hi Robert, > > I think the code committed is just fine. On further thought, I have a more significant change to suggest. I think the VariableSubstitutor and MultiVariableExpander classes should be merged. VariableSubstitutor really is a nothin

RE: [digester] variable expansion

2003-12-03 Thread Simon Kitching
On Wed, 2003-12-03 at 22:59, ASHWIN Suresh wrote: > Sorry to jump in to this thread this way, and perhaps it is too late now. > But, have the people here considered using the term "resolve" > for this concept? I don't think it is too late for suggestions like this. Any time before the release is n

RE: [digester] variable expansion

2003-12-03 Thread ASHWIN Suresh
Sorry to jump in to this thread this way, and perhaps it is too late now. But, have the people here considered using the term "resolve" for this concept? Perhaps the interface could be named Resolver, with the method resolve(). I can think of ${foo} > xyz as resolving the definition rather than s