skitching 2004/02/24 23:15:28 Modified: digester/src/test/org/apache/commons/digester CallMethodRuleTestCase.java Test8.xml Log: Validate order in which CallMethodRule instances fire. See bugzilla #12997. Revision Changes Path 1.14 +10 -10 jakarta-commons/digester/src/test/org/apache/commons/digester/CallMethodRuleTestCase.java Index: CallMethodRuleTestCase.java =================================================================== RCS file: /home/cvs/jakarta-commons/digester/src/test/org/apache/commons/digester/CallMethodRuleTestCase.java,v retrieving revision 1.13 retrieving revision 1.14 diff -u -r1.13 -r1.14 --- CallMethodRuleTestCase.java 16 Feb 2004 02:26:38 -0000 1.13 +++ CallMethodRuleTestCase.java 25 Feb 2004 07:15:28 -0000 1.14 @@ -150,8 +150,7 @@ /** * Test method calls with the CallMethodRule rule. It should be possible - * to call any accessible method of the object on the top of the stack, - * even methods with no arguments. + * to call a method with no arguments using several rule syntaxes. */ public void testBasic() throws SAXException, IOException { @@ -195,9 +194,9 @@ /** - * Test method calls with the CallMethodRule rule. It should be possible - * to call any accessible method of the object on the top of the stack, - * even methods with no arguments. + * Test CallMethodRule variants which specify the classes of the + * parameters to target methods. String, int, boolean, float should all + * be acceptable as parameter types. */ public void testSettingProperties() throws SAXException, IOException { @@ -301,7 +300,8 @@ /** - * Test nested CallMethod rules. + * Test nested CallMethod rules. A CallMethodRule only fires when + * the end tag for its associated pattern is reached.. */ public void testOrderNested() throws Exception { @@ -322,7 +322,7 @@ fail("Digester threw Exception: " + t); } - assertEquals("Wrong method call order", "ABA", word.toString()); + assertEquals("Wrong method call order", "CBA", word.toString()); } 1.2 +1 -1 jakarta-commons/digester/src/test/org/apache/commons/digester/Test8.xml Index: Test8.xml =================================================================== RCS file: /home/cvs/jakarta-commons/digester/src/test/org/apache/commons/digester/Test8.xml,v retrieving revision 1.1 retrieving revision 1.2 diff -u -r1.1 -r1.2 --- Test8.xml 24 Sep 2002 20:50:07 -0000 1.1 +++ Test8.xml 25 Feb 2004 07:15:28 -0000 1.2 @@ -2,7 +2,7 @@ <toplevel>
<element name="A"> <element name="B"> - <element name="A"/> + <element name="C"/> </element> </element> </toplevel> --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]