Re: Memory Leaks When Using Statistics (was Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up))

2011-03-17 Thread Daniel Wagner
Hi Grant, Finally, I found some time for debugging. 2) Keeping connman in the stack, but changing the mapping from MAP_PRIVATE back to MAP_SHARED such that stats_file_setup fails with -EINVAL (due to being backed by a JFFS2 file system). Okay, that tells us at least if stats.c is not involved

Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up)

2011-02-18 Thread Daniel Wagner
Good Morning Grant, On 02/17/2011 11:48 PM, Grant Erickson wrote: On 2/17/11 12:13 PM, Daniel Wagner wrote: On 02/17/2011 05:38 PM, Grant Erickson wrote: Thanks for taking the time to submit a comment for the code detailing the motivation for selecting MAP_PRIVATE. I have done some more rese

Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up)

2011-02-17 Thread Grant Erickson
On 2/17/11 12:13 PM, Daniel Wagner wrote: > On 02/17/2011 05:38 PM, Grant Erickson wrote: >> Thanks for taking the time to submit a comment for the code detailing the >> motivation for selecting MAP_PRIVATE. >> >> I have done some more research to determine why the MAP_SHARED fails on my >> platfo

Re: Memory Leaks When Using Statistics (was Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up))

2011-02-17 Thread Daniel Wagner
Hi Grant, On 02/17/2011 07:10 PM, Grant Erickson wrote: Daniel: In temporarily making the change in my local tree from MAP_SHARED to MAP_PRIVATE against connman-0.68 to allow statistic to function against a JFFS2 file system, one of the things I started noticing is that memory started leaking p

Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up)

2011-02-17 Thread Daniel Wagner
Hi Grant, On 02/17/2011 05:38 PM, Grant Erickson wrote: On 1/31/11 1:47 AM, Daniel Wagner wrote: On Fri, Jan 28, 2011 at 08:13:28PM -0800, Grant Erickson wrote: As far as I can see, the stats mapping is not published or shared outside of connman. If so, there's no reason to map it SHARED versu

Re: Memory Leaks When Using Statistics (was Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up))

2011-02-17 Thread Jukka Rissanen
Hi Grant, On 17 February 2011 20:10, Grant Erickson wrote: > To isolate the leaks, I systematically eliminated processes from the system > until I was left with: > >    - syslogd >    - klogd >    - wpa_supplicant >    - dbus-daemon >    - connmand > I have run connmand under valgrind and it rep

Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up)

2011-02-17 Thread Grant Erickson
On 1/31/11 1:47 AM, Daniel Wagner wrote: > On Fri, Jan 28, 2011 at 08:13:28PM -0800, Grant Erickson wrote: >> As far as I can see, the stats mapping is not published or shared outside of >> connman. If so, there's no reason to map it SHARED versus PRIVATE. > > From the mmap man pages: > > MAP_SHA

Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up)

2011-01-31 Thread Grant Erickson
On 1/31/11 1:47 AM, Daniel Wagner wrote: > On Fri, Jan 28, 2011 at 08:13:28PM -0800, Grant Erickson wrote: >> As far as I can see, the stats mapping is not published or shared outside of >> connman. If so, there's no reason to map it SHARED versus PRIVATE. > >> From the mmap man pages: > > MAP_SH

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-31 Thread Grant Erickson
On 1/30/11 2:46 PM, Samuel Ortiz wrote: > On Sun, Jan 30, 2011 at 01:37:30PM -0800, Grant Erickson wrote: >> The requested log output is as follows. It would seem that the wifi.so >> plug-in and the wpa_supplicant are not even communicating: > Correct. > > >> # /sbin/wpa_supplicant -ddd -t -u &

Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up)

2011-01-31 Thread Daniel Wagner
On 01/28/2011 10:39 PM, Grant Erickson wrote: diff -aruN a/src/stats.c b/src/stats.c --- a/src/stats.c 2011-01-28 13:20:49.248299633 -0800 +++ b/src/stats.c 2011-01-28 13:19:44.824306025 -0800 @@ -223,10 +223,18 @@ TFR(close(file->fd)); file->fd = -1; - if (file

Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up)

2011-01-31 Thread Daniel Wagner
Hi Grant, On Fri, Jan 28, 2011 at 08:13:28PM -0800, Grant Erickson wrote: > As far as I can see, the stats mapping is not published or shared outside of > connman. If so, there's no reason to map it SHARED versus PRIVATE. >From the mmap man pages: MAP_SHARED Share this mapping. Upd

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-30 Thread Grant Erickson
On 1/30/11 2:46 PM, Samuel Ortiz wrote: > On Sun, Jan 30, 2011 at 01:37:30PM -0800, Grant Erickson wrote: >> The requested log output is as follows. It would seem that the wifi.so >> plug-in and the wpa_supplicant are not even communicating: > > Correct. > >> # /sbin/wpa_supplicant -ddd -t -u & >

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-30 Thread Samuel Ortiz
Hi Grant, On Sun, Jan 30, 2011 at 01:37:30PM -0800, Grant Erickson wrote: > The requested log output is as follows. It would seem that the wifi.so > plug-in and the wpa_supplicant are not even communicating: Correct. > # /sbin/wpa_supplicant -ddd -t -u & > 1296422968.146540: Providing DBus serv

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-30 Thread Grant Erickson
On 1/28/11 4:51 PM, Samuel Ortiz wrote: > On Fri, Jan 28, 2011 at 02:52:36PM -0800, Grant Erickson wrote: >> With the wired Ethernet issue debugged and patched, I've done more >> investigation on the wireless issue. The results are as follows: >> >>

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-30 Thread Grant Erickson
On 1/30/11 1:52 AM, Kalle Valo wrote: > Grant Erickson writes: >> Between you and Samuel, it's good to hear that both the Atheros AR242x and >> Intel IWLAGN work well with 0.68/b1db3cb under wireless extensions with the >> non-legacy Wi-Fi plug-in. Would I be correct in assuming that both you and

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-30 Thread Kalle Valo
Hi Grant, Grant Erickson writes: > Between you and Samuel, it's good to hear that both the Atheros AR242x and > Intel IWLAGN work well with 0.68/b1db3cb under wireless extensions with the > non-legacy Wi-Fi plug-in. Would I be correct in assuming that both you and > Samuel are using a Core iX or

RE: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-29 Thread Zheng, Jeff
stablishing a connection. > > As cited below, I still owe Samuel a wpa_supplicant trace. > > Best, > > Grant > > >> -Original Message- > >> From: connman-boun...@connman.net > >> [mailto:connman-boun...@connman.net] On Behalf Of Samuel Ortiz > &

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-29 Thread Grant Erickson
- >> From: connman-boun...@connman.net >> [mailto:connman-boun...@connman.net] On Behalf Of Samuel Ortiz >> Sent: Saturday, January 29, 2011 8:52 AM >> To: Grant Erickson >> Cc: connman@connman.net >> Subject: Re: Connman-0.67 Crashes and/or Hangs on Start-up >>

RE: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-29 Thread Zheng, Jeff
52 AM > To: Grant Erickson > Cc: connman@connman.net > Subject: Re: Connman-0.67 Crashes and/or Hangs on Start-up > > Hi Grant, > > On Fri, Jan 28, 2011 at 02:52:36PM -0800, Grant Erickson wrote: > > On Jan 28, 2011, at 10:09 AM, Grant Erickson wrote: > > > On Jan 28

Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up)

2011-01-28 Thread Grant Erickson
On 1/28/11 6:14 PM, Samuel Ortiz wrote: > On Fri, Jan 28, 2011 at 01:39:09PM -0800, Grant Erickson wrote: >> On Jan 28, 2011, at 12:10 PM, Grant Erickson wrote: >>> On Jan 28, 2011, at 10:09 AM, Grant Erickson wrote: On Jan 28, 2011, at 9:44 AM, Samuel Ortiz wrote: > On Fri, Jan 28, 2011 a

Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up)

2011-01-28 Thread Grant Erickson
On Jan 28, 2011, at 6:14 PM, Samuel Ortiz wrote: > On Fri, Jan 28, 2011 at 01:39:09PM -0800, Grant Erickson wrote: >> On Jan 28, 2011, at 12:10 PM, Grant Erickson wrote: >>> On Jan 28, 2011, at 10:09 AM, Grant Erickson wrote: On Jan 28, 2011, at 9:44 AM, Samuel Ortiz wrote: > On Fri, Jan

Re: [PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up)

2011-01-28 Thread Samuel Ortiz
Hi Grant, On Fri, Jan 28, 2011 at 01:39:09PM -0800, Grant Erickson wrote: > On Jan 28, 2011, at 12:10 PM, Grant Erickson wrote: > > On Jan 28, 2011, at 10:09 AM, Grant Erickson wrote: > >> On Jan 28, 2011, at 9:44 AM, Samuel Ortiz wrote: > >>> On Fri, Jan 28, 2011 at 09:06:12AM -0800, Grant Ericks

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-28 Thread Samuel Ortiz
Hi Grant, On Fri, Jan 28, 2011 at 02:52:36PM -0800, Grant Erickson wrote: > On Jan 28, 2011, at 10:09 AM, Grant Erickson wrote: > > On Jan 28, 2011, at 9:44 AM, Samuel Ortiz wrote: > >> On Fri, Jan 28, 2011 at 09:06:12AM -0800, Grant Erickson wrote: > >>> FYI. I need to check against GIT top-of-tr

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-28 Thread Grant Erickson
On Jan 28, 2011, at 10:09 AM, Grant Erickson wrote: > On Jan 28, 2011, at 9:44 AM, Samuel Ortiz wrote: >> On Fri, Jan 28, 2011 at 09:06:12AM -0800, Grant Erickson wrote: >>> FYI. I need to check against GIT top-of-tree and dig into this further; >>> however, with: >>> >>> * Wireless 802.11 WE

[PATCH 1/1]: Fix Memory-map and Double-free Errors in Statistics Handling (was Re: Connman-0.67 Crashes and/or Hangs on Start-up)

2011-01-28 Thread Grant Erickson
On Jan 28, 2011, at 12:10 PM, Grant Erickson wrote: > On Jan 28, 2011, at 10:09 AM, Grant Erickson wrote: >> On Jan 28, 2011, at 9:44 AM, Samuel Ortiz wrote: >>> On Fri, Jan 28, 2011 at 09:06:12AM -0800, Grant Erickson wrote: FYI. I need to check against GIT top-of-tree and dig into this furth

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-28 Thread Grant Erickson
On Jan 28, 2011, at 10:09 AM, Grant Erickson wrote: > On Jan 28, 2011, at 9:44 AM, Samuel Ortiz wrote: >> On Fri, Jan 28, 2011 at 09:06:12AM -0800, Grant Erickson wrote: >>> FYI. I need to check against GIT top-of-tree and dig into this further; >>> however, with: >>> >>> * Wired Ethernet con

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-28 Thread Grant Erickson
On Jan 28, 2011, at 9:06 AM, Grant Erickson wrote: > FYI. I need to check against GIT top-of-tree and dig into this further; > however, with: > > * Wired Ethernet connected, connman-0.67 crashes on start-up > * Wireless 802.11 WEXT, connman-0.67 hangs on start-up Confirmed identical

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-28 Thread Grant Erickson
On Jan 28, 2011, at 9:44 AM, Samuel Ortiz wrote: > On Fri, Jan 28, 2011 at 09:06:12AM -0800, Grant Erickson wrote: >> FYI. I need to check against GIT top-of-tree and dig into this further; >> however, with: >> >> * Wired Ethernet connected, connman-0.67 crashes on start-up >> * Wireles

Re: Connman-0.67 Crashes and/or Hangs on Start-up

2011-01-28 Thread Samuel Ortiz
Hi Grant, On Fri, Jan 28, 2011 at 09:06:12AM -0800, Grant Erickson wrote: > FYI. I need to check against GIT top-of-tree and dig into this further; > however, with: > > * Wired Ethernet connected, connman-0.67 crashes on start-up > * Wireless 802.11 WEXT, connman-0.67 hangs on start-