Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-23 Thread Volker Simonis
On Mon, 21 Feb 2022 18:05:08 GMT, Lance Andersen wrote: >>> The change looks innocuous so it is probably OK. I would like to kick of >>> our Mach5 runs to see if it shakes out any potential issues. >> >> @LanceAndersen , did you manage to get any Mach5 results? Did you find any >> issues? > >>

Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-22 Thread Lance Andersen
On Thu, 17 Feb 2022 16:02:42 GMT, Volker Simonis wrote: >> Currently, `InflaterInputStream::read()` first does a native call to the >> underlying zlib `inflate()` function and only afterwards checks if the >> inflater requires input (i.e. `Inflater::needsInput()`) or has finished >> inflating

Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-22 Thread Volker Simonis
On Mon, 21 Feb 2022 18:05:08 GMT, Lance Andersen wrote: > > > The change looks innocuous so it is probably OK. I would like to kick of > > > our Mach5 runs to see if it shakes out any potential issues. > > > > > > @LanceAndersen , did you manage to get any Mach5 results? Did you find any > >

Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-21 Thread Lance Andersen
On Mon, 21 Feb 2022 10:06:40 GMT, Volker Simonis wrote: > > The change looks innocuous so it is probably OK. I would like to kick of > > our Mach5 runs to see if it shakes out any potential issues. > > @LanceAndersen , did you manage to get any Mach5 results? Did you find any > issues? Tests

Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-21 Thread Claes Redestad
On Thu, 17 Feb 2022 16:02:42 GMT, Volker Simonis wrote: >> Currently, `InflaterInputStream::read()` first does a native call to the >> underlying zlib `inflate()` function and only afterwards checks if the >> inflater requires input (i.e. `Inflater::needsInput()`) or has finished >> inflating

Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-21 Thread Alan Bateman
On Thu, 17 Feb 2022 16:02:42 GMT, Volker Simonis wrote: >> Currently, `InflaterInputStream::read()` first does a native call to the >> underlying zlib `inflate()` function and only afterwards checks if the >> inflater requires input (i.e. `Inflater::needsInput()`) or has finished >> inflating

Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-21 Thread Volker Simonis
On Fri, 18 Feb 2022 08:46:51 GMT, Volker Simonis wrote: > The change looks innocuous so it is probably OK. I would like to kick of our > Mach5 runs to see if it shakes out any potential issues. @LanceAndersen , did you manage to get any Mach5 results? Did you find any issues? - P

Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-18 Thread Volker Simonis
On Thu, 17 Feb 2022 20:58:54 GMT, Lance Andersen wrote: > The change looks innocuous so it is probably OK. I would like to kick of our > Mach5 runs to see if it shakes out any potential issues. > Thanks Lance! Much appreciated. > From reading the 3rd party problem reports, it appears that the

Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-17 Thread Lance Andersen
On Thu, 17 Feb 2022 16:02:42 GMT, Volker Simonis wrote: >> Currently, `InflaterInputStream::read()` first does a native call to the >> underlying zlib `inflate()` function and only afterwards checks if the >> inflater requires input (i.e. `Inflater::needsInput()`) or has finished >> inflating

Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-17 Thread Volker Simonis
On Thu, 17 Feb 2022 10:01:11 GMT, Claes Redestad wrote: >> Volker Simonis has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Changed hardcoded constant to JMH parmater and removed non-ASCII chars >> from comments > > test/micro/org/openjdk

Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-17 Thread Volker Simonis
> Currently, `InflaterInputStream::read()` first does a native call to the > underlying zlib `inflate()` function and only afterwards checks if the > inflater requires input (i.e. `Inflater::needsInput()`) or has finished > inflating (`Inflater::finished()`). This leads to an unnecessary native

Re: RFR: 8281962: Avoid unnecessary native calls in InflaterInputStream [v2]

2022-02-17 Thread Volker Simonis
On Thu, 17 Feb 2022 09:35:47 GMT, Christoph Langer wrote: > Makes sense to me. Benchmark numbers look good. Thanks Christoph! - PR: https://git.openjdk.java.net/jdk/pull/7492