Re: RFR: 8285295: Need better testing for IdentityHashMap [v4]

2022-05-06 Thread Stuart Marks
On Fri, 6 May 2022 16:59:16 GMT, Lance Andersen wrote: >> Stuart Marks has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Add some assertions for entrySet.equals and keySet.equals > > I think you have done a nice job on the coverage. > > I

Re: RFR: 8285295: Need better testing for IdentityHashMap [v4]

2022-05-06 Thread Lance Andersen
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote: >> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch >> in the bug report that breaks `IdentityHashMap` now causes several cases in >> this new test to fail. There's more that could be done, but the new tests >> co

Re: RFR: 8285295: Need better testing for IdentityHashMap [v4]

2022-05-06 Thread ExE Boss
On Fri, 6 May 2022 06:39:59 GMT, XenoAmess wrote: > > It would be nice if such a test could be written, but as it stands I think > > that `Wrappers.java` test is too simplistic. > > Would adding `Wrappers.java` a method-name white-list mechanism suitable in > this situation? It should really 

Re: RFR: 8285295: Need better testing for IdentityHashMap [v4]

2022-05-05 Thread XenoAmess
On Thu, 5 May 2022 23:46:24 GMT, Stuart Marks wrote: > It would be nice if such a test could be written, but as it stands I think > that `Wrappers.java` test is too simplistic. Would adding `Wrappers.java` a method-name white-list mechanism suitable in this situation? - PR: https

Re: RFR: 8285295: Need better testing for IdentityHashMap [v4]

2022-05-05 Thread Stuart Marks
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote: >> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch >> in the bug report that breaks `IdentityHashMap` now causes several cases in >> this new test to fail. There's more that could be done, but the new tests >> co

Re: RFR: 8285295: Need better testing for IdentityHashMap [v4]

2022-05-05 Thread Stuart Marks
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote: >> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch >> in the bug report that breaks `IdentityHashMap` now causes several cases in >> this new test to fail. There's more that could be done, but the new tests >> co

Re: RFR: 8285295: Need better testing for IdentityHashMap [v4]

2022-05-05 Thread ExE Boss
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote: >> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch >> in the bug report that breaks `IdentityHashMap` now causes several cases in >> this new test to fail. There's more that could be done, but the new tests >> co

Re: RFR: 8285295: Need better testing for IdentityHashMap [v4]

2022-05-05 Thread Jaikiran Pai
On Wed, 4 May 2022 19:16:14 GMT, Stuart Marks wrote: >> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch >> in the bug report that breaks `IdentityHashMap` now causes several cases in >> this new test to fail. There's more that could be done, but the new tests >> co

Re: RFR: 8285295: Need better testing for IdentityHashMap [v4]

2022-05-04 Thread Stuart Marks
> Basic but fairly comprehensive set of tests for `IdentityHashMap`. The patch > in the bug report that breaks `IdentityHashMap` now causes several cases in > this new test to fail. There's more that could be done, but the new tests > cover most of the core functions of `IdentityHashMap`. Unfort