Re: Remaining doclint issues in java.net

2013-08-02 Thread Stuart Marks
On 8/2/13 2:37 AM, Chris Hegarty wrote: On 01/08/2013 22:18, Stuart Marks wrote: SocketAddress overloads. Two of them were within methods that declared "throws Exception." The third was within a try/catch block that catches IOException. None of the three cases would suffer a source incompatibili

Re: Remaining doclint issues in java.net

2013-08-02 Thread Matthew Hall
On Thu, Aug 01, 2013 at 02:18:01PM -0700, Stuart Marks wrote: > This isn't definitive, of course, but it does seem to supply some > evidence that making this change would result in a relatively minor > source incompatibility. Good, maybe it will allow a true fix to be made in this case. Matthew.

Re: Remaining doclint issues in java.net

2013-08-02 Thread Chris Hegarty
On 01/08/2013 23:08, Alan Bateman wrote: On 01/08/2013 14:18, Stuart Marks wrote: : To my eye the InetAddress/port constructors are used quite a bit more often than the SocketAddress ones. I did a web search for "java DatagramPacket example" and looked at all the examples on the first page of h

Re: Remaining doclint issues in java.net

2013-08-02 Thread Chris Hegarty
comments inline... On 01/08/2013 22:18, Stuart Marks wrote: On 7/31/13 2:39 PM, Matthew Hall wrote: On Wed, Jul 31, 2013 at 02:38:26PM -0700, Stuart Marks wrote: The alternative is to add "@throws SocketException never" to the javadoc, just to get rid of the doclint warning, but this has the c

Re: Remaining doclint issues in java.net

2013-08-01 Thread Joe Darcy
On 08/01/2013 03:08 PM, Alan Bateman wrote: On 01/08/2013 14:18, Stuart Marks wrote: : To my eye the InetAddress/port constructors are used quite a bit more often than the SocketAddress ones. I did a web search for "java DatagramPacket example" and looked at all the examples on the first pag

Re: Remaining doclint issues in java.net

2013-08-01 Thread Alan Bateman
On 01/08/2013 14:18, Stuart Marks wrote: : To my eye the InetAddress/port constructors are used quite a bit more often than the SocketAddress ones. I did a web search for "java DatagramPacket example" and looked at all the examples on the first page of hits. All of them used the InetAddress+p

Re: Remaining doclint issues in java.net

2013-08-01 Thread Stuart Marks
On 7/31/13 2:39 PM, Matthew Hall wrote: On Wed, Jul 31, 2013 at 02:38:26PM -0700, Stuart Marks wrote: The alternative is to add "@throws SocketException never" to the javadoc, just to get rid of the doclint warning, but this has the consequence of requiring people to keep dead code around indefi

Re: Remaining doclint issues in java.net

2013-08-01 Thread Matthew Hall
On Wed, Jul 31, 2013 at 02:38:26PM -0700, Stuart Marks wrote: > The alternative is to add "@throws SocketException never" to the > javadoc, just to get rid of the doclint warning, but this has the > consequence of requiring people to keep dead code around > indefinitely, and furthermore it requires

Re: Remaining doclint issues in java.net

2013-07-31 Thread Stuart Marks
On 7/29/13 7:28 AM, Chris Hegarty wrote: There are two remaining doclint warnings in the java.net package. >:javac -Xdoclint:all/protected src/share/classes/java/net/DatagramPacket.java src/share/classes/java/net/DatagramPacket.java:142: warning: no @throws for java.net.SocketException pu