On Thu, 25 May 2023 23:54:14 GMT, Andrei Pangin wrote:
>> UUID is the very important class that is used to track identities of objects
>> in large scale systems. On some of our systems, `UUID.randomUUID` takes >1%
>> of total CPU time, and is frequently a scalability bottleneck due to
>> `Secu
On 25/05/2023 7:21 pm, Raffaello Giulietti wrote:
Yes, ChildClass.class is removed from the filesystem.
And here's, the relevant info when running with -Xlog:class+init,
showing that verification succeeds for both TestLoading$ObjectReturner
and TestLoading$BaseClassReturner:
loading: TestL
On Fri, 26 May 2023 06:07:05 GMT, Joe Darcy wrote:
>> Jim Laskey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Improving error recovery in presence of less important syntactic errors in
>> top-level methods and fields.
>>
>> Auth
On Thu, 25 May 2023 14:32:44 GMT, Jim Laskey wrote:
>> Add flexible main methods and anonymous main classes to the Java language.
>
> Jim Laskey has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Improving error recovery in presence of less im
On Wed, 24 May 2023 19:36:44 GMT, Aleksey Shipilev wrote:
> UUID is the very important class that is used to track identities of objects
> in large scale systems. On some of our systems, `UUID.randomUUID` takes >1%
> of total CPU time, and is frequently a scalability bottleneck due to
> `Secur
On Wed, 24 May 2023 19:36:44 GMT, Aleksey Shipilev wrote:
> UUID is the very important class that is used to track identities of objects
> in large scale systems. On some of our systems, `UUID.randomUUID` takes >1%
> of total CPU time, and is frequently a scalability bottleneck due to
> `Secur
On Wed, 24 May 2023 09:36:34 GMT, Maurizio Cimadamore
wrote:
>> This patch adds an instance method on `Linker`, namely
>> `Linker::canonicalLayouts` which returns all the layouts known by the linker
>> as implementing some ABI type. For instance, if I call this on my machine
>> (Linux/x64) I
On Thu, 25 May 2023 08:29:37 GMT, Adam Sotona wrote:
> Class-File API actually throws wide variety of exceptions based on the actual
> situation. Complete error handling code must cover
> `IndexOutOfBoundsException`, `IllegalStateException` and
> `IllegalArgumentException`.
>
> Based on prev
> Amending the description about the default decomposition mode in
> `Collator.NO_DECOMPOSITION` javadoc.
Naoto Sato has updated the pull request incrementally with one additional
commit since the last revision:
use present tense
-
Changes:
- all: https://git.openjdk.org/jdk/p
On Thu, 25 May 2023 20:23:27 GMT, Mandy Chung wrote:
> Change `ClassFileDumper` constructor to take a `String` rather than `Path` to
> avoid the file system implementation classes loaded during startup. In
> addition, `FilePermission` also causes the default file system to be
> initialized.
On Sat, 20 May 2023 00:00:42 GMT, Justin Lu wrote:
> Please review this PR which updates the Scientific Notation section of
> Decimal Format. It aims to resolve
> [JDK-8159023](https://bugs.openjdk.org/browse/JDK-8159023) as well as
> [JDK-6282188](https://bugs.openjdk.org/browse/JDK-6282188).
> Amending the description about the default decomposition mode in
> `Collator.NO_DECOMPOSITION` javadoc.
Naoto Sato has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull req
> Add a system property, jdk.xml.config.file, to return the path to a custom
> JAXP configuration file. The current configuration file, jaxp.properties,
> that the JDK supports will become the default configuration file.
>
> CSR: https://bugs.openjdk.org/browse/JDK-8303531
>
> Tests: XML SQE an
On Fri, 5 May 2023 08:12:01 GMT, Alan Bateman wrote:
>> Changed the opening statement and also the naming of config file as above.
>
> I've looked through the updated proposal but I think the intro is going to
> take a few iterations to get to something that is easy to read. I had hoped
> the i
On Fri, 5 May 2023 08:16:14 GMT, Alan Bateman wrote:
>> Joe Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> address review comments
>
> src/java.xml/share/conf/jaxp.properties line 2:
>
>> 1:
>> ###
> Add a system property, jdk.xml.config.file, to return the path to a custom
> JAXP configuration file. The current configuration file, jaxp.properties,
> that the JDK supports will become the default configuration file.
>
> CSR: https://bugs.openjdk.org/browse/JDK-8303531
>
> Tests: XML SQE an
On Thu, 25 May 2023 08:21:39 GMT, Alan Bateman wrote:
>> This is the implementation of:
>>
>> - JEP 453: Structured Concurrency (Preview)
>> - JEP 446: Scoped Values (Preview)
>>
>> For the most part, this is just moving code and tests. StructuredTaskScope
>> moves to j.u.concurrent as a prev
Change `ClassFileDumper` constructor to take a `String` rather than `Path` to
avoid the file system implementation classes loaded during startup. In
addition, `FilePermission` also causes the default file system to be
initialized.
This patch changes `ClassFileDumper` to validate the given pat
On Thu, 25 May 2023 08:21:39 GMT, Alan Bateman wrote:
>> This is the implementation of:
>>
>> - JEP 453: Structured Concurrency (Preview)
>> - JEP 446: Scoped Values (Preview)
>>
>> For the most part, this is just moving code and tests. StructuredTaskScope
>> moves to j.u.concurrent as a prev
On Thu, 25 May 2023 08:21:39 GMT, Alan Bateman wrote:
>> This is the implementation of:
>>
>> - JEP 453: Structured Concurrency (Preview)
>> - JEP 446: Scoped Values (Preview)
>>
>> For the most part, this is just moving code and tests. StructuredTaskScope
>> moves to j.u.concurrent as a prev
Hello folks,
Since you are asking, let me chime in and say that I use enum's very
frequently. However, my most common use case for them isn't for boolean
flags -- it's actually the strategy pattern. Meaning, attaching a piece of
logic to each value. And more importantly, I order the strategies via
On Thu, 25 May 2023 15:04:32 GMT, Kim Barrett wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>> adjustments.
>> A lot of those ch
On Wed, 17 May 2023 19:40:04 GMT, Naoto Sato wrote:
> This change intends to interpret the BCP47 U extension wrt collation settings
> in the given `Locale`, then applies them to the created instances in the
> 1-arg factory method in `Collator`. A corresponding CSR has also been drafted.
This p
On Sun, 23 Apr 2023 17:33:38 GMT, Laurent Bourgès wrote:
>> * improved mixed insertion sort (makes whole sorting faster)
>> * introduced Radix which sort shows several times boost of performance and
>> has linear complexity instead of n*ln(n)
>> * improved merging sort for almost sorted data
>>
On Thu, 25 May 2023 15:18:41 GMT, Kim Barrett wrote:
>> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
>> on AIX , we run into various "warnings as errors".
>> Some of those are in shared codebase and could be addressed by small
>> adjustments.
>> A lot of those ch
> As the FFM API evolved over time, some parts of the javadoc went out of sync.
> Now that most of the API is stable, it is a good time to look again at the
> javadoc as a whole, and bring some more consistency.
>
> While most of the changes in this PR are stylistic, I'd like to call out few
>
On Thu, 25 May 2023 15:25:40 GMT, Volker Simonis wrote:
>> Since JDK13, executing commands in a sub-process defaults to the so called
>> `POSIX_SPAWN` launching mechanism (i.e.
>> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
>> using `posix_spawn(3)` to firstly sta
> Since JDK13, executing commands in a sub-process defaults to the so called
> `POSIX_SPAWN` launching mechanism (i.e.
> `-Djdk.lang.Process.launchMechanism=POSIX_SPAWN`) on Linux. This works by
> using `posix_spawn(3)` to firstly start a tiny helper program called
> `jspawnhelper` in a subproc
On Thu, 25 May 2023 09:14:14 GMT, JoKern65 wrote:
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
> on AIX , we run into various "warnings as errors".
> Some of those are in shared codebase and could be addressed by small
> adjustments.
> A lot of those changes ar
On Wed, 24 May 2023 15:22:15 GMT, Maurizio Cimadamore
wrote:
> There is a difference in behavior between `System::loadLibrary` and
> `SymbolLookup::libraryLookup(String)`. While the former catches library names
> containing NULL chars (because, internally it uses Path/File logic, which
> reje
On Mon, 22 May 2023 13:19:04 GMT, Michael McMahon wrote:
> This PR creates a new version of the JNI utility function
> JNU_GetStringPlatformChars called JNU_GetStringPlatformCharsStrict, which
> performs additional validation of the returned string, namely that it does
> not contain any embedd
> Add flexible main methods and anonymous main classes to the Java language.
Jim Laskey has updated the pull request incrementally with one additional
commit since the last revision:
Improving error recovery in presence of less important syntactic errors in
top-level methods and fields.
On Thu, 25 May 2023 14:21:34 GMT, Michael McMahon wrote:
> I'll integrate this today unless there are further comments.
Thanks for addressing my comments.
-
PR Comment: https://git.openjdk.org/jdk/pull/14083#issuecomment-1563002770
On Wed, 24 May 2023 20:46:23 GMT, Michael McMahon wrote:
>> This PR creates a new version of the JNI utility function
>> JNU_GetStringPlatformChars called JNU_GetStringPlatformCharsStrict, which
>> performs additional validation of the returned string, namely that it does
>> not contain any em
On Thu, 25 May 2023 14:01:43 GMT, Alan Bateman wrote:
>> UUID is the very important class that is used to track identities of objects
>> in large scale systems. On some of our systems, `UUID.randomUUID` takes >1%
>> of total CPU time, and is frequently a scalability bottleneck due to
>> `Secur
On Wed, 24 May 2023 19:36:44 GMT, Aleksey Shipilev wrote:
> UUID is the very important class that is used to track identities of objects
> in large scale systems. On some of our systems, `UUID.randomUUID` takes >1%
> of total CPU time, and is frequently a scalability bottleneck due to
> `Secur
On Thu, 25 May 2023 07:35:39 GMT, David Holmes wrote:
>> @AlanBateman Sounds good, thanks for confirming. I've updated both the
>> ProblemLists, but it needed yet another rebase, so yet another forced push.
>
>> it needed yet another rebase, so yet another forced push.
>
> You don't need to reb
On Thu, 25 May 2023 09:14:14 GMT, JoKern65 wrote:
> When using the new xlc17 compiler (based on a recent clang) to build OpenJDk
> on AIX , we run into various "warnings as errors".
> Some of those are in shared codebase and could be addressed by small
> adjustments.
> A lot of those changes ar
Fix of jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo returning correct
zero power of two.
Please review.
Thanks,
Adam
-
Commit messages:
- 8308856: jdk.internal.classfile.impl.EntryMap::nextPowerOfTwo math problem
Changes: https://git.openjdk.org/jdk/pull/14148/files
Webr
On Wed, 24 May 2023 19:36:44 GMT, Aleksey Shipilev wrote:
> UUID is the very important class that is used to track identities of objects
> in large scale systems. On some of our systems, `UUID.randomUUID` takes >1%
> of total CPU time, and is frequently a scalability bottleneck due to
> `Secur
UUID is the very important class that is used to track identities of objects in
large scale systems. On some of our systems, `UUID.randomUUID` takes >1% of
total CPU time, and is frequently a scalability bottleneck due to
`SecureRandom` synchronization.
The major issue with UUID code itself is
On Wed, 1 Feb 2023 10:36:12 GMT, Sergey Tsypanov wrote:
>> `ResourceBundle.CacheKey.equals()` and `Bundles.CacheKey.equals()` are quire
>> outdated. This simple clean-up modernizes them.
>
> Sergey Tsypanov has updated the pull request incrementally with one
> additional commit since the last r
On Wed, 24 May 2023 23:32:18 GMT, Pavel Rappo wrote:
> Please review this simple fix.
This pull request has now been integrated.
Changeset: 38367d3c
Author:Pavel Rappo
URL:
https://git.openjdk.org/jdk/commit/38367d3c3ad9292b7c581917c89e9f07fac3dd31
Stats: 9 lines in 3 files chan
On Thu, 25 May 2023 08:29:37 GMT, Adam Sotona wrote:
> Class-File API actually throws wide variety of exceptions based on the actual
> situation. Complete error handling code must cover
> `IndexOutOfBoundsException`, `IllegalStateException` and
> `IllegalArgumentException`.
>
> Based on prev
On Thu, 25 May 2023 09:12:58 GMT, Chen Liang wrote:
> What other types of exceptions does javap distinguish, and should Classfile
> API distinguish them as well?
Invalid CP index or content are cases where javap tries to recover, replace the
value with '???' and print the rest.
This PR is extr
When using the new xlc17 compiler (based on a recent clang) to build OpenJDk on
AIX , we run into various "warnings as errors".
Some of those are in shared codebase and could be addressed by small
adjustments.
A lot of those changes are in hotspot, some might be somewhere else in the
OpenJDK C/C
On Sun, 21 May 2023 09:19:47 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to improve the
> accessibility of the thread dump files that are generated by the `jcmd
> Thread.dump_to_file` command configured in the failure handler
> configurations? This addres
On Sun, 21 May 2023 09:19:47 GMT, Jaikiran Pai wrote:
> Can I please get a review of this change which proposes to improve the
> accessibility of the thread dump files that are generated by the `jcmd
> Thread.dump_to_file` command configured in the failure handler
> configurations? This addres
On Wed, 24 May 2023 13:56:05 GMT, Julian Waters wrote:
> On Windows, the basic Java Integer types are defined as long and __int64
> respectively. In particular, the former is rather problematic since it breaks
> compilation as the Visual C++ becomes stricter and more compliant with every
> rel
Yes, ChildClass.class is removed from the filesystem.
And here's, the relevant info when running with -Xlog:class+init,
showing that verification succeeds for both TestLoading$ObjectReturner
and TestLoading$BaseClassReturner:
loading: TestLoading$ObjectReturner...
[0.039s][info][class,init
On Thu, 25 May 2023 08:29:37 GMT, Adam Sotona wrote:
> Class-File API actually throws wide variety of exceptions based on the actual
> situation. Complete error handling code must cover
> `IndexOutOfBoundsException`, `IllegalStateException` and
> `IllegalArgumentException`.
>
> Based on prev
On Thu, 18 May 2023 09:50:13 GMT, Chang Peng wrote:
>> In Vector API Java level, vector mask is represented as a boolean array with
>> 0x00/0x01 (8 bits of each element) as values, aka in-memory format. When it
>> is loaded into vector register, e.g. Neon, the in-memory format will be
>> conve
On Wed, 24 May 2023 13:56:05 GMT, Julian Waters wrote:
> On Windows, the basic Java Integer types are defined as long and __int64
> respectively. In particular, the former is rather problematic since it breaks
> compilation as the Visual C++ becomes stricter and more compliant with every
> rel
Class-File API actually throws wide variety of exceptions based on the actual
situation. Complete error handling code must cover `IndexOutOfBoundsException`,
`IllegalStateException` and `IllegalArgumentException`.
Based on previous discussions we decided to consolidate on
`IllegalArgumentExcep
On Thu, 25 May 2023 04:46:04 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to improve the
>> accessibility of the thread dump files that are generated by the `jcmd
>> Thread.dump_to_file` command configured in the failure handler
>> configurations? This ad
> This is the implementation of:
>
> - JEP 453: Structured Concurrency (Preview)
> - JEP 446: Scoped Values (Preview)
>
> For the most part, this is just moving code and tests. StructuredTaskScope
> moves to j.u.concurrent as a preview API, ScopedValue moves to j.lang as a
> preview API, and m
> javap uses proprietary com.sun.tools.classfile library to parse class files.
>
> This patch converts javap to use Classfile API.
>
> Please review.
>
> Thanks,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 217
On Wed, 24 May 2023 08:30:21 GMT, Viktor Klang wrote:
> it needed yet another rebase, so yet another forced push.
You don't need to rebase (and force-push) you just merge with the master branch
and skara will take care of flattening the commits.
-
PR Comment: https://git.openjdk.o
On Thu, 25 May 2023 07:22:50 GMT, Julian Waters wrote:
> All the changes from long were done since there was conversion from or to a
> jint somewhere down the line,
Okay I see that now. It is a messy situation - at some point the incoming
jint's need to be "converted" to a native type.
--
On Wed, 24 May 2023 13:56:05 GMT, Julian Waters wrote:
> On Windows, the basic Java Integer types are defined as long and __int64
> respectively. In particular, the former is rather problematic since it breaks
> compilation as the Visual C++ becomes stricter and more compliant with every
> rel
On Thu, 25 May 2023 01:34:15 GMT, David Holmes wrote:
> I think the JNI type definition change is okay.
>
> However many of the other changes appear to me to not involve Java variables
> and so don't need to be Java types i.e they should be `int` rather than
> `jint` - though as these are nati
On Thu, 25 May 2023 04:46:04 GMT, Jaikiran Pai wrote:
>> Can I please get a review of this change which proposes to improve the
>> accessibility of the thread dump files that are generated by the `jcmd
>> Thread.dump_to_file` command configured in the failure handler
>> configurations? This ad
On Tue, 23 May 2023 12:54:20 GMT, Adam Sotona wrote:
> Classfile API allowed to generate Code attribute exceeding the 65k limit. No
> exception has been thrown during class generation and the class failed
> verification later during class loading.
> This patch adds Code size limit check throwin
63 matches
Mail list logo
