Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v6]

2024-01-03 Thread Adam Sotona
> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy classes. > > This patch converts it to use Classfile API. > > It is continuation of https://github.com/openjdk/jdk/pull/10991 > > Any comments and suggestions are welcome. > > Please review. > > Thank you, > Adam Adam Sot

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v6]

2023-03-16 Thread Mandy Chung
On Thu, 16 Mar 2023 15:20:27 GMT, Chen Liang wrote: >> Possible extensions of `ClassHierarchyResolver` factories, or maybe even >> extensions of the default resolver are on the table and I just planned to >> open this discussion. >> >> Here is specific case where original code passes `ClassLoa

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v6]

2023-03-16 Thread Chen Liang
On Thu, 16 Mar 2023 13:21:38 GMT, Adam Sotona wrote: >> src/java.base/share/classes/java/lang/reflect/ProxyGenerator.java line 426: >> >>> 424: */ >>> 425: localCache.computeIfAbsent(classDesc, cd -> { >>> 426: try { >> >> This probably can b

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v6]

2023-03-16 Thread Adam Sotona
On Sat, 11 Mar 2023 13:45:23 GMT, Chen Liang wrote: >> Adam Sotona has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 196 commits: >> >> - Merge branch 'master' into JDK-8294961-proxy >> - Merge branch 'master' into JDK-8294961-pro

Re: RFR: 8294961: Convert java.base/java.lang.reflect.ProxyGenerator to use the Classfile API to generate proxy classes [v6]

2023-03-11 Thread liach
On Fri, 10 Mar 2023 08:48:14 GMT, Adam Sotona wrote: >> java.base java.lang.reflect.ProxyGenerator uses ASM to generate proxy >> classes and this patch converts it to use Classfile API. >> >> Please review. >> >> Thank you, >> Adam > > Adam Sotona has updated the pull request with a new target