Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-04-12 Thread Brooks Davis
On Tue, Apr 11, 2006 at 11:58:02PM -0500, Christian S.J. Peron wrote: > Brooks Davis wrote: > >On Fri, Mar 31, 2006 at 09:06:32AM +, Robert Watson wrote: > > > >>On Fri, 31 Mar 2006, Peter Jeremy wrote: > >> > >> > >>>On Thu, 2006-Mar-30 21:04:52 +, Christian S.J. Peron wrote: > >>>

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-04-11 Thread Christian S.J. Peron
Brooks Davis wrote: On Fri, Mar 31, 2006 at 09:06:32AM +, Robert Watson wrote: On Fri, 31 Mar 2006, Peter Jeremy wrote: On Thu, 2006-Mar-30 21:04:52 +, Christian S.J. Peron wrote: This change allows syslogd to ignore ENOSPC space errors, so that when the filesystem is

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-04-11 Thread Brooks Davis
On Fri, Mar 31, 2006 at 09:06:32AM +, Robert Watson wrote: > > On Fri, 31 Mar 2006, Peter Jeremy wrote: > > >On Thu, 2006-Mar-30 21:04:52 +, Christian S.J. Peron wrote: > >> This change allows syslogd to ignore ENOSPC space errors, so that when > >> the > >> filesystem is cleaned up, sys

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Alfred Perlstein
* Robert Watson <[EMAIL PROTECTED]> [060331 09:20] wrote: > > On Fri, 31 Mar 2006, Alfred Perlstein wrote: > > >EDQUOT ? > > This won't normally happen for local file systems, as the root user isn't > restricted by quotas. This can happen for NFS file systems where root is > writing to an NFS

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Robert Watson
On Fri, 31 Mar 2006, Alfred Perlstein wrote: EDQUOT ? This won't normally happen for local file systems, as the root user isn't restricted by quotas. This can happen for NFS file systems where root is writing to an NFS log directory and the uid is mapped to a non-root uid on the server.

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Alfred Perlstein
* Christian S.J. Peron <[EMAIL PROTECTED]> [060330 13:05] wrote: > csjp2006-03-30 21:04:52 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/syslogd syslogd.c > Log: > Currently, if writing out a log entry fails, we unlink that log entry from > our > intern

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Christian S.J. Peron
Christian S.J. Peron wrote: Robert Watson wrote: On Fri, 31 Mar 2006, Christian S.J. Peron wrote: Although I agree this is a good idea, I think it would be more appropriate to place these kinds of checks in newsyslog(8) so that other programs logging can take advantage of this. The pro

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Christian S.J. Peron
Robert Watson wrote: On Fri, 31 Mar 2006, Christian S.J. Peron wrote: Although I agree this is a good idea, I think it would be more appropriate to place these kinds of checks in newsyslog(8) so that other programs logging can take advantage of this. The program generating the log message

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Robert Watson
On Fri, 31 Mar 2006, Christian S.J. Peron wrote: Although I agree this is a good idea, I think it would be more appropriate to place these kinds of checks in newsyslog(8) so that other programs logging can take advantage of this. The program generating the log message is presumably the one t

Re: Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Robert Watson
On Fri, 31 Mar 2006, Alexander Leidinger wrote: Do you know if a kqueue based solution is cheaper? Probably should not matter. Syslog writes data to disk synchronously, right? So anything not involving a disk access is negligible in cost compared to the main action of writing the log entry.

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Robert Watson
On Fri, 31 Mar 2006, Alexander Leidinger wrote: Robert Watson <[EMAIL PROTECTED]> wrote: The cost to check for free space is the cost of a fstatfs() system call on the file descriptor of the log file. This should be handled without touching the disk, so while it's not a cheap system call co

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Christian S.J. Peron
Robert Watson wrote: On Fri, 31 Mar 2006, Peter Jeremy wrote: On Thu, 2006-Mar-30 21:04:52 +, Christian S.J. Peron wrote: This change allows syslogd to ignore ENOSPC space errors, so that when the filesystem is cleaned up, syslogd will automatically start logging again without requi

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread David Malone
On Fri, Mar 31, 2006 at 10:32:13AM +, Robert Watson wrote: > The trick will be balancing flexibility with complexity for the > administrator. -s foopercent is easy for an administrator to understand, > and conditional logging of message types based on percentage is not. I can > imagine a us

Re: Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Alexander Leidinger
Sergey Babkin <[EMAIL PROTECTED]> wrote: Robert Watson <[EMAIL PROTECTED]> wrote: The cost to check for free space is the cost of a fstatfs() system call on the file descriptor of the log file. This should be handled without touching the disk, so while it's not a cheap system call compared

Re: Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Sergey Babkin
>Robert Watson <[EMAIL PROTECTED]> wrote: > >> The cost to check for free space is the cost of a fstatfs() system >> call on the file descriptor of the log file. This should be handled >> without touching the disk, so while it's not a cheap system call >> compared to, say, getpid(), as it acqu

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Alexander Leidinger
Robert Watson <[EMAIL PROTECTED]> wrote: The cost to check for free space is the cost of a fstatfs() system call on the file descriptor of the log file. This should be handled without touching the disk, so while it's not a cheap system call compared to, say, getpid(), as it acquires locks and

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Robert Watson
On Fri, 31 Mar 2006, Pawel Jakub Dawidek wrote: +> What I'd like to see is an argument to syslogd to specify a maximum full level for the target file system. Log data is valuable, but being able to write to +> /var/tmp/vi.recover is also important. syslogd -l 90% could specify that sylogd s

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Robert Watson
On Fri, 31 Mar 2006, Joao Barros wrote: My sole concern with this is that this means that syslogd will keep trying to write to the full filesystem - and the kernel will log the attempts to write to a full filesystem. Whilst there's rate limiting in the kernel, this sort of feedback loop is u

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Pawel Jakub Dawidek
On Fri, Mar 31, 2006 at 09:06:32AM +, Robert Watson wrote: +> +> On Fri, 31 Mar 2006, Peter Jeremy wrote: +> +> >On Thu, 2006-Mar-30 21:04:52 +, Christian S.J. Peron wrote: +> >> This change allows syslogd to ignore ENOSPC space errors, so that when the +> >> filesystem is cleaned up, sys

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Joao Barros
On 3/31/06, Robert Watson <[EMAIL PROTECTED]> wrote: > > On Fri, 31 Mar 2006, Peter Jeremy wrote: > > > On Thu, 2006-Mar-30 21:04:52 +, Christian S.J. Peron wrote: > >> This change allows syslogd to ignore ENOSPC space errors, so that when the > >> filesystem is cleaned up, syslogd will autom

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Robert Watson
On Fri, 31 Mar 2006, Peter Jeremy wrote: On Thu, 2006-Mar-30 21:04:52 +, Christian S.J. Peron wrote: This change allows syslogd to ignore ENOSPC space errors, so that when the filesystem is cleaned up, syslogd will automatically start logging again without requiring the reset. This make

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-31 Thread Peter Jeremy
On Thu, 2006-Mar-30 21:04:52 +, Christian S.J. Peron wrote: > This change allows syslogd to ignore ENOSPC space errors, so that when the > filesystem is cleaned up, syslogd will automatically start logging again > without requiring the reset. This makes syslogd(8) a bit more reliable. My so

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-30 Thread Garance A Drosehn
At 11:06 PM +0100 3/30/06, Joao Barros wrote: On 3/30/06, John-Mark Gurney <[EMAIL PROTECTED]> wrote: > I'd be cool if there was a log entry that logged the fact > that we couldn't write entries for a time due to no space > on the device, so that going back through the logs, you > could under

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-30 Thread Joao Barros
On 3/30/06, John-Mark Gurney <[EMAIL PROTECTED]> wrote: > I'd be cool if there was a log entry that logged the fact that we couldn't > write entries for a time due to no space on the device, so that going back > through the logs, you could understand why there was a big gap... > I like the idea ,

Re: cvs commit: src/usr.sbin/syslogd syslogd.c

2006-03-30 Thread John-Mark Gurney
Christian S.J. Peron wrote this message on Thu, Mar 30, 2006 at 21:04 +: > csjp2006-03-30 21:04:52 UTC > > FreeBSD src repository > > Modified files: > usr.sbin/syslogd syslogd.c > Log: > Currently, if writing out a log entry fails, we unlink that log entry from > ou