Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/d

2006-09-29 Thread Ruslan Ermilov
On Thu, Sep 28, 2006 at 02:20:53PM -0400, John Baldwin wrote: > On Thursday 28 September 2006 12:21, Ruslan Ermilov wrote: > > > Are there any others outside of SES? How many? If it's a small list, > > > then > > > let's fix them. The SES ones are broken as an API anyway as mentioned > > > ab

Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/d

2006-09-28 Thread John Baldwin
On Thursday 28 September 2006 12:21, Ruslan Ermilov wrote: > > Are there any others outside of SES? How many? If it's a small list, then > > let's fix them. The SES ones are broken as an API anyway as mentioned > > above, > > and if other ioctl's are copying out a variable amount of data w/o

Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/d

2006-09-28 Thread Ruslan Ermilov
On Thu, Sep 28, 2006 at 10:56:27AM -0400, John Baldwin wrote: > On Wednesday 27 September 2006 18:12, Ruslan Ermilov wrote: > > There are some _IO() ioctls that pass a pointer to variable sized data, > > and their ioctl handlers to uiocopy'ing rather than ioctl(). See > > sys/cam/scsi/scsi_ses.c,

Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/d

2006-09-28 Thread John Baldwin
On Wednesday 27 September 2006 18:12, Ruslan Ermilov wrote: > On Wed, Sep 27, 2006 at 05:52:56PM -0400, John Baldwin wrote: > > Could you avoid IOWINT by just assuming that any _IO() ioctl is getting an int > > as the arg? > > > There are some _IO() ioctls that pass a pointer to variable sized d

Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/d

2006-09-28 Thread Bruce Evans
On Wed, 27 Sep 2006, John Baldwin wrote: On Wednesday 27 September 2006 17:29, Ruslan Ermilov wrote: On Wed, Sep 27, 2006 at 05:10:51PM -0400, John Baldwin wrote: I still think doing this (via IOCPARM_IVAL()) is best and is probably a much smaller diff. You don't consider that many ioctls

Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/d

2006-09-27 Thread Ruslan Ermilov
On Wed, Sep 27, 2006 at 05:52:56PM -0400, John Baldwin wrote: > Could you avoid IOWINT by just assuming that any _IO() ioctl is getting an > int > as the arg? > There are some _IO() ioctls that pass a pointer to variable sized data, and their ioctl handlers to uiocopy'ing rather than ioctl(). S

Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/d

2006-09-27 Thread John Baldwin
On Wednesday 27 September 2006 17:29, Ruslan Ermilov wrote: > On Wed, Sep 27, 2006 at 05:10:51PM -0400, John Baldwin wrote: > > On Wednesday 27 September 2006 17:03, John Baldwin wrote: > > > Eh? You just changed ioctl values breaking ABI all over the place, e.g. > > > sys/pioctl.h. The size fie

Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/d

2006-09-27 Thread Ruslan Ermilov
On Wed, Sep 27, 2006 at 05:10:51PM -0400, John Baldwin wrote: > On Wednesday 27 September 2006 17:03, John Baldwin wrote: > > Eh? You just changed ioctl values breaking ABI all over the place, e.g. > > sys/pioctl.h. The size field changed from 0 to sizeof(int) meaning > > different ioctl values

Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/d

2006-09-27 Thread Ruslan Ermilov
Hi John, On Wed, Sep 27, 2006 at 05:03:42PM -0400, John Baldwin wrote: > On Wednesday 27 September 2006 15:57, Ruslan Ermilov wrote: > > ru 2006-09-27 19:57:02 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/atkbdc atkbd.c > > sys/dev/digi

Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/d

2006-09-27 Thread John Baldwin
On Wednesday 27 September 2006 17:03, John Baldwin wrote: > Eh? You just changed ioctl values breaking ABI all over the place, e.g. > sys/pioctl.h. The size field changed from 0 to sizeof(int) meaning > different ioctl values and thus ABI breakage. Bah, I see you did add compat hacks for the ol

Re: cvs commit: src/sys/dev/atkbdc atkbd.c src/sys/dev/digi digi.c src/sys/dev/kbdmux kbdmux.c src/sys/dev/syscons scvidctl.c syscons.c src/sys/dev/uart uart_kbd_sun.c src/sys/dev/usb ukbd.c src/sys/d

2006-09-27 Thread John Baldwin
On Wednesday 27 September 2006 15:57, Ruslan Ermilov wrote: > ru 2006-09-27 19:57:02 UTC > > FreeBSD src repository > > Modified files: > sys/dev/atkbdc atkbd.c > sys/dev/digi digi.c > sys/dev/kbdmux kbdmux.c > sys/dev/syscons scvidctl.c sy