Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-15 Thread Corinna Vinschen
On Jan 15 13:27, Jon Turney wrote: > On 15/01/2024 09:46, Corinna Vinschen wrote: > > On Jan 13 14:20, Jon Turney wrote: > > > On 12/01/2024 14:09, Jon Turney wrote: > > > > + > > > > + PWCHAR cp = dumper_command; > > > > + cp = wcpcpy (cp, L"\""); > > > > + cp = wcpcpy (cp, dll_dir); > > > > +

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-15 Thread Jon Turney
On 15/01/2024 09:46, Corinna Vinschen wrote: On Jan 13 14:20, Jon Turney wrote: On 12/01/2024 14:09, Jon Turney wrote: + + PWCHAR cp = dumper_command; + cp = wcpcpy (cp, L"\""); + cp = wcpcpy (cp, dll_dir); + cp = wcpcpy (cp, L"\\dumper.exe"); + cp = wcpcpy (cp, L"\" "); + cp = wcpcpy (cp

Re: [PATCH] Cygwin: introduce close_range

2024-01-15 Thread Corinna Vinschen
On Jan 15 13:41, Christian Franke wrote: > Corinna Vinschen wrote: > > On Jan 15 13:07, Corinna Vinschen wrote: > > > Sorry Christian, but.. > > > > > > I was just going to push this patch when I realized that we now have > > > two lines of debug output per affected file descriptor: > > > > > > O

Re: [PATCH] Cygwin: introduce close_range

2024-01-15 Thread Christian Franke
Corinna Vinschen wrote: On Jan 15 13:07, Corinna Vinschen wrote: Sorry Christian, but.. I was just going to push this patch when I realized that we now have two lines of debug output per affected file descriptor: On Jan 15 12:19, Christian Franke wrote: + for (unsigned int i = firstfd; i < s

Re: [PATCH] Cygwin: introduce close_range

2024-01-15 Thread Corinna Vinschen
On Jan 15 13:07, Corinna Vinschen wrote: > Sorry Christian, but.. > > I was just going to push this patch when I realized that we now have > two lines of debug output per affected file descriptor: > > On Jan 15 12:19, Christian Franke wrote: > > + for (unsigned int i = firstfd; i < size; i++) >

Re: [PATCH] Cygwin: introduce close_range

2024-01-15 Thread Corinna Vinschen
Sorry Christian, but.. I was just going to push this patch when I realized that we now have two lines of debug output per affected file descriptor: On Jan 15 12:19, Christian Franke wrote: > + for (unsigned int i = firstfd; i < size; i++) > +{ > + cygheap_fdget cfd ((int) i, false, fals

Re: [PATCH] Cygwin: introduce close_range

2024-01-15 Thread Christian Franke
Corinna Vinschen wrote: Hi Christian, On Jan 15 09:56, Christian Franke wrote: Christian Franke wrote: Jon Turney wrote: On 14/01/2024 16:07, Christian Franke wrote: Recently I learned about the existence and usefulness of close_range(): https://github.com/smartmontools/smartmontools/issues/

Re: [PATCH] Cygwin: introduce close_range

2024-01-15 Thread Corinna Vinschen
Hi Christian, On Jan 15 09:56, Christian Franke wrote: > Christian Franke wrote: > > Jon Turney wrote: > > > On 14/01/2024 16:07, Christian Franke wrote: > > > > Recently I learned about the existence and usefulness of close_range(): > > > > https://github.com/smartmontools/smartmontools/issues/23

Re: [PATCH] Cygwin: introduce close_range

2024-01-15 Thread Corinna Vinschen
On Jan 14 19:53, Christian Franke wrote: > Jon Turney wrote: > > On 14/01/2024 16:07, Christian Franke wrote: > > > Recently I learned about the existence and usefulness of close_range(): > > > https://github.com/smartmontools/smartmontools/issues/235 > > > > > > https://man.freebsd.org/cgi/man.cg

Re: [PATCH 1/5] Cygwin: Make 'ulimit -c' control writing a coredump

2024-01-15 Thread Corinna Vinschen
On Jan 13 14:20, Jon Turney wrote: > On 12/01/2024 14:09, Jon Turney wrote: > > + > > + PWCHAR cp = dumper_command; > > + cp = wcpcpy (cp, L"\""); > > + cp = wcpcpy (cp, dll_dir); > > + cp = wcpcpy (cp, L"\\dumper.exe"); > > + cp = wcpcpy (cp, L"\" "); > > + cp = wcpcpy (cp, L"\""); > > + cp

Re: [PATCH] Cygwin: introduce close_range

2024-01-15 Thread Christian Franke
Christian Franke wrote: Jon Turney wrote: On 14/01/2024 16:07, Christian Franke wrote: Recently I learned about the existence and usefulness of close_range(): https://github.com/smartmontools/smartmontools/issues/235 https://man.freebsd.org/cgi/man.cgi?query=close_range&sektion=2 https://man7.