On Mon, Nov 15, 2010 at 02:07:50PM -0500, Ben Gardiner wrote:
> diff --git a/drivers/input/keyboard/gpio_keys.c
> b/drivers/input/keyboard/gpio_keys.c
> index 6069abe..477802a 100644
> --- a/drivers/input/keyboard/gpio_keys.c
> +++ b/drivers/input/keyboard/gpio_keys.c
> @@ -44,6 +48,26 @@ struct g
Hi Victor,
On Fri, Nov 19, 2010 at 4:41 PM, Victor Rodriguez wrote:
[...]
>> ---
>
> I think that ther must be just one --- , This is extra
Sorry, that is my bad habit. I believe that the patch should still be
usable as-is.
Best Regards,
Ben Gardiner
---
Nanometrics Inc.
http://www.nanometri
There was a single case of 'da850evm' prefix in the board-da850-evm.c file
where the reset of the prefixes were 'da850_evm'; change it to 'da850_evm' for
consistency.
Signed-off-by: Ben Gardiner
---
@Sekhar, you asked me to prefix all the static symbols I added to
board-da850-evm.c with 'da850e
On Fri, Nov 19, 2010 at 3:37 PM, Ben Gardiner
wrote:
> The setup and teardown methods of the UI expander reference the SEL_{A,B,C}
> pins by 'magic number' in each function. This uses the common enum for their
> offsets
> in the expander setup and teardown functions.
>
> Signed-off-by: Ben Gardin
From: Alexander Clouter
This implements an optional polling mode for the gpio_keys driver,
necessary for GPIOs that are not able to generate IRQs.
gpio_keys_platform_data has been extended with poll_interval
which specifies the polling interval in ms, this is passed onto
input-polldev.
This wor
This patch adds a pca953x platform device for the tca6416 found on the evm
baseboard. The tca6416 is a GPIO expander, also found on the UI board at a
separate I2C address. The pins of the baseboard IO expander are connected to
software reset, deep sleep enable, test points, a push button, DIP switc
This patch adds EV_KEYs for each of the 8 pushbuttons on the UI board via a
gpio-key device.
The expander is a tca6416; it controls the SEL_{A,B,C} lines which enable and
disable the peripherals found on the UI board in addition to the 8 pushbuttons
mentioned above. The reason the existing tca6416
The da850-evm baseboard (BB) and its UI board both have tca6416 IO expanders.
They are bootstrapped to different I2C addresses so they can be used
concurrently.
The expander on the UI board is currently used to enable/disable the
peripherals that are available on the UI board. In addition to this
The setup and teardown methods of the UI expander reference the SEL_{A,B,C}
pins by 'magic number' in each function. This uses the common enum for their
offsets
in the expander setup and teardown functions.
Signed-off-by: Ben Gardiner
Reviewed-by: Chris Cordahi
Reviewed-by: Sekhar Nori
Signed-
On Tue, Nov 16, 2010 at 12:22 AM, Grant Likely
wrote:
> On Mon, Nov 15, 2010 at 02:12:06PM -0500, Cyril Chemparathy wrote:
>> This patch adds an SPI master implementation that operates on top of an
>> underlying TI-SSP port.
>>
>> Signed-off-by: Cyril Chemparathy
> [...]
>> +static int __init ti_
On Fri, 12 Nov 2010, Hadli, Manjunath wrote:
> On Thu, Nov 11, 2010 at 22:17:23, Laurent Pinchart wrote:
> > Hi Guennadi,
> >
> > On Thursday 11 November 2010 16:32:02 Guennadi Liakhovetski wrote:
> > > On Wed, 10 Nov 2010, Hadli, Manjunath wrote:
> > > > Hello Guennadi,
> > > >
> > > >Your
On Wed, 10 Nov 2010, Hadli, Manjunath wrote:
> Hello Guennadi,
>Your media-bus enumerations capture the formats quite well. I needed
> the following for support on Davinci SOCs and liked to check with you if
> these are covered in some format in the list.
> 1. Parallel RGB 666 (18 data lines
The tnetv107x evm board has a backlight device that is connected on one of the
SSP ports. This patch adds the board definitions necessary to plug the
backlight driver to the GPIO corresponding to this SSP pin.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-tnetv107x-evm.c |
Hi Dmitry,
On Fri, Nov 19, 2010 at 12:02 PM, Dmitry Torokhov
wrote:
> Another question is why do you want to poll the same device at
> different intervals? The processor is already woken up so it makes sense
> to do as much as possible instead of going to sleep. In your case
> 200/700 for every 1
Hello.
Cyril Chemparathy wrote:
The tnetv107x evm board has a backlight device that is connected on one of the
SSP ports. This patch adds the board definitions necessary to plug the
backlight driver to the GPIO corresponding to this SSP pin.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach
On 11/19/2010 11:25 AM, Sergei Shtylyov wrote:
[...]
>> +ret = gpio_request(EVM_SPI_CS_GPIO, "spi chipsel");
>
> Why not just:
>
> int ret = gpio_request(EVM_SPI_CS_GPIO, "spi chipsel");
>
> Also, and empty line after declaration wouldn't hurt.
>
[...]
>> +
On 11/19/2010 11:44 AM, Sergei Shtylyov wrote:
> Hello.
>
> Cyril Chemparathy wrote:
>
>> The tnetv107x evm board has a backlight device that is connected on one of
>> the
>> SSP ports. This patch adds the board definitions necessary to plug the
>> backlight driver to the GPIO corresponding to
Hi Ben,
On Fri, Nov 19, 2010 at 10:40:50AM -0500, Ben Gardiner wrote:
>
> >> +
> >> +static struct gpio_keys_platform_data user_sw_gpio_key_platform_data = {
> >> + .buttons = user_sw_gpio_keys,
> >> + .nbuttons = ARRAY_SIZE(user_sw_gpio_keys),
> >> + .rep = 0, /* disable auto-repeat
Hello.
Cyril Chemparathy wrote:
The tnetv107x evm board has a backlight device that is connected on one of the
SSP ports. This patch adds the board definitions necessary to plug the
backlight driver to the GPIO corresponding to this SSP pin.
Signed-off-by: Cyril Chemparathy
---
arch/arm/m
Hello Victor,
On 11/19/2010 11:22 AM, vm.ro...@gmail.com wrote:
> From: Victor Rodriguez
>
> Generic pin list has RTS and CTS pins defined
> for UART1 and UART2.
>
> Signed-off-by: Victor Rodriguez
> ---
I don't think this patch is complete, it will break the current boards with out
some ot
Hello.
Cyril Chemparathy wrote:
This patch adds definitions for spi devices on the tnetv107x evm platform.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-tnetv107x-evm.c | 43 +++
1 files changed, 43 insertions(+), 0 deletions(-)
diff --git a/
On Thu, Nov 18, 2010 at 6:17 PM, Victor Rodriguez wrote:
> On Thu, Nov 18, 2010 at 5:57 PM, Kevin Hilman
> wrote:
>> "Nori, Sekhar" writes:
>>
>>> Hi Michael,
>>>
>>> On Wed, Nov 17, 2010 at 02:12:53, Michael Williamson wrote:
Help me out. Why do we need generic pin lists?
>>>
>>
From: Victor Rodriguez
Generic pin list has RTS and CTS pins defined
for UART1 and UART2.
Signed-off-by: Victor Rodriguez
---
arch/arm/mach-davinci/da850.c |8 ++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-davinci/da850.c b/arch/arm/mach-davinci/da85
Ensure that the at24 eeprom driver is selected for certain boards that
need boot data (e.g. MAC address) from EEPROM.
Signed-off-by: Kevin Hilman
---
arch/arm/mach-davinci/Kconfig | 12
1 files changed, 12 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-davinci/Kconfig b
TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port
device. It has a built-in programmable execution engine that can be programmed
to operate as almost any serial bus (I2C, SPI, EasyScale, and others).
This patch adds a driver for this controller device. The driver do
The tnetv107x evm board has a backlight device that is connected on one of the
SSP ports. This patch adds the board definitions necessary to plug the
backlight driver to the GPIO corresponding to this SSP pin.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-tnetv107x-evm.c |
This patch adds regulator and spi board info definitions for the tps6524x
power management IC found on tnetv107x evm boards.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-tnetv107x-evm.c | 85 +++
1 files changed, 85 insertions(+), 0 deletions(-)
dif
The tnetv107x evm board has an I2C device connected on one of the SSP ports.
This patch adds board definitions for a GPIO based I2C master, as well as
definitions for the eeprom device on these boards.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-tnetv107x-evm.c | 30 ++
This patch adds definitions for spi devices on the tnetv107x evm platform.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-tnetv107x-evm.c | 43 +++
1 files changed, 43 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-davinci/board-tnetv107x-ev
TPS6116x is an EasyScale backlight controller device. This driver supports
TPS6116x devices connected on a single GPIO.
Signed-off-by: Cyril Chemparathy
---
drivers/video/backlight/Kconfig|7 +
drivers/video/backlight/Makefile |2 +-
drivers/video/backlight/tps6116x.c | 298 +
This patch adds an SPI master implementation that operates on top of an
underlying TI-SSP port.
Signed-off-by: Cyril Chemparathy
---
drivers/spi/Kconfig| 10 +
drivers/spi/Makefile |1 +
drivers/spi/ti-ssp-spi.c | 402
include/l
This patch adds definitions to hook up one of the ti-ssp ports to the SSP GPIO
driver.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-tnetv107x-evm.c | 11 +++
1 files changed, 11 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-davinci/board-tnetv107x-evm.c
TI's SSP controller pins can be directly read and written to behave like a
GPIO. This patch adds a GPIO driver that exposes such functionality.
Signed-off-by: Cyril Chemparathy
---
drivers/gpio/Kconfig | 10 ++
drivers/gpio/Makefile |1 +
drivers/gpio/ti-ssp-gpio.c | 206 +
TPS6524X provides three step-down converters and two general-purpose LDO
voltage regulators. This device is interfaced using SPI.
Acked-by: Mark Brown
Signed-off-by: Cyril Chemparathy
---
drivers/regulator/Kconfig | 10 +
drivers/regulator/Makefile |1 +
drivers/
TI's sequencer serial port (TI-SSP) is a jack-of-all-trades type of serial port
device. It has a built-in programmable execution engine that can be programmed
to operate as almost any serial bus (I2C, SPI, EasyScale, and others).
This patch series implements a driver stack that looks like the fol
This patch adds an SSP platform device definition for the tnetv107x soc family.
The clock lookup entry has also been updated to match.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/devices-tnetv107x.c | 25
arch/arm/mach-davinci/include/mach/tnetv107x
This patch adds SSP configuration and pin muxing info for tnetv107x
evm boards.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-tnetv107x-evm.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-davinci/board-tnetv107x-evm.c
b/a
Hi Sehkar,
On Fri, Nov 19, 2010 at 7:14 AM, Nori, Sekhar wrote:
> The board patches look good to me overall. Some minor comments below:
Thanks -- and I appreciate your input.
> On Wed, Nov 17, 2010 at 01:09:37, Ben Gardiner wrote:
>> [...]
>> +static const char const *baseboard_expander_names[]
Hi Sehkar,
On Fri, Nov 19, 2010 at 6:19 AM, Nori, Sekhar wrote:
> [...]
> In this case, I think in this case indexed array initialization
> will help keep the offsets and names matched. Here is an untested
> patch on your patch, please consider using it.
I love it. I'll post a re-spin with this
Hi Sekhar,
Thank you for your reviews.
On Fri, Nov 19, 2010 at 4:58 AM, Nori, Sekhar wrote:
> [...]
> On Wed, Nov 17, 2010 at 01:09:35, Ben Gardiner wrote:
>> [...]
>> Changes since v1:
>> * set INPUT_POLLDEV default for DA850_EVM machine, but don't select it
>> unconditionally
>
> I didn't
Ben Gardiner writes:
> Change the mach-davinci Kconfig file so that GPIO_PCA953X is default when
> MACH_DAVINCI_DA850_EVM is set instead of always selecting. This allows users
> to compile pca953x as a module.
>
> Signed-off-by: Ben Gardiner
> CC: Sergei Shtylyov
> CC: Nori, Sekhar
> Reviewed-
Change the mach-davinci Kconfig file so that GPIO_PCA953X is default when
MACH_DAVINCI_DA850_EVM is set instead of always selecting. This allows users
to compile pca953x as a module.
Signed-off-by: Ben Gardiner
CC: Sergei Shtylyov
CC: Nori, Sekhar
Reviewed-by: Kevin Hilman
---
Changes since
Hi Nathan,
On Wed, Nov 17, 2010 at 22:10:46, Nathan Neitzke wrote:
> There is a known issue with the latest TI release for the DM355
> linux-davinci-staging kernel regarding un-mounting a partition on an SD
> card after the SD card has been removed from the system. Since our
> embedded system rel
On Mon, Nov 15, 2010 at 02:12:06PM -0500, Cyril Chemparathy wrote:
> This patch adds an SPI master implementation that operates on top of an
> underlying TI-SSP port.
>
> Signed-off-by: Cyril Chemparathy
[...]
> +static int __init ti_ssp_spi_init(void)
> +{
> + return platform_driver_register
Hi Ben,
The board patches look good to me overall. Some minor comments below:
On Wed, Nov 17, 2010 at 01:09:37, Ben Gardiner wrote:
> This patch adds a pca953x platform device for the tca6416 found on the evm
> baseboard. The tca6416 is a GPIO expander, also found on the UI board at a
> separate
Hello.
On 19-11-2010 12:54, Savinay Dharmappa wrote:
From: Aleksey Makarov
Adds platform support for OMAP-L137/AM17x NOR flash driver.
Also, configures chip select 3 to control NOR flash's upper
address lines.
Signed-off-by: Aleksey Makarov
Signed-off-by: Sergei Shtylyov
Signed-off-
Hi Ben,
On Wed, Nov 17, 2010 at 01:09:36, Ben Gardiner wrote:
> The setup and teardown methods of the UI expander reference the SEL_{A,B,C}
> pins by 'magic number' in each function. This patch extracts common #defines
> for their offsets in the expander and uses them.
>
> Signed-off-by: Ben Gardi
From: Aleksey Makarov
Adds platform support for OMAP-L137/AM17x NOR flash driver.
Also, configures chip select 3 to control NOR flash's upper
address lines.
Signed-off-by: Aleksey Makarov
Signed-off-by: Sergei Shtylyov
Signed-off-by: Savinay Dharmappa
---
Since v2:
a. Added signoff from Serg
From: David Griego
OMAP-L137/AM17x has limited number of dedicated EMIFA
address pins, enough to interface directly to an SDRAM.
If a device such as an asynchronous flash needs to be
attached to the EMIFA, then either GPIO pins or a chip
select may be used to control the flash device's upper
addr
Hi Ben,
Thanks for the patches. Some comments/questions below:
On Wed, Nov 17, 2010 at 01:09:35, Ben Gardiner wrote:
> This patch adds EV_KEYs for each of the 8 pushbuttons on the UI board via a
> gpio-key device.
>
> The expander is a tca6416; it controls the SEL_{A,B,C} lines which enable and
>
This patch adds SSP configuration and pin muxing info for tnetv107x
evm boards.
Signed-off-by: Cyril Chemparathy
---
arch/arm/mach-davinci/board-tnetv107x-evm.c | 14 ++
1 files changed, 14 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-davinci/board-tnetv107x-evm.c
b/a
Hans,
Thank you for the review comments. I will include a section
on customizing for additions and changes to different boards.
Thanks again,
-Manju
On Sat, Nov 13, 2010 at 18:22:19, Hans Verkuil wrote:
> Hi Manju,
>
> I've reviewed the other patches as well. The only one for which I had
> co
52 matches
Mail list logo
