Bug#1089276: win32-loader: FTBFS with make 4.4.1

2025-04-12 Thread Cyril Brulebois 
Holger Wansing  (2025-04-12):
> It has already been removed from the d-i builds 2 years ago with
> 

That'd be the *images* builds.

It's still listed and used in src:debian-installer builds, see
debian/control and build/config/x86.cfg at the very least (this isn't
any kind of extensive research).


Cheers,
-- 
Cyril Brulebois ([email protected])
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#1089276: win32-loader: FTBFS with make 4.4.1

2025-04-12 Thread Holger Wansing 
Hi,

Am 12. April 2025 13:17:30 MESZ schrieb Paul Gevers :
>Hi,
>
>On 12-04-2025 12:54, Cyril Brulebois wrote:
>> Paul Gevers  (2025-04-12):
>>> Do you speak on behalf of all maintainers here? Do you want me to find
>>> out what needs to be done to remove win32-loader from trixie?
>> 
>> I'm not aware of anyone wanting to keep win32-loader around, so yeah,
>> looking into its removal would make sense to me.
>
>
>To be fair, I was mostly thinking about it's special status in our archive, 
>but I just realized (and checked) it's also part of how d-i is built. I assume 
>now you mean here that I should also look into the d-i parts and provide an 
>MR. I can try of course, but I'm happy to leave it to you if you say, nah, 
>that's trivial.

It has already been removed from the d-i builds 2 years ago with



Holger



-- 
Sent from /e/ OS on Fairphone3

Bug#1089276: win32-loader: FTBFS with make 4.4.1

2025-04-12 Thread Cyril Brulebois 
Paul Gevers  (2025-04-12):
> On 12-04-2025 12:54, Cyril Brulebois wrote:
> > I'm not aware of anyone wanting to keep win32-loader around, so
> > yeah, looking into its removal would make sense to me.
> 
> 
> To be fair, I was mostly thinking about it's special status in our
> archive, but I just realized (and checked) it's also part of how d-i
> is built. I assume now you mean here that I should also look into the
> d-i parts and provide an MR.

No, I mean whoever wants to have it removed should feel free to look
into what's needed for that to happen. I didn't ask you to, and I did
not volunteer either.


Cheers,
-- 
Cyril Brulebois ([email protected])
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#1089276: win32-loader: FTBFS with make 4.4.1

2025-04-12 Thread Paul Gevers 

Hi Holger,

On 12-04-2025 13:31, Holger Wansing wrote:

It has already been removed from the d-i builds 2 years ago with




And what about e.g. 
https://salsa.debian.org/installer-team/debian-installer/-/blob/master/debian/control?ref_type=heads#L155 
and 
https://salsa.debian.org/installer-team/debian-installer/-/blob/master/build/config/x86.cfg?ref_type=heads#L124


Paul



OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089276: win32-loader: FTBFS with make 4.4.1

2025-04-12 Thread Paul Gevers 

Hi,

On 12-04-2025 12:54, Cyril Brulebois wrote:

Paul Gevers  (2025-04-12):

Do you speak on behalf of all maintainers here? Do you want me to find
out what needs to be done to remove win32-loader from trixie?


I'm not aware of anyone wanting to keep win32-loader around, so yeah,
looking into its removal would make sense to me.



To be fair, I was mostly thinking about it's special status in our 
archive, but I just realized (and checked) it's also part of how d-i is 
built. I assume now you mean here that I should also look into the d-i 
parts and provide an MR. I can try of course, but I'm happy to leave it 
to you if you say, nah, that's trivial.


Sorry for the confusion.

Paul



OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089276: win32-loader: FTBFS with make 4.4.1

2025-04-12 Thread Cyril Brulebois 
Hi,

Paul Gevers  (2025-04-12):
> Do you speak on behalf of all maintainers here? Do you want me to find
> out what needs to be done to remove win32-loader from trixie?

I'm not aware of anyone wanting to keep win32-loader around, so yeah,
looking into its removal would make sense to me.


Cheers,
-- 
Cyril Brulebois ([email protected])
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#1089276: win32-loader: FTBFS with make 4.4.1

2025-04-12 Thread Holger Wansing 
Hi Paul,

Am 12. April 2025 12:20:23 MESZ schrieb Paul Gevers :
>Hi,
>
>On 27-03-2025 19:57, Holger Wansing wrote:
>> Am 27. März 2025 15:25:09 MEZ schrieb Paul Gevers :
>>> I've seen multiple times that win32-loader was mentioned during a stable 
>>> point release IRC discussion and I am under the impression that "we" want 
>>> to remove it at some point. I'm wondering if now might be that moment.
>> 
>> Yes, please.
>
>
>Do you speak on behalf of all maintainers here? 

Maybe not in the first place, but this bug is public for the installer-team, 
and as long
as noone objects within a reasonable time frame, we can assume consens, I guess
(and I tend to that this will happen).

> Do you want me to find out what needs to be done to remove win32-loader from 
> trixie?

Yes, that would be great. Thanks


Holger




-- 
Sent from /e/ OS on Fairphone3

Bug#1089276: win32-loader: FTBFS with make 4.4.1

2025-04-12 Thread Paul Gevers 

Hi,

On 27-03-2025 19:57, Holger Wansing wrote:

Am 27. März 2025 15:25:09 MEZ schrieb Paul Gevers :

I've seen multiple times that win32-loader was mentioned during a stable point release 
IRC discussion and I am under the impression that "we" want to remove it at 
some point. I'm wondering if now might be that moment.


Yes, please.



Do you speak on behalf of all maintainers here? Do you want me to find 
out what needs to be done to remove win32-loader from trixie?


Paul


OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089276: win32-loader: FTBFS with make 4.4.1

2025-03-27 Thread Holger Wansing 
Hi,

Am 27. März 2025 15:25:09 MEZ schrieb Paul Gevers :
>Hi all,
>
>I admit I'm not fully aware of how win32-loader is a special case in the 
>Debian archive, but given this current bug I thought to mention the following.
>
>I've seen multiple times that win32-loader was mentioned during a stable point 
>release IRC discussion and I am under the impression that "we" want to remove 
>it at some point. I'm wondering if now might be that moment.

Yes, please.


Holger



-- 
Sent from /e/ OS on Fairphone3

Bug#1089276: win32-loader: FTBFS with make 4.4.1

2025-03-27 Thread Paul Gevers 

Hi all,

I admit I'm not fully aware of how win32-loader is a special case in the 
Debian archive, but given this current bug I thought to mention the 
following.


I've seen multiple times that win32-loader was mentioned during a stable 
point release IRC discussion and I am under the impression that "we" 
want to remove it at some point. I'm wondering if now might be that moment.


Paul


OpenPGP_signature.asc
Description: OpenPGP digital signature

Bug#1089276: win32-loader: FTBFS with make 4.4.1

2024-12-07 Thread Stephen Kitt 
On Sat, 7 Dec 2024 19:09:25 +0100, Santiago Vila  wrote:
> This package fails to build from source with Make 4.4.1, most likely
> because of changes in $(shell) environment handling: environment variables
> exported from Makefiles are now made available to commands invoked using
> $(shell), which can cause issues with recursive definitions in particular.
> See https://salsa.debian.org/debian/make/-/blob/master/debian/NEWS for a
> complete list of backward-incompatible changes since Make 4.3.

This appears to be fixed with the forthcoming 0.10.7; I’ve rebuilt the
latest commit in the repository and it built fine.

Regards,

Stephen


pgpXp5EGyTBFu.pgp
Description: OpenPGP digital signature

Bug#1089276: win32-loader: FTBFS with make 4.4.1

2024-12-07 Thread Santiago Vila 

Package: src:win32-loader
Version: 0.10.6
User: [email protected]
Usertags: make-4.4
Severity: important
Tags: ftbfs

Dear Maintainer,

This package fails to build from source with Make 4.4.1, most likely because of
changes in $(shell) environment handling: environment variables exported from
Makefiles are now made available to commands invoked using $(shell), which
can cause issues with recursive definitions in particular. See
https://salsa.debian.org/debian/make/-/blob/master/debian/NEWS for a complete
list of backward-incompatible changes since Make 4.3.

Below you will find how the builds end, hopefully the most relevant
part from the build log. A full build log is available here:

https://people.debian.org/~sanvila/make-4.4/build-logs/

Make 4.4.1 is currently available in experimental and will hopefully
soon be uploaded to unstable, at which time this bug will become
release-critical.

About the archive rebuild: The build was made on virtual machines from AWS,
using sbuild and a reduced chroot with only build-essential packages.

If you could not reproduce the bug please contact me privately, as I
am willing to provide ssh access to a virtual machine where the bug is
fully reproducible.

If this is really a bug in one of the build-depends, please use
reassign and affects, so that this is still visible in the BTS web
page for this package.

Please reach out to the Make maintainer, Stephen Kitt  if
you need help fixing this.


dh_auto_build -- OUTFILE_NAME="build/win32-loader.exe" \
BUILD_DIR="build"
make -j2 "INSTALL=install --strip-program=true" 
OUTFILE_NAME=build/win32-loader.exe BUILD_DIR=build
make[2]: Entering directory '/<>'
bash genpif > build/loadlin.pif
gunzip -c /usr/lib/loadlin/loadlin.exe.gz > build/loadlin.exe
cat /usr/lib/grub/i386-pc/g2hdr.bin core.img > build/g2ldr
cp /usr/lib/grub/i386-pc/g2ldr.mbr build/g2ldr.mbr
mkdir -p build/helpers/cpuid
make -C build/helpers/cpuid -f "/<>/helpers/cpuid/Makefile" 
"VPATH=/<>/helpers/cpuid"
make[3]: Entering directory '/<>/build/helpers/cpuid'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/<>/build/helpers/cpuid'
mkdir -p build/helpers/instdlg
make -C build/helpers/instdlg -f "/<>/helpers/instdlg/Makefile" 
"VPATH=/<>/helpers/instdlg"
make[3]: Entering directory '/<>/build/helpers/instdlg'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/<>/build/helpers/instdlg'
mkdir -p build/helpers/miniz
make -C build/helpers/miniz -f "/<>/helpers/miniz/Makefile" 
"VPATH=/<>/helpers/miniz"
make[3]: Entering directory '/<>/build/helpers/miniz'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/<>/build/helpers/miniz'
mkdir -p build/helpers/sha256
make -C build/helpers/sha256 -f "/<>/helpers/sha256/Makefile" 
"VPATH=/<>/helpers/sha256"
make[3]: Entering directory '/<>/build/helpers/sha256'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/<>/build/helpers/sha256'
find build -type f -exec touch --date="@1647903482" '{}' ';'
mkdir -p build/l10n
make -C build/l10n -f /<>/l10n/Makefile VPATH=/<>/l10n
make[3]: Entering directory '/<>/build/l10n'
make[3]: Nothing to be done for 'all'.
make[3]: Leaving directory '/<>/build/l10n'
makensis -V3 "-XUnicode True" -DVERSION=0.10.6 -D4DIGITS_DATE=2022.03.21.2258 
-D_OUTFILE_NAME=build/win32-loader.exe -DBUILD_DIR=build -DALLKERNELS=yes 
-DOPTIONS_TXT="+kernels" main.nsi
MakeNSIS v3.10-2 - Copyright 1999-2023 Contributors
See the file COPYING for license details.
Credits can be found in the Users Manual.

Command line defined: "VERSION=0.10.6"
Command line defined: "4DIGITS_DATE=2022.03.21.2258"
Command line defined: "_OUTFILE_NAME=build/win32-loader.exe"
Command line defined: "BUILD_DIR=build"
Command line defined: "ALLKERNELS=yes"
Command line defined: "OPTIONS_TXT=+kernels"
Processing config: /etc/nsisconf.nsh
Processing script file: "main.nsi" (UTF8)

Processed 1 file, 1 command line command, writing output (x86-unicode):

Output: "build/win32-loader.exe"
Install: 6 pages (384 bytes), 12 sections (49440 bytes), 4825 instructions 
(135100 bytes), 3627 strings (346596 bytes), 44 language tables (16280 bytes).
Uninstall: 2 pages (192 bytes), 1 section (4120 bytes), 971 instructions (27188 
bytes), 1984 strings (101234 bytes), 44 language tables (11352 bytes).
Datablock optimizer saved 19976 bytes (~4.3%).

Using lzma (compress whole) compression.

EXE header size:  154112 / 100864 bytes
Install code:  (523688 bytes)
Install data:  (195768 bytes)
Uninstall code+data:   (215674 bytes)
Compressed data:  209489 / 935130 bytes
CRC (0xA0BFB5AD):  4 / 4 bytes

Total size:   363605 / 1035998 bytes (35.0%)
du -h build/win32-loader.exe
356Kbuild/win32-loader.exe
make[2]: Leaving directory '/<>'
make[1]: Leaving directory '/<>'
   dh_au