Bug#1091806: RFS: ydotool/1.0.4-1 [ITA] -- Generic Linux command-line automation tool

2025-07-19 Thread Maytham Alsudany
Hi Andre,

On Sat, 2025-07-19 at 10:01 +, Andre Paiusco wrote:
> I've actually sent an email on Jun 4, answering all your requests
> @Maytham. Sadly, I've just realized now that it never got anywhere. I
> have no idea why.

That happens sometimes :)

> Will copy it here:
> 
> > Hello @Maytham
> > I finally finished the changes you requested, plus some extra needed for 
> > the package to run correctly. (Thanks to Phil as well)
> > 
> > The forked repo is available[1]
> > 
> > The new changelog is:
> >   * Change of maintainers (Closes: #1086596).
> >   * New upstream release (Closes: #1053561).
> >   * Move license from MIT to AGPL-3.0
> >   * Update Standard version and Compat version
> >   * Merge daemon (ydotoold) into ydotool package
> >   * Add udev rule needed for user service daemon
> >   * Add DEP12 metadata
> > 
> > BR,
> > 
> > [1]: https://salsa.debian.org/paiusco/ydotool
> 
> I intend to fix the changelog request soon. Will tag @Maytham on the MR as 
> soon as I finish it. 

Don't worry about creating an MR. As soon as your changes are up to
scratch, they can be pushed directly to the Debian/ydotool repo. Just
send a mail once you are ready.

Could you please use import the new upstream version using git-
buildpackage and rebase your commits on that? See:
https://honk.sigxcpu.org/projects/git-buildpackage/manual-html/gbp.intro.html
https://honk.sigxcpu.org/projects/git-buildpackage/manual-html/gbp.import.new.upstream.html
You can look at the history of the repo for what it should look like.

Additionally, the name and email address in Uploaders needs a space in
between i.e. "Maytham Alsudany "

Thanks,
Maytham



signature.asc
Description: This is a digitally signed message part


Bug#1091806: RFS: ydotool/1.0.4-1 [ITA] -- Generic Linux command-line automation tool

2025-07-19 Thread Andre Paiusco
Hi,

I've actually sent an email on Jun 4, answering all your requests @Maytham. 
Sadly, I've just realized now that it never got anywhere. I have no idea why.

Will copy it here:

> Hello @Maytham
> I finally finished the changes you requested, plus some extra needed for the 
> package to run correctly. (Thanks to Phil as well)
>
> The forked repo is available[1]
>
> The new changelog is:
>   * Change of maintainers (Closes: #1086596).
>   * New upstream release (Closes: #1053561).
>   * Move license from MIT to AGPL-3.0
>   * Update Standard version and Compat version
>   * Merge daemon (ydotoold) into ydotool package
>   * Add udev rule needed for user service daemon
>   * Add DEP12 metadata
>
> BR,
>
> [1]: https://salsa.debian.org/paiusco/ydotool

I intend to fix the changelog request soon. Will tag @Maytham on the MR as soon 
as I finish it. 

> @Andre Paiusco: I have granted you developer access to 
> https://salsa.debian.org/debian/ydotool, so you should be able to push 
> there directly. Once you fix up the copyright file, please feel free to
> merge your changes into the that repo.

Thank you @Niels


BR,



Bug#1091806: RFS: ydotool/1.0.4-1 [ITA] -- Generic Linux command-line automation tool

2025-07-19 Thread Niels Thykier

Control: tags -1 moreinfo

Maytham Alsudany:

On Sat, 2025-07-19 at 08:29 +0200, Niels Thykier wrote:

@Maytham: Since you are a DD and have shown interest in this
package/RFS, will you take the upload/this RFS from here? If so, then
please set yourself as owner or close the bug and align bilaterally with
Andre from here on.


I would but there has been no response from Andre since the RFS was
first opened, and feedback has not been applied.

--
Maytham


Ok, sounds reasonable. Tagging this as moreinfo until Andre responds then.

Thanks for the feedback.

Best regards,
Niels



OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1091806: RFS: ydotool/1.0.4-1 [ITA] -- Generic Linux command-line automation tool

2025-07-19 Thread Maytham Alsudany
On Sat, 2025-07-19 at 08:29 +0200, Niels Thykier wrote:
> @Maytham: Since you are a DD and have shown interest in this 
> package/RFS, will you take the upload/this RFS from here? If so, then 
> please set yourself as owner or close the bug and align bilaterally with 
> Andre from here on.

I would but there has been no response from Andre since the RFS was
first opened, and feedback has not been applied.

--
Maytham


signature.asc
Description: This is a digitally signed message part


Bug#1091806: RFS: ydotool/1.0.4-1 [ITA] -- Generic Linux command-line automation tool

2025-07-18 Thread Niels Thykier

Control: tags -1 moreinfo

On Thu, 10 Jul 2025 09:23:43 +0200 Salvo Tomaselli  
wrote:
I see that you replaced completely the previous maintainer's name in the 
copyright file.


That seems wrong.

Also for now updates should target experimental.

[...]


Tagging moreinfo based on this feedback and that I do not see a follow 
up to it.


@Andre Paiusco: I have granted you developer access to 
https://salsa.debian.org/debian/ydotool, so you should be able to push 
there directly. Once you fix up the copyright file, please feel free to 
merge your changes into the that repo.


@Maytham: Since you are a DD and have shown interest in this 
package/RFS, will you take the upload/this RFS from here? If so, then 
please set yourself as owner or close the bug and align bilaterally with 
Andre from here on.




Best regards,
Niels



OpenPGP_signature.asc
Description: OpenPGP digital signature


Bug#1091806: RFS: ydotool/1.0.4-1 [ITA] -- Generic Linux command-line automation tool

2025-06-04 Thread Debian Paiusco
Hello Maytham,

On Sunday, March 2nd, 2025 at 06:44, Maytham Alsudany  
wrote:

> Could you please fork the existing Salsa repo[1] and push your changes
> to git?
> 
> I've got a few points about the packaging:
> - One package rather than two (which has already been mentioned).
> - debian/upstream/metadata from DEP12[2] would be nice to have.
> - Consider adding yourself to d/copyright.
> - Bump Standards-Version to the recently-release 4.7.2.
> - The package doesn't need to build-depend on both debhelper and
> debhelper-compat. Build-Depends: debhelper should be dropped.
> 
> Additionally, could you please add me as an Uploader?

I finally finished the changes you requested, plus some extra needed for the 
package to run correctly. (Thanks to Phil as well)

The forked repo is available[1]

The new changelog is:
  * Change of maintainers (Closes: #1086596).
  * New upstream release (Closes: #1053561).
  * Move license from MIT to AGPL-3.0
  * Update Standard version and Compat version
  * Merge daemon (ydotoold) into ydotool package
  * Add udev rule needed for user service daemon
  * Add DEP12 metadata

BR,

[1]: https://salsa.debian.org/paiusco/ydotool



Bug#1091806: RFS: ydotool/1.0.4-1 [ITA] -- Generic Linux command-line automation tool

2025-03-01 Thread Maytham Alsudany
Hi Andre,

On Tue, 2024-12-31 at 18:44 +0100, Andre Paiusco wrote:
>  ydotool (1.0.4-1) unstable; urgency=medium
>  .
>* Change of maintainers (Closes: #1086596).
>* New upstream release (Closes: #1053561).
>* Move license from MIT to AGPL-3.0
>* Update Standard version and Compat version

Could you please fork the existing Salsa repo[1] and push your changes
to git?

I've got a few points about the packaging:
- One package rather than two (which has already been mentioned).
- debian/upstream/metadata from DEP12[2] would be nice to have.
- Consider adding yourself to d/copyright.
- Bump Standards-Version to the recently-release 4.7.2.
- The package doesn't need to build-depend on both debhelper and
debhelper-compat. Build-Depends: debhelper should be dropped.

Additionally, could you please add me as an Uploader?

-- 
Maytham

[1]: https://salsa.debian.org/debian/ydotool
[2]: https://dep-team.pages.debian.net/deps/dep12/


signature.asc
Description: This is a digitally signed message part


Bug#1091806: RFS: ydotool/1.0.4-1 [ITA] -- Generic Linux command-line automation tool

2025-02-24 Thread Debian Paiusco
I completely missed that. Thank you for pointing it out and for your time!

Took me a while to realize that now they're just one pkg, that the dh_install 
are not needed any more. CMake is already installing it all

I found an issue while trying to start the user service (needs an udev rule to 
be shipped with it)

It's taking longer than expected... I'm enjoying my newborn at home :)

BR,

On Monday, January 13th, 2025 at 17:54, Salvo Tomaselli  
wrote:

> Nice tool!
> 
> I'd just create a single package though, since they are both architecture any
> and must both be installed. I don't think there's any advantage in keeping
> them split.
> 
> That's normally done when there's some architecture independent data to save
> space, or when some component might not be installed.
> 
> Also you forgot to make them dependent so one should read the documentation
> and install both or it won't even work. I think it's much easier to just have
> 1 package.
> 
> --
> Salvo Tomaselli
> 
> "Io non mi sento obbligato a credere che lo stesso Dio che ci ha dotato di
> senso, ragione ed intelletto intendesse che noi ne facessimo a meno."
> -- Galileo Galilei
> 
> https://ltworf.codeberg.page/



Bug#1091806: RFS: ydotool/1.0.4-1 [ITA] -- Generic Linux command-line automation tool

2025-01-13 Thread Salvo Tomaselli
Nice tool!

I'd just create a single package though, since they are both architecture any 
and must both be installed. I don't think there's any advantage in keeping 
them split.

That's normally done when there's some architecture independent data to save 
space, or when some component might not be installed.

Also you forgot to make them dependent so one should read the documentation 
and install both or it won't even work. I think it's much easier to just have 
1 package.

-- 
Salvo Tomaselli

"Io non mi sento obbligato a credere che lo stesso Dio che ci ha dotato di
senso, ragione ed intelletto intendesse che noi ne facessimo a meno."
-- Galileo Galilei

https://ltworf.codeberg.page/

signature.asc
Description: This is a digitally signed message part.


Bug#1091806: RFS: ydotool/1.0.4-1 [ITA] -- Generic Linux command-line automation tool

2024-12-31 Thread Phil Wyett
Control: tags -1 +confirmed

Andre,

Preamble...

Thank you for taking the time to prepare this package and your contribution to
the Debian project.

This review is offered to help package submitters to Debian mentors inorder to
improve their packages prior to possible sponsorship into Debian. There is no
obligation on behalf of the submitter to make any alterations based upon
information provided in the review.

Review...

1. Build:

  * pbuilder [1]: Good
  * sbuild [2]: Good

2. Lintian [3]: Good

3. Licenses [4]: Good

4. Watch file [uscan --force-download]: Good

5. Build Twice [sudo pbuilder build --twice .dsc]: Good

6. Reproducible builds [5]: Good

7. Install [No previous installs]: Good

8. Upgrade [Over previous installs if any]: Good

Summary...

I believe ydtool is ready for review/possible sponsorship. Could a Debian
Developer (DD) with available free time, please review this package and upload
if you feel it is ready.

Please try the below on your packages...

[1] pbuilder:

  * Command: sudo pbuilder build .dsc
  * Document: https://wiki.ubuntu.com/PbuilderHowto.
  * Document: https://wiki.debian.org/PbuilderTricks

[2] sbuild:

  * Command: sbuild .dsc
  * Document: https://wiki.debian.org/sbuild

[3] lintian:

  * Command: lintian --display-info --verbose --fail-on error --info --pedantic
--show-overrides (*.dsc, *.changes, *.buildinfo). Each can throw up different
results, so be thorough.
  * Document: https://wiki.debian.org/Lintian

[4] lrc:

  * Command: lrc
  * Document: https://wiki.debian.org/CopyrightReviewTools#licenserecon

  Note: Please report false positives as bug reports against 'licenserecon'.

[5] reprotest

  * Command: sudo reprotest --vary=-build_path,domain_host.use_sudo=1 --auto-
build .dsc -- schroot unstable-amd64-sbuild
  * Document: https://wiki.kathenas.org/pmwiki.php/Kathenas/Article0004
  * Document: https://wiki.debian.org/ReproducibleBuilds/
  * Document: https://wiki.debian.org/ReproducibleBuilds/Howto#Newer_method
  
Regards

Phil

-- 

Donations...

Buy Me A Coffee: https://buymeacoffee.com/kathenasorg

--

"I play the game for the game’s own sake"

Arthur Conan Doyle - The Adventure of the Bruce-Partington Plans

--

Internet Relay Chat (IRC): kathenas

Website: https://kathenas.org

Instagram: https://instagram.com/kathenasorg

Threads: https://www.threads.net/@kathenasorg

--



signature.asc
Description: This is a digitally signed message part


Bug#1091806: RFS: ydotool/1.0.4-1 [ITA] -- Generic Linux command-line automation tool

2024-12-31 Thread Andre Paiusco
Package: sponsorship-requests
Severity: normal
X-Debbugs-Cc: [email protected]

Dear mentors,

I am looking for a sponsor for the package "ydotool" that I started a
salvage procedure (https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1086596):

 * Package name : ydotool
   Version  : 1.0.4-1
   Upstream contact : https://github.com/ReimuNotMoe/ydotool/issues
 * URL  : https://github.com/ReimuNotMoe/ydotool
 * License  : AGPL-3.0
 * Vcs  : https://salsa.debian.org/debian/ydotool
   Section  : utils

The source builds the following binary packages:

  ydotool - Generic Linux command-line tool(no X!)

To access further information about this package, please visit the following 
URL:

  https://mentors.debian.net/package/ydotool/

Alternatively, you can download the package with 'dget' using this command:

  dget -x 
https://mentors.debian.net/debian/pool/main/y/ydotool/ydotool_1.0.4-1.dsc

Changes since the last upload:

 ydotool (1.0.4-1) unstable; urgency=medium
 .
   * Change of maintainers (Closes: #1086596).
   * New upstream release (Closes: #1053561).
   * Move license from MIT to AGPL-3.0
   * Update Standard version and Compat version

Regards,
-- 
  Andre Paiusco