Bug#1093837: RFS: pay-respects/0.7.8-1 [ITP] -- Press F to correct your command, pay-respects

2025-07-13 Thread Phil Wyett
Control: tags -1 +confirmed

Don Xu,

Review of upload: 2025-07-13 11:12

For information about the tests run, see:

https://wiki.debian.org/PhilWyett/DebianMentoring

Note: If test line removed, it indicates a test pass.

Summary
===

Looks good here with some diligent work on an interesting package.

Tagging as 'confirmed'.

A DD I can find the time soon to review and possibly sponsor this package.
Reaching out to the Rust Team may help getting a sponsor.

-- 

Regards

Phil

--

Donate to this Free/OSS and Debian contributor.

https://buymeacoffee.com/kathenasorg

--

GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B






signature.asc
Description: This is a digitally signed message part


Bug#1093837: RFS: pay-respects/0.7.8-1 [ITP] -- Press F to correct your command, pay-respects

2025-07-13 Thread EiPi Fun
Hello, Phil Wyett!

Thanks for your suggestions, the package is better now.
The moreinfo tag is removed.
Thank you.

Bests,
EiPi Fun/Don Xu
Jul 13th, 2025



Bug#1093837: RFS: pay-respects/0.7.8-1 [ITP] -- Press F to correct your command, pay-respects

2025-07-11 Thread Phil Wyett
Don Xu,

Review of upload: 2025-07-11 00:57

For information about the tests run, see:

https://wiki.debian.org/PhilWyett/DebianMentoring

Note: If test line removed, it indicates a test pass.

Test 3 (build twice): Information only

 dpkg-source -b .
dpkg-source: info: using options from pay-respects-0.7.8/debian/source/options:
--extend-diff-ignore=Cargo.lock|core/src/locale.rs|module-request-
ai/src/locale.rs|target
dpkg-source: info: using source format '3.0 (quilt)'
dpkg-source: info: building pay-respects using existing ./pay-
respects_0.7.8.orig.tar.gz
dpkg-source: info: using patch list from debian/patches/series
dpkg-source: info: local changes detected, the modified files are:
 pay-respects-0.7.8/.cargo/config.toml
dpkg-source: hint: make sure the version in debian/changelog matches the
unpacked source tree
dpkg-source: hint: you can integrate the local changes with dpkg-source --commit
dpkg-source: error: aborting due to unexpected upstream changes, see /tmp/pay-
respects_0.7.8-1.diff.69za7D
dpkg-buildpackage: error: dpkg-source -b . subprocess returned exit status 2
I: copying local configuration
E: Failed autobuilding of package

Test 4 (sbuild): Information only

Lintian:

I: pay-respects: hardening-no-fortify-functions [usr/bin/pay-respects]
N: 
N:   This package provides an ELF binary that lacks the use of fortified libc
N:   functions. Either there are no potentially unfortified functions called by
N:   any routines, all unfortified calls have already been fully validated at
N:   compile-time, or the package was not built with the default Debian
N:   compiler flags defined by dpkg-buildflags. If built using dpkg-buildflags
N:   directly, be sure to import CPPFLAGS.
N:   
N:   NB: Due to false-positives, Lintian ignores some unprotected functions
N:   (e.g. memcpy).
N: 
N:   Please refer to https://wiki.debian.org/Hardening and Bug#673112 for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: binaries/hardening
N: 
N:
I: pay-respects-module-request-ai: hardening-no-fortify-functions [usr/bin/_pay-
respects-fallback-100-request-ai]
N:
I: pay-respects-module-runtime-rules: hardening-no-fortify-functions
[usr/bin/_pay-respects-module-100-runtime-rules]
N:
I: pay-respects source: override_dh_auto_test-does-not-check-DEB_BUILD_OPTIONS
[debian/rules:32]
N: 
N:   The debian/rules file for this package has an override_dh_auto_test target
N:   that does not appear to check DEB_BUILD_OPTIONS against nocheck.
N:   
N:   As this check is not automatically performed by debhelper(7), the
N:   specified testsuite is run regardless of another maintainer using the
N:   nocheck build option.
N:   
N:   Please add a check such as:
N:   
N:override_dh_auto_test:
N:ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
N:./run-upstream-testsuite
N:endif
N:   
N:   Lintian will ignore comments and other lines such as:
N:   
N:# Disabled
N:: Disabled
N:echo "Disabled"
N:mkdir foo/
N:ENV=var dh_auto_test -- ARG=value
N:   
N:   This check is not required in Debhelper compat level 13 or greater (see
N:   Bug#568897).
N: 
N:   Please refer to debian/rules and DEB_BUILD_OPTIONS (Section 4.9.1) in the
N:   Debian Policy Manual and
N:   https://wiki.debian.org/BuildProfileSpec#Registered_profile_names for
N:   details.
N: 
N:   Visibility: info
N:   Show-Always: no
N:   Check: debian/rules

Summary
===

A couple of things to look at.

Leaving as 'moreinfo'.

-- 

Regards

Phil

--

Donate to this Free/OSS and Debian contributor.

https://buymeacoffee.com/kathenasorg

--

GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B






signature.asc
Description: This is a digitally signed message part