Bug#1108730: RFS: python-googlesearch/1.3.0-1 [ITP] -- Python library for scraping the Google search engine.
Control: tags -1 -moreinfo Control: tags -1 +confirmed Aryan, Review of upload: 2025-07-07 07:42 For information about the tests run, see: https://wiki.debian.org/PhilWyett/DebianMentoring Note: If test line removed, it indicates a test pass. Summary === Looks good here. Tagging as 'confirmed'. Hopefully a DD will find the time to review and upload the package once 'unstable' re-opens. -- Regards Phil -- Donate to this Free/OSS and Debian contributor. https://buymeacoffee.com/kathenasorg -- GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B signature.asc Description: This is a digitally signed message part
Bug#1108730: RFS: python-googlesearch/1.3.0-1 [ITP] -- Python library for scraping the Google search engine.
> From: Phil Wyett > Sent: Monday, July 07, 2025 11:07 AM > To: [email protected] > Cc: [email protected] > Subject: Bug#1108730: RFS: python-googlesearch/1.3.0-1 [ITP] -- Python > library for scraping the Google search engine. > Control: tags -1 +moreinfo > Aryan, > Review of upload: 2025-07-07 04:27 > For information about the tests run, see: > https://wiki.debian.org/PhilWyett/DebianMentoring<https://wiki.debian.org/PhilWyett/DebianMentoring> > Note: If test line removed, it indicates a test pass. > Test 4 (sbuild): Information only > Lintian: > P: python-googlesearch source: trailing-whitespace [debian/changelog:3] > N: > N: This file contains lines with trailing whitespace characters. > N: > N: Whilst often harmless and unsightly, such extra whitespaces can also > cause > N: tools to interpret the whitespace characters literally. The tool diff(1) > N: does not like them, either. They are best avoided. > N: > N: Some of these problems can be hard to track down. > N: > N: Whitespace at the end of lines may be removed with the following: > N: > N:$ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog > N: > N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup). > N: > N: However, if you wish to only remove trailing spaces and leave trailing > N: tabs (eg. for Makefiles), you can use the following code snippet: > N: > N:$ sed -i -e 's@[ ]*$@@g' debian/rules > N: > N: To remove empty lines from the end of a file, you can use: > N: > N:$ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules > N: > N: Visibility: pedantic > N: Show-Always: no > N: Check: debian/trailing-whitespace > N: Renamed from: file-contains-trailing-whitespace > N: > N: > P: python-googlesearch source: trailing-whitespace [debian/control:28] > N: > P: python-googlesearch source: trailing-whitespace [debian/control:30] > N: > P: python-googlesearch source: trailing-whitespace [debian/rules:7] > N: > P: python-googlesearch source: trailing-whitespace [debian/rules:8] > Summary > === > Looking promising. A few lintian issues to be resolved and we can review > again. > -- > Regards > Phil > -- > Donate to this Free/OSS and Debian contributor. > https://buymeacoffee.com/kathenasorg > -- > GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B Hi Phil, thanks for taking your time reviewing my package. I've rebuilt the package following your test #4 that you mentioned on IRC. I've added newlines at the end of debian/control and debian/rules to pass all lintian tests of sbuild. Here's the final sbuild output: +--+ | Summary Mon, 07 Jul 2025 07:20:35 + | +--+ Autopkgtest: no tests Build Architecture: amd64 Build Type: full Build-Space: 248 Build-Time: 5 Distribution: unstable Host Architecture: amd64 Install-Time: 126 Job: /home/aryan/Documents/googlesearch deb/python-googlesearch_1.3.0-1.dsc Lintian: pass Machine Architecture: amd64 Package: python-googlesearch Package-Time: 156 Source-Version: 1.3.0-1 Space: 248 Status: successful Version: 1.3.0-1 Finished at 2025-07-07T07:15:51Z Build needed 00:02:36, 248k disk space I also ran piuparts separately as mentioned in test #4 against sources.changes file and here's the output: 2m55.6s INFO: PASS: All tests. 2m55.6s INFO: piuparts run ends. The updated package can be found here: https://mentors.debian.net/package/python-googlesearch/ Thank you Phil. Regards, Aryan Karamtoth (IRC: SpaciousCoder78)
Bug#1108730: RFS: python-googlesearch/1.3.0-1 [ITP] -- Python library for scraping the Google search engine.
Control: tags -1 +moreinfo
Aryan,
Review of upload: 2025-07-07 04:27
For information about the tests run, see:
https://wiki.debian.org/PhilWyett/DebianMentoring
Note: If test line removed, it indicates a test pass.
Test 4 (sbuild): Information only
Lintian:
P: python-googlesearch source: trailing-whitespace [debian/changelog:3]
N:
N: This file contains lines with trailing whitespace characters.
N:
N: Whilst often harmless and unsightly, such extra whitespaces can also cause
N: tools to interpret the whitespace characters literally. The tool diff(1)
N: does not like them, either. They are best avoided.
N:
N: Some of these problems can be hard to track down.
N:
N: Whitespace at the end of lines may be removed with the following:
N:
N:$ sed -i -e 's@[[:space:]]*$@@g' debian/control debian/changelog
N:
N: If you use Emacs, you can also use "M-x wh-cl" (whitespace-cleanup).
N:
N: However, if you wish to only remove trailing spaces and leave trailing
N: tabs (eg. for Makefiles), you can use the following code snippet:
N:
N:$ sed -i -e 's@[ ]*$@@g' debian/rules
N:
N: To remove empty lines from the end of a file, you can use:
N:
N:$ sed -i -e :a -e '/^\n*$/{$d;N;};/\n$/ba' debian/rules
N:
N: Visibility: pedantic
N: Show-Always: no
N: Check: debian/trailing-whitespace
N: Renamed from: file-contains-trailing-whitespace
N:
N:
P: python-googlesearch source: trailing-whitespace [debian/control:28]
N:
P: python-googlesearch source: trailing-whitespace [debian/control:30]
N:
P: python-googlesearch source: trailing-whitespace [debian/rules:7]
N:
P: python-googlesearch source: trailing-whitespace [debian/rules:8]
Summary
===
Looking promising. A few lintian issues to be resolved and we can review again.
--
Regards
Phil
--
Donate to this Free/OSS and Debian contributor.
https://buymeacoffee.com/kathenasorg
--
GPG Fingerprint: 70A0 AC45 AC77 9EFE 84F6 3AED 724A A9B5 2F02 4C8B
signature.asc
Description: This is a digitally signed message part
Bug#1108730: RFS: python-googlesearch/1.3.0-1 [ITP] -- Python library for scraping the Google search engine.
Hi, Phil thanks for reviewing my package, python-googlesearch on mentors.debian,net yesterday. Sorry for emailing you directly but I have deleted and reuploaded my package on mentors.debian.net due to which, your comment on my package also got deleted so I'm requoting it here for reference. > From: Phil Wyett > Package: python-googlesearch > Url: https://mentors.debian.net/package/python-googlesearch/ > --- > Hi, > Build error: > == > ERROR: googlesearch (unittest.loader._FailedTest.googlesearch) > -- > ImportError: Failed to import test module: googlesearch > Traceback (most recent call last): > File "/usr/lib/python3.13/unittest/loader.py", line 429, in _find_test_path >package = self._get_module_from_name(name) > File "/usr/lib/python3.13/unittest/loader.py", line 339, in > _get_module_from_name >__import__(name) ~~^^ > File "/build/python-googlesearch-1.3.0/.pybuild/cpython3_3.13_googlesearch/build/googlesearch/__init__.py", line 3, > in >from bs4 import BeautifulSoup > ModuleNotFoundError: No module named 'bs4' > Regards > Phil > --- > Thanks, > -- > mentors.debian.net I noticed that it might be because I didn't include bs4 and requests in Build-Depends, which I did in the latest reupload on mentors.debian.net Link to my package: https://mentors.debian.net/package/python-googlesearch/ I have also used sbuild with stricter lintian checks and resolved all of the minor errors. My post sbuild output returned this: +--+ | Summary Mon, 07 Jul 2025 04:16:36 + | +--+ Autopkgtest: no tests Build Architecture: amd64 Build Type: full Build-Space: 248 Build-Time: 4 Distribution: unstable Host Architecture: amd64 Install-Time: 123 Job: /home/aryan/Documents/googlesearch deb/python-googlesearch_1.3.0-1.dsc Lintian: pass Machine Architecture: amd64 Package: python-googlesearch Package-Time: 149 Source-Version: 1.3.0-1 Space: 248 Status: successful Version: 1.3.0-1 Finished at 2025-07-07T04:12:37Z Build needed 00:02:29, 248k disk space Can you please re-review my work and tell me if there are any other changes I need to make?
Bug#1108730: RFS: python-googlesearch/1.3.0-1 [ITP] -- Python library for scraping the Google search engine.
Package: sponsorship-requests Severity: wishlist Dear mentors, I am looking for a sponsor for my package "python-googlesearch": * Package name : python-googlesearch Version : 1.3.0-1 Upstream contact : Nishanth Vikramaditya * URL : https://github.com/Nv7-GitHub/googlesearch * License : Expat * Vcs : https://salsa.debian.org/SpaciousCoder78/python-googlesearch.git Section : python The source builds the following binary packages: python3-googlesearch - Python library for scraping the Google search engine. To access further information about this package, please visit the following URL: https://mentors.debian.net/package/python-googlesearch/ Alternatively, you can download the package with 'dget' using this command: dget -x https://mentors.debian.net/debian/pool/main/p/python-googlesearch/python-googlesearch_1.3.0-1.dsc Changes for the initial release: python-googlesearch (1.3.0-1) unstable; urgency=medium . * Initial release. (Closes: #1108518) Regards, -- Aryan Karamtoth
