Bug#1109087: bookworm-pu: package multipath-tools/0.9.4-3+deb12u2

2025-07-11 Thread Chris Hofstaedtler 

* Jonathan Wiltshire  [250711 22:57]:

Control: tag -1 confirmed

Please go ahead.


Uploaded.

Thanks,
Chris

Bug#1109087: bookworm-pu: package multipath-tools/0.9.4-3+deb12u2

2025-07-11 Thread Jonathan Wiltshire 
Control: tag -1 confirmed

Please go ahead.

Thanks,

-- 
Jonathan Wiltshire  [email protected]
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51
ed25519/0x196418AAEB74C8A1: CA619D65A72A7BADFC96D280196418AAEB74C8A1

Bug#1109087: bookworm-pu: package multipath-tools/0.9.4-3+deb12u2

2025-07-11 Thread Cyril Brulebois 
Hi,

Chris Hofstädtler  (2025-07-11):
> Package: release.debian.org
> Severity: normal
> Tags: bookworm
> X-Debbugs-Cc: [email protected], 
> [email protected]
> Control: affects -1 + src:multipath-tools
> User: [email protected]
> Usertags: pu

No objections d-i wise. Not sure where we're at anyway regarding
multipath support, it's been a while since I last had to look into it…


Cheers,
-- 
Cyril Brulebois ([email protected])
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature

Bug#1109087: bookworm-pu: package multipath-tools/0.9.4-3+deb12u2

2025-07-10 Thread Chris Hofstädtler 
Package: release.debian.org
Severity: normal
Tags: bookworm
X-Debbugs-Cc: [email protected], [email protected]
Control: affects -1 + src:multipath-tools
User: [email protected]
Usertags: pu

[ Reason ]

Upstream broke the build logic for the ANA prioritizer in a release 
just before bookworm was released. This was reported as Debian bug 
#1101332.

[ Impact ]

NVMe systems cannot use multipath-tools because the NVMe-specified 
prioritizer is missing.

[ Tests ]

Unclear. I have verified libprioana.so is now built and in the .deb.

[ Risks ]

Systems with NVMe devices will now get the ANA prioritizer as they 
should have.

I don't see any code updates to the ANA prioritizer upstream, so I 
assume it works correctly and we don't get any regressions from 
that.

Unstable has the ANA prioritizer since 13 Jun 2024, when 0.9.8 was 
imported.

[ Checklist ]
  [x] *all* changes are documented in the d/changelog
  [x] I reviewed all changes and I approve them
  [x] attach debdiff against the package in (old)stable
  [x] the issue is verified as fixed in unstable

[ Changes ]
We apply the upstream patch that landed in 0.9.8, which flips the 
conditional in the makefile. This causes libprioana.so to be built, 
and it automatically gets picked up into multipath-tools.deb and 
multipath-tools.udeb.

[ Other info ]
multipath-tools has udebs.
diff -Nru multipath-tools-0.9.4/debian/changelog 
multipath-tools-0.9.4/debian/changelog
--- multipath-tools-0.9.4/debian/changelog  2023-06-24 23:07:02.0 
+0200
+++ multipath-tools-0.9.4/debian/changelog  2025-07-11 08:03:41.0 
+0200
@@ -1,3 +1,11 @@
+multipath-tools (0.9.4-3+deb12u2) bookworm; urgency=medium
+
+  * [571eae5] Fix Makefile to enable ANA prioritizer.
+Apply upstream fix to correctly enable the ANA prioritizer.
+Thanks to Lasse Bang Mikkelsen (Closes: #1101332)
+
+ -- Chris Hofstaedtler   Fri, 11 Jul 2025 08:03:41 +0200
+
 multipath-tools (0.9.4-3+deb12u1) bookworm; urgency=medium
 
   * [cfa5138] Re-add dm-multipath module loading to ExecStartPre
diff -Nru 
multipath-tools-0.9.4/debian/patches/0010-libmultipath-fix-ANA-prioritizer-enablement-logic.patch
 
multipath-tools-0.9.4/debian/patches/0010-libmultipath-fix-ANA-prioritizer-enablement-logic.patch
--- 
multipath-tools-0.9.4/debian/patches/0010-libmultipath-fix-ANA-prioritizer-enablement-logic.patch
   1970-01-01 01:00:00.0 +0100
+++ 
multipath-tools-0.9.4/debian/patches/0010-libmultipath-fix-ANA-prioritizer-enablement-logic.patch
   2025-07-11 08:02:18.0 +0200
@@ -0,0 +1,27 @@
+From: Martin Wilck 
+Date: Thu, 4 Jan 2024 12:04:06 +0100
+Subject: libmultipath: fix ANA prioritizer enablement logic
+
+Fixes: 3e71d8a ("multipath-tools Makefiles: create config.mk")
+
+Suggested-by: Lidong Zhong 
+Signed-off-by: Martin Wilck 
+Reviewed-by: Benjamin Marzinski 
+Bug-Debian: #1101332
+---
+ libmultipath/prioritizers/Makefile | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/libmultipath/prioritizers/Makefile 
b/libmultipath/prioritizers/Makefile
+index fdec36e..ff2524c 100644
+--- a/libmultipath/prioritizers/Makefile
 b/libmultipath/prioritizers/Makefile
+@@ -26,7 +26,7 @@ LIBS = \
+   libpriopath_latency.so \
+   libpriosysfs.so
+ 
+-ifneq ($(ANA_SUPPORT),1)
++ifeq ($(ANA_SUPPORT),1)
+   LIBS += libprioana.so
+   CPPFLAGS += -I../nvme
+ endif
diff -Nru multipath-tools-0.9.4/debian/patches/series 
multipath-tools-0.9.4/debian/patches/series
--- multipath-tools-0.9.4/debian/patches/series 2023-06-24 23:07:02.0 
+0200
+++ multipath-tools-0.9.4/debian/patches/series 2025-07-11 08:02:18.0 
+0200
@@ -7,3 +7,4 @@
 0010-multipath.rules-do-not-assume-usrmerged-paths.patch
 0012-Reproducible-build.patch
 0006-multipathd.service-re-add-ExecStartPre.patch
+0010-libmultipath-fix-ANA-prioritizer-enablement-logic.patch