The Debian NEW review of libgbinder 1.1.45+ds-1 has been completed.
Decision: REJECTED
Reviewer: Reinhard Tartler
Review comment:
Thanks for your diligence in bringing libgbinder to the archive. It's a
valuable addition, but I've run into a few snags in debian/copyright
that we'll need to sort out before it can be accepted.
I noticed a slight slip in the attribution of several contributors. While
Jolla and Slava are well-represented, a few others who are credited
directly in the source headers have been missed in the copyright file.
Specifically:
* Gary Wang is credited in several AIDL-related
files (like src/gbinder_servicemanager_aidl4.c).
* Madhushan Nishantha also appears in those
same files.
* Franz-Josef Haider is credited in
test/binder-call/binder-call.c.
There's also a bit of a DFSG problem with src/binder.h. Since it's a
bundled header derived from the Linux kernel via the Android Bionic
project, it needs its own stanza acknowledging the original authors
(Linux Kernel Developers and Google), even if the header itself claims
to be non-copyrightable.
I also noticed that the BSD-3-clause license text in debian/copyright
seems to be a generic template rather than a verbatim copy of the
actual license used by the project. For instance, your text still
contains the "name of the ORGANIZATION" placeholder in the third
condition, whereas upstream has replaced this with "names of the
copyright holders." Similarly, the disclaimer in the source uses the
plural "COPYRIGHT HOLDERS," while your text is in the singular. For
a machine-readable copyright file, the text must be an exact verbatim
match of what's in the source (including numbering styles and
disclaimers), so please replace the template with the specific text
found in the LICENSE file.
Lastly, Slava Monich uses a couple of different email addresses across
the headers, and some files like the cmdline lexer/parser in the test
directory are missing headers entirely. It would be great to have those
all tidied up in the documentation.
Please take another look at the source and re-upload once these are
addressed. I'm looking forward to seeing this in the archive.
-rt
Full review details: https://dfsg-new-queue.debian.org/reviews/libgbinder
