Bug#1126094: trixie-pu: package brltty/6.7-3.1+deb13u3

2026-03-07 Thread Cyril Brulebois
Hi,

Jonathan Wiltshire  (2026-01-26):
> Looks fine to me, but d-i ack required for the udeb.

Sorry I didn't reply explicitly, but given Samuel's follow-up and Adam's
untagging this bug recently, it seems everything is lined up already.


Cheers,
-- 
Cyril Brulebois ([email protected])
D-I release manager -- Release team member -- Freelance Consultant


signature.asc
Description: PGP signature


Bug#1126094: trixie-pu: package brltty/6.7-3.1+deb13u3

2026-01-26 Thread Jonathan Wiltshire
Control: tag -1 d-i

Hi,

On Wed, Jan 21, 2026 at 07:24:48PM +0100, Samuel Thibault wrote:
> [ Reason ]
> Blind people have reported that when they use gnome on wayland with a
> braille device and the Orca screen reader, if they switch to a textual
> VT with ctrl-alt-Fn, the orca output remains stuck on the braille
> device, instead of getting the text from the text console.
> 
> This is due to the move of orca into getting started in its own systemd
> session, introduced in Orca 49, which is available in stable-backports.

Looks fine to me, but d-i ack required for the udeb.

Thanks,

-- 
Jonathan Wiltshire  [email protected]
Debian Developer http://people.debian.org/~jmw

4096R: 0xD3524C51 / 0A55 B7C5 1223 3942 86EC  74C3 5394 479D D352 4C51
ed25519/0x196418AAEB74C8A1: CA619D65A72A7BADFC96D280196418AAEB74C8A1



Processed: Re: Bug#1126094: trixie-pu: package brltty/6.7-3.1+deb13u3

2026-01-26 Thread Debian Bug Tracking System
Processing control commands:

> tag -1 d-i
Bug #1126094 [release.debian.org] trixie-pu: package brltty/6.7-3.1+deb13u3
Added tag(s) d-i.

-- 
1126094: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1126094
Debian Bug Tracking System
Contact [email protected] with problems



Bug#1126094: trixie-pu: package brltty/6.7-3.1+deb13u3

2026-01-26 Thread Samuel Thibault
Jonathan Wiltshire, le lun. 26 janv. 2026 21:57:27 +, a ecrit:
> On Wed, Jan 21, 2026 at 07:24:48PM +0100, Samuel Thibault wrote:
> > [ Reason ]
> > Blind people have reported that when they use gnome on wayland with a
> > braille device and the Orca screen reader, if they switch to a textual
> > VT with ctrl-alt-Fn, the orca output remains stuck on the braille
> > device, instead of getting the text from the text console.
> > 
> > This is due to the move of orca into getting started in its own systemd
> > session, introduced in Orca 49, which is available in stable-backports.
> 
> Looks fine to me, but d-i ack required for the udeb.

The library in which this code resides, is not shipped in the installer :)

Samuel



Bug#1126094: trixie-pu: package brltty/6.7-3.1+deb13u3

2026-01-21 Thread Samuel Thibault
Package: release.debian.org
Severity: normal
Tags: trixie
X-Debbugs-Cc: [email protected]
Control: affects -1 + src:brltty
User: [email protected]
Usertags: pu

Hello,

I have uploaded brltty 6.7-3.1+deb13u3 for inclusion in Trixie

[ Reason ]
Blind people have reported that when they use gnome on wayland with a
braille device and the Orca screen reader, if they switch to a textual
VT with ctrl-alt-Fn, the orca output remains stuck on the braille
device, instead of getting the text from the text console.

This is due to the move of orca into getting started in its own systemd
session, introduced in Orca 49, which is available in stable-backports.

[ Impact ]
Blind users cannot use both graphical and text sessions with a braille
device.

[ Tests ]
This was tested manually.

[ Risks ]
The code is very trivial and upstreamed.

[ Checklist ]
  [X] *all* changes are documented in the d/changelog
  [X] I reviewed all changes and I approve them
  [X] attach debdiff against the package in (old)stable
  [X] the issue is verified as fixed in unstable

[ Changes ]
brltty already had everything to get output corrected routed by making
orca determine which VT number it is running on:

  chosen = -1
  for (i = 0; i < nsessions; i++) {
if (/*...*/) {
/*...*/
chosen = i;
}
  }

but there was a typo:

  if (chosen >= 0) sd_session_get_vt(sessions[i], &vtnr);

instead of using the 'chosen' variable computed in the loop, it used
'i', which is the iterator of the loop, thus an erroneous value which
fails to get the vtnr.

Samuel
diff -Nru brltty-6.7/debian/changelog brltty-6.7/debian/changelog
--- brltty-6.7/debian/changelog 2025-09-10 23:44:02.0 +0200
+++ brltty-6.7/debian/changelog 2026-01-21 19:00:18.0 +0100
@@ -1,3 +1,9 @@
+brltty (6.7-3.1+deb13u3) trixie; urgency=medium
+
+  * patches/systemd-vtnr: Fix getting vtnr from systemd.
+
+ -- Samuel Thibault   Wed, 21 Jan 2026 19:00:18 +0100
+
 brltty (6.7-3.1+deb13u2) trixie; urgency=medium
 
   * patches/noverbose-bluetooth: Avoid verbose bluetooth spam.
diff -Nru brltty-6.7/debian/patches/series brltty-6.7/debian/patches/series
--- brltty-6.7/debian/patches/series2025-09-10 23:44:02.0 +0200
+++ brltty-6.7/debian/patches/series2026-01-21 19:00:18.0 +0100
@@ -7,3 +7,4 @@
 git-notext-noread
 noverbose-bluetooth
 noverbose-usbfs
+systemd-vtnr
diff -Nru brltty-6.7/debian/patches/systemd-vtnr 
brltty-6.7/debian/patches/systemd-vtnr
--- brltty-6.7/debian/patches/systemd-vtnr  1970-01-01 01:00:00.0 
+0100
+++ brltty-6.7/debian/patches/systemd-vtnr  2026-01-21 18:59:57.0 
+0100
@@ -0,0 +1,24 @@
+Forwarded: https://github.com/brltty/brltty/pull/512
+
+commit 609d32ffe404acb612e2d98bb84a0c09f0e6ab75
+Author: Samuel Thibault 
+Date:   Mon Jan 12 20:36:30 2026 +0100
+
+brlapi: Fix taking the VT number from the chosen session
+
+The loop above was meant to decide which session to take the VT number
+from.
+
+diff --git a/Programs/brlapi_client.c b/Programs/brlapi_client.c
+index f0fe04335..2f93ae8c8 100644
+--- a/Programs/brlapi_client.c
 b/Programs/brlapi_client.c
+@@ -1806,7 +1806,7 @@ int BRLAPI_STDCALL 
brlapi__enterTtyModeWithPath(brlapi_handle_t *handle, const i
+   }
+ }
+ 
+-if (chosen >= 0) sd_session_get_vt(sessions[i], &vtnr);
++if (chosen >= 0) sd_session_get_vt(sessions[chosen], &vtnr);
+ 
+ for (i = 0; i < nsessions; i++) free(sessions[i]);
+ free(sessions);