Re: Bug#1063329: libselinux1t64: breaks system in upgrade from unstable
control: tags -1 fixed-upstream,help Hi, as discussed in https://salsa.debian.org/selinux-team/libselinux/-/merge_requests/9 the ABI breakage has benn resolved since libselinux version 3.8-1 (present in Debian stable). Is there anything left to do here, e.g. as suggested in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1063329#89 by Paul a rebuild of binaries built against a broken version? I am not familiar with binNMUs or rebuild so any suggestions and help is welcome.
Re: Bug#1063329: libselinux1t64: breaks system in upgrade from unstable
Hi, On Fri, 24 Jan 2025 08:37:23 +0100 Helmut Grohne wrote: On Thu, Feb 15, 2024 at 04:48:43PM -0800, Steve Langasek wrote: > Patch now forwarded upstream for review. > > https://lore.kernel.org/selinux/[email protected]/T/#t This has been merged and is available upstream. https://github.com/SELinuxProject/selinux/commit/9395cc03226a0e1a220a37d71d1a4158635c4284 The change is not in the latest libselinux upload. https://sources.debian.org/src/libselinux/3.7-3/include/selinux/selinux.h/ But it now is in unstable and testing as far as I checked. As a result, unstable presently has broken ABI and applying the patch (that has been accepted upstream) will revert the ABI breakage. Beware that after applying the patch, we must schedule binNMUs for reverse dependencies on armel and armhf (+ multiarch sync) as a symbol is being redirected. Otherwise, we have reverse ABI breakage due to the earlier breakage having been picked up. So no, this is not done, but it's not much left to be done. Do I understand correctly that we still need to binNMU those binaries that were built with the broken version? Paul OpenPGP_signature.asc Description: OpenPGP digital signature
Re: Bug#1063329: libselinux1t64: breaks system in upgrade from unstable
Control: retitle -1 libselinux breaks ABI of matchpathcon_filespec_add Control: tags -1 upstream fixed-upstream Control: forwarded -1 https://github.com/SELinuxProject/selinux/commit/9395cc03226a0e1a220a37d71d1a4158635c4284 Control: tags 1063135 + wontfix Control: close 1063135 Hi, Paul asked me to follow up on these rc bugs. I am closing #1063135, because we will not move forward with a rename to libselinux1t64. The package has been removed from experimental meanwhile, so this is fully done. We have addressed the package upgrade by not moving from libselinux1 to libselinux1t64, but that means libselinux now breaks ABI of matchpathcon_filespec_add. To that end, Steve really did fix libselinux upstream. On Thu, Feb 15, 2024 at 04:48:43PM -0800, Steve Langasek wrote: > Patch now forwarded upstream for review. > > https://lore.kernel.org/selinux/[email protected]/T/#t This has been merged and is available upstream. https://github.com/SELinuxProject/selinux/commit/9395cc03226a0e1a220a37d71d1a4158635c4284 The change is not in the latest libselinux upload. https://sources.debian.org/src/libselinux/3.7-3/include/selinux/selinux.h/ As a result, unstable presently has broken ABI and applying the patch (that has been accepted upstream) will revert the ABI breakage. Beware that after applying the patch, we must schedule binNMUs for reverse dependencies on armel and armhf (+ multiarch sync) as a symbol is being redirected. Otherwise, we have reverse ABI breakage due to the earlier breakage having been picked up. So no, this is not done, but it's not much left to be done. Helmut
