Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1009
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1009#issuecomment-153681458
code LGTM, @rags22489664 can you put the integration test in the simulator
on your backlog? would love to see it :) If tests pass merge, @remibergsma .
Thought
Github user rags22489664 commented on the pull request:
https://github.com/apache/cloudstack/pull/1009#issuecomment-153573303
Added Filter test which checks the Order By clause is being constructed
properly by the Filter class
---
If your project is set up for it, you can reply to th
Github user rags22489664 commented on the pull request:
https://github.com/apache/cloudstack/pull/1009#issuecomment-153289004
oh..let me remove the second commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your pr
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1009#issuecomment-153286973
Hi @rags22489664 Thanks for the fix! Can you please get rid of that second
commit? It cannot be merged like this. Thanks!
If you add a unit test, @dahn
Github user rags22489664 commented on the pull request:
https://github.com/apache/cloudstack/pull/1009#issuecomment-153245362
I noticed this issue when the API takes a while to respond and we fire the
API concurrently. Not really sure how we can reproduce this without having to
add 10
Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/1009#issuecomment-152662658
code lgtm, but I'm wondering on testing this (in integration sense) I think
a unit test would by nice as @bhaisaab. In addition to that if we want to
verify th
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1009#discussion_r43523867
--- Diff: framework/db/src/com/cloud/utils/db/Filter.java ---
@@ -89,7 +89,7 @@ public void addOrderBy(Class clazz, String field,
boolean ascending) {
Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1009#discussion_r43523817
--- Diff: framework/db/src/com/cloud/utils/db/Filter.java ---
@@ -89,7 +89,7 @@ public void addOrderBy(Class clazz, String field,
boolean ascending) {
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1009#issuecomment-152570782
LGTM, based on a set of tests that I run on this branch (which I rebased
myself first):
```
nosetests --with-marvin --marvin-config=${marvinCfg} -s
GitHub user rags22489664 opened a pull request:
https://github.com/apache/cloudstack/pull/1009
CLOUDSTACK-9006 - ListTemplates API returns result in inconsistent order
when called concurrently
The order of templates returned in the response is based on a field called
sortkey and by
11 matches
Mail list logo
