Re: Review Request 12548: Unify whitelist implementations: Android implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12548/ --- (Updated July 17, 2013, 5:35 p.m.) Review request for cordova. Changes --

Re: Review Request 12548: Unify whitelist implementations: Android implementation

> On July 17, 2013, 2:54 p.m., Andrew Grieve wrote: > > framework/src/org/apache/cordova/Whitelist.java, line 13 > > > > > > make private & static? > > Ian Clelland wrote: > This is for efficiency, and not to chang

Re: Review Request 12548: Unify whitelist implementations: Android implementation

> On July 17, 2013, 2:54 p.m., Andrew Grieve wrote: > > framework/src/org/apache/cordova/Whitelist.java, line 65 > > > > > > Instead of parsing the url yourself, it might be better to use: > > > > Uri.parse(url

Re: Review Request 12548: Unify whitelist implementations: Android implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12548/ --- (Updated July 17, 2013, 3:20 p.m.) Review request for cordova. Changes --

Re: Review Request 12548: Unify whitelist implementations: Android implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12548/ --- (Updated July 17, 2013, 3:22 p.m.) Review request for cordova. Changes --

Re: Review Request 12548: Unify whitelist implementations: Android implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12548/#review23273 --- framework/src/org/apache/cordova/Config.java

Review Request 12548: Unify whitelist implementations: Android implementation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/12548/ --- Review request for cordova. Repository: cordova-android-git Description -