Re: DO NOT REPLY [Bug 45023] DEFLATE preventing 304 NOT MODIFIED response

2008-08-21 Thread Nick Kew
On 19 Aug 2008, at 14:41, [EMAIL PROTECTED] wrote: --- Comment #5 from rahul [EMAIL PROTECTED] 2008-08-19 06:41:51 PST --- Created an attachment (id=22453) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=22453) A POC slightly better than the above conf lines, Adds an input filter

Re: [PATCH] Dynamic locking upcalls in mod_ssl

2008-08-21 Thread Joe Orton
On Wed, Aug 20, 2008 at 10:36:37AM -0400, Sander Temme wrote: On Aug 18, 2008, at 5:18 AM, Joe Orton wrote: So generally pconf is the right pool to use, along with a cleanup registered against that pool which sets the callbacks to NULL. Yes, with the cleanup it no longer hangs. What about

Re: [PATCH] Dynamic locking upcalls in mod_ssl

2008-08-21 Thread Plüm, Rüdiger, VF-Group
-Ursprüngliche Nachricht- Von: Joe Orton Gesendet: Donnerstag, 21. August 2008 13:41 An: dev@httpd.apache.org Betreff: Re: [PATCH] Dynamic locking upcalls in mod_ssl On Wed, Aug 20, 2008 at 10:36:37AM -0400, Sander Temme wrote: On Aug 18, 2008, at 5:18 AM, Joe Orton wrote:

Re: Dropping mod_sed into /trunk/ ?

2008-08-21 Thread Jeff Trawick
On Wed, Aug 20, 2008 at 6:53 PM, Nick Kew [EMAIL PROTECTED] wrote: Any thoughts on dropping it in to trunk Is it best to preserve the current files/filenames (sed.h, libsed.h, sed0.c, etc.) to better reflect the history of that code, or should the files be combined/renamed to something that

Re: [PATCH] Dynamic locking upcalls in mod_ssl

2008-08-21 Thread Joe Orton
On Thu, Aug 21, 2008 at 01:49:35PM +0200, Plüm, Rüdiger, VF-Group wrote: Given that the lifetime of the callbacks is now constrained, is the new global pool still needed? Where does this patch use a global pool? It keeps a reference on the pconf pool in a global variable, but it no longer

Re: Dropping mod_sed into /trunk/ ?

2008-08-21 Thread Jorge Schrauwen
On Thu, Aug 21, 2008 at 1:53 PM, Jeff Trawick [EMAIL PROTECTED] wrote: On Wed, Aug 20, 2008 at 6:53 PM, Nick Kew [EMAIL PROTECTED] wrote: Any thoughts on dropping it in to trunk Is it best to preserve the current files/filenames (sed.h, libsed.h, sed0.c, etc.) to better reflect the

Re: Dropping mod_sed into /trunk/ ?

2008-08-21 Thread rahul
| Any thoughts on dropping it in to trunk, with a view | to including it as standard in 2.4 in due course? | | mod_sed is much more than a mere string-or-regexp search-and-replace What happens to mod_substitute? especially since what substitute provides seems to be a strict subset of mod_sed ?

Re: Dropping mod_sed into /trunk/ ?

2008-08-21 Thread Jim Jagielski
On Aug 20, 2008, at 6:53 PM, Nick Kew wrote: A little while ago, Basant Kukreja published mod_sed under the Apache license. He's now also written a blog entry that could become the basis for a tutorial into how mod_sed is much more than a mere string-or-regexp search-and-replace filter:

Re: svn commit: r686809 - /httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c

2008-08-21 Thread Jim Jagielski
On Aug 19, 2008, at 11:44 PM, William A. Rowe, Jr. wrote: William A. Rowe, Jr. wrote: Different issue; different response. Bill Barker wrote: Nick Kew [EMAIL PROTECTED] wrote in message -1. Semicolon is a perfectly valid character in a session-id, so that risks breaking other apps. The

Re: Dropping mod_sed into /trunk/ ?

2008-08-21 Thread Nick Kew
On 21 Aug 2008, at 13:02, rahul wrote: | Any thoughts on dropping it in to trunk, with a view | to including it as standard in 2.4 in due course? | | mod_sed is much more than a mere string-or-regexp search-and- replace What happens to mod_substitute? especially since what substitute

Re: svn commit: r686809 - /httpd/httpd/trunk/modules/proxy/mod_proxy_balancer.c

2008-08-21 Thread Nick Kew
On 21 Aug 2008, at 13:39, Jim Jagielski wrote: In any case, I agree that both solutions are non-optimal... This leads me to believe that whether we should treat ';' as special for session/route data should be runtime configurable. I propose a simple envar... Sound OK? +1. (assuming I

Re: Dropping mod_sed into /trunk/ ?

2008-08-21 Thread Nick Kew
On 21 Aug 2008, at 13:28, Jim Jagielski wrote: On Aug 20, 2008, at 6:53 PM, Nick Kew wrote: A little while ago, Basant Kukreja published mod_sed under the Apache license. He's now also written a blog entry that could become the basis for a tutorial into how mod_sed is much more than a mere

Re: [PATCH] Dynamic locking upcalls in mod_ssl

2008-08-21 Thread Sander Temme
On Aug 21, 2008, at 7:41 AM, Joe Orton wrote: Yes, with the cleanup it no longer hangs. What about stashing a pool reference in a global, is that a red flag? Given that the lifetime of the callbacks is now constrained, is the new global pool still needed? As Rüdiger mentioned, the pool

Re: SNI in 2.2.x (Re: Time for 2.2.10?)

2008-08-21 Thread Oden Eriksson
Den Wednesday 20 August 2008 13:10:52 skrev Nick Kew: On Wed, 20 Aug 2008 12:06:33 +0200 Oden Eriksson [EMAIL PROTECTED] wrote: FYI: This patch is applied in Mandriva Linux. Any feedback? Bug reports coming from their users? No reports so far. It was requested by our users though. If

Re: Dropping mod_sed into /trunk/ ?

2008-08-21 Thread Basant Kumar kukreja
Thanks Nick for your initiative to make it part of Apache httpd. I am glad to contribute to the Apache Software Foundation. On Thu, Aug 21, 2008 at 02:04:14PM +0100, Nick Kew wrote: On 21 Aug 2008, at 13:28, Jim Jagielski wrote: On Aug 20, 2008, at 6:53 PM, Nick Kew wrote: A little while

Re: SNI in 2.2.x (Re: Time for 2.2.10?)

2008-08-21 Thread Ian G
Nick Kew [EMAIL PROTECTED]wrote: ... It might be worth a --with-SNI configuration option, which would label it as an experimental feature. I imagine the use of SNI would need to be configured in httpd.conf anyway, in the virtual host parts. Would an overall directive like:

[community] 2.3.0 alpha on October 1?

2008-08-21 Thread William A. Rowe, Jr.
I'm thinking of tagging 2.3.0 alpha a month before we gather in New Orleans for ApacheCon 2008/US http://us.apachecon.com/c/acus2008/ so that we can begin to gather community feedback and actually /do/ something about it at the hackathon. Ok, I'm using 'we' sort of liberally, I'm training a day