Re: [VOTE] Release log4cxx 0.13.0

+1 On Sat, Apr 16, 2022 at 10:01 AM Robert Middleton wrote: > This is a vote to release log4cxx 0.13.0. > > Please download, test, and cast your votes on the log4j developers list. > [] +1, release the artifacts > [] -1, don't release because... > > This vote will remain open for 72 hours(or mor

Re: log4j slow startup time - could this be a factor?

Thanks for the responses. It just struck me as I was debugging something, but I did not actually measure whether this is a real bottleneck. What Volkan and Matt are saying makes sense, that it is unlikely that this is actually a bottleneck. On Sat, Apr 16, 2022 at 3:33 AM Matt Sicker wrote: > I

[VOTE] Release log4cxx 0.13.0

This is a vote to release log4cxx 0.13.0. Please download, test, and cast your votes on the log4j developers list. [] +1, release the artifacts [] -1, don't release because... This vote will remain open for 72 hours(or more if required). All votes are welcome and we encourage everyone to test th

Re: Stack valued MDC

I can understand how the stack-based mdc might be convenient and useful, but I don't think it fits my use-cases. That said, I wonder if the API could be improved in such a way that it could leverage the application stack instead of maintaining its own -- this is an issue that I've encountered in

Stack valued MDC

Hello everybody, In SLF4J-531 Ceki added support for an MDC containing stack values in SLF4J 2.0. Since some servlet containers like Jetty are already distributing alpha versions of SLF4J 2.0, I started implementing the new SLF4J 2.0 in the `slf4j-2.0` branch

Re: merging PRs - branch protection questions

Thanks for the heads up Matt! Have done it. On Fri, Apr 15, 2022 at 8:37 PM Matt Sicker wrote: > Volkan, if you'd like to continue using git commit sigs, you should > also upload your public GPG key to your GitHub account so that it can > verify your commits, too. Otherwise, GitHub doesn't exact

Re: merging PRs - branch protection questions

Volkan, if you'd like to continue using git commit sigs, you should also upload your public GPG key to your GitHub account so that it can verify your commits, too. Otherwise, GitHub doesn't exactly import GPG keys from the public web of trust; they only use GPG keys you specify in your profile (whe

Re: merging PRs - branch protection questions

We have some blockers to strictly enforce RTC such as having enough volunteer time to provide timely PR reviews along with an unnecessarily long CI build time (especially when building locally with all tests now takes about 15 minutes versus 45 minutes in CI). I think we've mostly settled on using

Re: log4j slow startup time - could this be a factor?

I updated how that works in master to reuse the PluginManager that has already called collectPlugins() once (so it even avoids redundant re-scans of the in-memory maps), but that doesn't seem to be much of an issue anymore (especially now that all the StrLookup plugins are themselves instantiated o

Re: log4j slow startup time - could this be a factor?

The main benefit of that IMO is only if you wait for all GitHub builds to succeed; I imagine we'd want Windows, macOS, and Linux. Gary On Fri, Apr 15, 2022, 09:37 Ralph Goers wrote: > I was OK with requiring PRs that I could self approve. > > Ralph > > > On Apr 15, 2022, at 3:28 PM, Volkan Yazı

Re: merging PRs - branch protection questions

Note that nothing is preventing people who like RTC to do so. Gary On Fri, Apr 15, 2022, 09:25 Volkan Yazıcı wrote: > I couldn't introduce branch protection (aka. RTC review-then-commit) since > Gary was strongly against it. It was just me, Matt, and Carter supporting > the idea; Ralph was also

Re: log4j slow startup time - could this be a factor?

I was OK with requiring PRs that I could self approve. Ralph > On Apr 15, 2022, at 3:28 PM, Volkan Yazıcı wrote: > > I don't think so. `PluginManager` accesses `PluginRegistry.getInstance()`, > where the plugins are already cached. `PluginManager#collectPlugins()` > simply filters them using th

Re: log4j slow startup time - could this be a factor?

I don't think so. `PluginManager` accesses `PluginRegistry.getInstance()`, where the plugins are already cached. `PluginManager#collectPlugins()` simply filters them using the given category key. On Fri, Apr 15, 2022 at 1:51 PM Remko Popma wrote: > Maybe the complaints about startup time have to

Re: merging PRs - branch protection questions

I couldn't introduce branch protection (aka. RTC review-then-commit) since Gary was strongly against it. It was just me, Matt, and Carter supporting the idea; Ralph was also sort of against it. You can search the archives for details. I couldn't even introduce commit signatures. Sigh... On Fri, A

log4j slow startup time - could this be a factor?

Maybe the complaints about startup time have to do with this: note that every time a PatternParser is instantiated, we load all plugins again... public PatternParser(final Configuration config, final String converterKey, final Class expectedClass, final Class filterClass) { this.confi