Build failed in Jenkins: mesos-reviewbot #4232

See -- [URLTrigger] A change within the response URL invocation (log) Building remotely on ubuntu-4 (docker Ubuntu ubuntu4 ubuntu) in workspace > git

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Disable-Java-Disable-Python-Disable-Webui #2758

See Changes: [benjamin.hindman] Re-introduce "internal" namespace for src/*. [benjamin.hindman] Enclosed tests in "mesos::internal::tests" namespace. [benjamin.hindman] Re

Re: Review Request 30510: Allowed Mesos containerizer to prepare and update volumes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30510/ --- (Updated Feb. 23, 2015, 7:06 a.m.) Review request for mesos, Ben Mahler, Ian Do

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2479

See Changes: [benjamin.hindman] Re-introduce "internal" namespace for src/*. [benjamin.hindman] Enclosed tests in "mesos::internal::tests" namespace. [benjamin.hindman] Removed all 'namespace slave {' an

Re: Review Request 30609: Added a function that reports file size, not following links.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30609/ --- (Updated Feb. 22, 2015, 11:02 p.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 30609: Added os::lstatsize().

> On Feb. 10, 2015, 4:08 p.m., Ben Mahler wrote: > > It might be time to introduce os::stat and os::lstat wrappers to avoid > > needing to introduce so many special case functions. > > Bernd Mathiske wrote: > That would reduce portability. > > Ben Mahler wrote: > Oh? Could you elaborat

Build failed in Jenkins: mesos-reviewbot #4231

See -- [URLTrigger] A change within the response URL invocation (log) Building remotely on H10 (Ubuntu ubuntu) in workspace > git rev-parse --is-insid

Build failed in Jenkins: Mesos-Ubuntu-distcheck #703

See Changes: [toenshoff] Introduced anonymous modules. [toenshoff] Added anonymous module example and tests. [benjamin.hindman] Re-introduce "internal" namespace for src/*. [benjamin.hindman] Enclosed tests in "mesos::internal:

Build failed in Jenkins: mesos-reviewbot #4230

See -- Started by an SCM change Building remotely on H10 (Ubuntu ubuntu) in workspace > git rev-parse --is-inside-work-tree # timeout=10 Fetching chan

Build failed in Jenkins: mesos-reviewbot #4229

See Changes: [toenshoff] Introduced anonymous modules. [toenshoff] Added anonymous module example and tests. [benjamin.hindman] Re-introduce "internal" namespace for src/*. [benjamin.hindman] Enclosed tests in "mesos::internal::tests

Re: Review Request 31236: Re-introduce "internal" namespace for src/*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31236/#review73509 --- Ship it! Ship It! - Benjamin Hindman On Feb. 22, 2015, 9:39 p.m.

Re: Review Request 31279: Enclosed tests in "mesos::internal::tests" namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31279/#review73510 --- Ship it! Ship It! - Benjamin Hindman On Feb. 22, 2015, 9:39 p.m.

Re: Review Request 30545: cgroups: added support to listen on memory pressures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30545/ --- (Updated Feb. 23, 2015, 4:43 a.m.) Review request for mesos, Dominic Hamon, Ian

Re: Review Request 31016: Added slave run task decorator.

> On Feb. 19, 2015, 4:57 p.m., Michael Park wrote: > > src/hook/manager.cpp, line 134 > > > > > > Same as my comment on > > [r30961](https://reviews.apache.org/r/30961/#comment119359), I think it > > should be `s/tas

Re: Review Request 31287: Removed unnecessary 'mesos::' qualifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31287/#review73486 --- Ship it! Ship It! - Niklas Nielsen On Feb. 22, 2015, 3:57 p.m.,

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 20, 2015, 10:19 p.m., Vinod Kone wrote: > > src/authentication/cram_md5/authenticator.cpp, line 449 > > > > > > Shouldn't this be protected by once() to avoid 2 different threads > > loading secrets at the

Re: Review Request 31288: Fixed bug in tests from 'internal' revert.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31288/#review73480 --- Ship it! Ship It! - Niklas Nielsen On Feb. 22, 2015, 3:57 p.m.,

Re: Review Request 31016: Added slave run task decorator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31016/#review73457 --- src/slave/slave.cpp

Re: Review Request 31287: Removed unnecessary 'mesos::' qualifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31287/#review73474 --- Ship it! Ship It! - Kapil Arya On Feb. 22, 2015, 6:57 p.m., Benj

Re: Review Request 31288: Fixed bug in tests from 'internal' revert.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31288/#review73473 --- Ship it! I know why. The RateLimitingTests are flaky on my machine

Re: Review Request 31287: Removed unnecessary 'mesos::' qualifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31287/#review73472 --- LGTM. - Michael Park On Feb. 22, 2015, 11:57 p.m., Benjamin Hindm

Re: Review Request 31288: Fixed bug in tests from 'internal' revert.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31288/#review73471 --- Bad patch! Reviews applied: [31236] Failed command: ./support/appl

Re: Review Request 31288: Fixed bug in tests from 'internal' revert.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31288/ --- (Updated Feb. 22, 2015, 11:57 p.m.) Review request for mesos, Kapil Arya and Ni

Re: Review Request 31287: Removed unnecessary 'mesos::' qualifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31287/ --- (Updated Feb. 22, 2015, 11:57 p.m.) Review request for mesos, Kapil Arya and Ni

Review Request 31288: Fixed bug in tests from 'internal' revert.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31288/ --- Review request for mesos, Kapil Arya and Niklas Nielsen. Repository: mesos De

Review Request 31287: Removed unnecessary 'mesos::' qualifier.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31287/ --- Review request for mesos, Kapil Arya and Niklas Nielsen. Repository: mesos De

Re: Review Request 31286: Removed all 'namespace slave {' and 'namespace master {' from tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31286/#review73467 --- Bad patch! Reviews applied: [31236] Failed command: ./support/appl

Re: Review Request 31286: Removed all 'namespace slave {' and 'namespace master {' from tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31286/#review73466 --- Ship it! Ship It! - Kapil Arya On Feb. 22, 2015, 5:55 p.m., Benj

Re: Review Request 31286: Removed all 'namespace slave {' and 'namespace master {' from tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31286/ --- (Updated Feb. 22, 2015, 10:55 p.m.) Review request for mesos and Kapil Arya.

Review Request 31286: Removed all 'namespace slave {' and 'namespace master {' from tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31286/ --- Review request for mesos and Kapil Arya. Repository: mesos Description --

Re: Review Request 31236: Re-introduce "internal" namespace for src/*.

> On Feb. 22, 2015, 5:10 p.m., Benjamin Hindman wrote: > > src/common/factory.hpp, line 79 > > > > > > Was this in the code pre-30295 that way? Yes. - Kapil -

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/#review73465 --- Patch looks great! Reviews applied: [27760] All tests passed. - M

Re: Review Request 31236: Re-introduce "internal" namespace for src/*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31236/#review73463 --- src/common/factory.hpp

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

> On Feb. 22, 2015, 7:11 a.m., Adam B wrote: > > src/master/master.cpp, line 453 > > > > > > Maybe do a `CHECK_SOME(authenticator)`? The current code-path to this use of authenticator does not permit anything but

Re: Review Request 27760: Revised authenticator interface to allow for two fold implementations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27760/ --- (Updated Feb. 22, 2015, 10:03 p.m.) Review request for mesos, Adam B, Kapil Ary

Re: Review Request 30962: Enabled environment decorator to override.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30962/#review73455 --- Ship it! src/hook/manager.cpp

Re: Review Request 30961: Enabled label decorator to override.

> On Feb. 19, 2015, 7 a.m., Michael Park wrote: > > src/hook/manager.cpp, line 109 > > > > > > `s/taskInfo/taskInfo_/` if I'm reading correctly. +1. That's a good catch MPark. - Kapil -

Re: Review Request 30961: Enabled label decorator to override.

> On Feb. 19, 2015, 2:57 p.m., Michael Park wrote: > > src/hook/manager.cpp, line 111 > > > > > > This is different than `labels->CopyFrom(result.get());`? I think these should have the same effect. Why not use MPark'

Re: Review Request 30961: Enabled label decorator to override.

> On Feb. 19, 2015, 7:22 a.m., Michael Park wrote: > > src/tests/hook_tests.cpp, lines 157-159 > > > > > > Looks like we can just call this `label` rather than `label1`? +1 - Kapil

Re: Review Request 31017: Fixed comment for remove executor hook.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31017/#review73451 --- Ship it! Ship It! - Kapil Arya On Feb. 13, 2015, 6:28 p.m., Nikl

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated Feb. 22, 2015, 10:09 a.m.) Review request for mesos, Adam B, Benjamin

Re: Review Request 31279: Enclosed tests in "mesos::internal::tests" namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31279/#review73449 --- Bad patch! Reviews applied: [31236] Failed command: ./support/appl

Review Request 31279: Enclosed tests in "mesos::internal::tests" namespace.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31279/ --- Review request for mesos, Benjamin Hindman, Ben Mahler, Jie Yu, Niklas Nielsen,

Re: Review Request 31236: Re-introduce "internal" namespace for src/*.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/31236/ --- (Updated Feb. 22, 2015, 10:41 a.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 30774: Fetcher Cache

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/30774/ --- (Updated Feb. 22, 2015, 12:39 a.m.) Review request for mesos, Adam B, Benjamin