Re: Tests triggered via push to master of fork?

2022-10-13 Thread John Neffenger
On 10/13/22 3:26 AM, Michael Bien wrote: When you clone a repo, gh won't have any actions enabled (I just checked to confirm that it is still the case). The action tab will show a confirmation/warning: "Workflows aren’t being run on this forked repository" I just checked to confirm, too, and

Re: Tests triggered via push to master of fork?

2022-10-13 Thread Michael Bien
On 13.10.22 00:50, Tim Boudreau wrote: I’ve run into this elsewhere - if you’re naively triggering off of pushes using GitHub actions, well, when someone clones your repo, they’re also cloning your actions, and if they reach out to something to trigger a build (or in the case where I ran across t

Re: Tests triggered via push to master of fork?

2022-10-13 Thread Michael Bien
On 13.10.22 01:42, John Neffenger wrote: On 10/12/22 8:55 AM, Michael Bien wrote: the NB repo has this enabled. PRs from non-committers would not trigger CI until someone approves the workflow run. Just to clarify ... I am not a committer -- I can't merge pull requests -- yet the GitHub Acti

Re: Tests triggered via push to master of fork?

2022-10-12 Thread John Neffenger
On 10/12/22 8:55 AM, Michael Bien wrote: the NB repo has this enabled. PRs from non-committers would not trigger CI until someone approves the workflow run. Just to clarify ... I am not a committer -- I can't merge pull requests -- yet the GitHub Actions ran automatically. I am a minor contri

Re: Tests triggered via push to master of fork?

2022-10-12 Thread Tim Boudreau
I’ve run into this elsewhere - if you’re naively triggering off of pushes using GitHub actions, well, when someone clones your repo, they’re also cloning your actions, and if they reach out to something to trigger a build (or in the case where I ran across this, publishing notifications to Zulip),

Re: Tests triggered via push to master of fork?

2022-10-12 Thread Michael Bien
On 12.10.22 17:10, John Neffenger wrote: On 10/12/22 3:00 AM, Michael Bien wrote: if you clone the project you getting the same behavior, just on your own copy. Thank you, Michael. Four years in, and I'm still learning GitHub. :-) So am I :). Some of the features we enabled recently are fair

Re: Tests triggered via push to master of fork?

2022-10-12 Thread John Neffenger
On 10/12/22 3:00 AM, Michael Bien wrote: if you clone the project you getting the same behavior, just on your own copy. Thank you, Michael. Four years in, and I'm still learning GitHub. :-) its defined on the very top of the .github/workflows/main.yml file in your master branch. Got it. I s

Re: Tests triggered via push to master of fork?

2022-10-12 Thread Michael Bien
Hi John, the main workflow is triggered by PR (open and sync) and push to any branch. This was done so that release managers can sync between master and delivery branches (and the other way around). WIP feature branches like CND get some testing done too. if you clone the project you getting

Tests triggered via push to master of fork?

2022-10-11 Thread John Neffenger
I was surprised to see test jobs triggered when I synced the upstream master branch with the master branch of my fork: https://github.com/jgneff/netbeans/actions/runs/3228261286 I expected tests to be triggered only when pushing a commit to the branch of a pull request. For example, on other