Re: svn commit: r662654 - in /ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/visit: showvisits.groovy visitdetail.groovy

2008-06-02 Thread Ashish Vijaywargiya
Scott, I am feeling very happy to see your positive comments on my commit. I noted down the points specified by you and will try to include those in my upcoming commit in this area. -- Ashish On Tue, Jun 3, 2008 at 2:18 AM, Scott Gray <[EMAIL PROTECTED]> wrote: > Hi Ashish > > Everything looks

Re: svn commit: r662654 - in /ofbiz/trunk/applications/party/webapp/partymgr/WEB-INF/actions/visit: showvisits.groovy visitdetail.groovy

2008-06-02 Thread Scott Gray
Hi Ashish Everything looks fine, just a couple of (hopefully) helpful tips: There is a shortened version of java ternary operator available "?:" which provides a default if the rhs of an assignment resolves to null or false: Instead of showAll = parameters.showAll; if (!showAll) { showAll = "f

Re: Discussion: Ajax Development

2008-06-02 Thread Anil Patel
I think we should Ajax/Effects enable widgets where possible. Like, Make Panels collapsable using Effects, Ajax enable Tree widget, Enhance Single form Layout to use div and css, Use Model panel for Lookup windows, Allow display fields to be inline editable etc. Regards Anil Patel On Jun 2,

Re: Discussion: Main Content Layout Best Practices

2008-06-02 Thread Jacques Le Roux
From: "Bruno Busco" <[EMAIL PROTECTED]> Yes, I think that the Skip Menu is something that could be useful even to people not impaired but particulary "affetionated" to the keyboard and to DOS applications. Some work done, but in its state (which does not seem to have a chance to change) access

Re: Discussion: Main Content Layout Best Practices

2008-06-02 Thread Jacques Le Roux
Hi Adrian, From: "Adrian Crum" <[EMAIL PROTECTED]> In the UI work I've done, I have tried to keep accessibility an important priority. One of the things I like about having a scalable UI is that sight impaired people can crank up their browser's default font to see it better. The simplified ma

Re: Discussion: Ajax Development

2008-06-02 Thread Jacques Le Roux
From: "Adrian Crum" <[EMAIL PROTECTED]> Al Byers wrote: I started a post to your reply that talked about what I would like to see and whatever, but as I got into it, I realized that this whole thing could get quite messy. As soon as you do anything that is "customer facing", I think you are goin

Re: Discussion: Ajax Development

2008-06-02 Thread Adrian Crum
Al Byers wrote: I started a post to your reply that talked about what I would like to see and whatever, but as I got into it, I realized that this whole thing could get quite messy. As soon as you do anything that is "customer facing", I think you are going to lose people (like me) because what w

Re: Discussion: Ajax Development

2008-06-02 Thread Al Byers
I would like to add that I do not think ofbiz can ignore the rich internet app technology for long, but maybe it would be better to wait for a shake out till there are 2-3 clear leaders and then choosing the best one and not try to be compatible with others. In the end I think it would make ofbiz m

Re: Discussion: Ajax Development

2008-06-02 Thread Al Byers
Hi Adrian, I started a post to your reply that talked about what I would like to see and whatever, but as I got into it, I realized that this whole thing could get quite messy. As soon as you do anything that is "customer facing", I think you are going to lose people (like me) because what we do w

[jira] Closed: (OFBIZ-1817) Typos in editInvoice.groovy script

2008-06-02 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1817. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks Rashko, You patch is in trunk rev. 6

Re: Discussion: Ajax Development

2008-06-02 Thread Bruno Busco
Adrian, I cannot resist to your invitation to express a couple of point from my wish list: 1) In the "Smart" table header I would like to see the possibility to change the column order, to remove a column, to add a column selecting the field to be displayed from a list of available fields. The tab

Re: Discussion: Main Content Layout Best Practices

2008-06-02 Thread Bruno Busco
Yes, I think that the Skip Menu is something that could be useful even to people not impaired but particulary "affetionated" to the keyboard and to DOS applications. One more thing to consider in the layout best practice is the hiding of every menu command that is not available due to the actual u

Discussion: Ajax Development

2008-06-02 Thread Adrian Crum
Since there seems to be some interest in Ajax development, and since there seems to be several parallel Ajax development efforts, perhaps now is a good time to come up with a coordinated plan for future Ajax development. I'll start things off by reviewing what we've discussed so far and what

Re: SIPS : external credit card payment (Atos Origin)

2008-06-02 Thread Eric DE MAULDE
Hi, When I pay an order in my Web store with SIPS, My order is auto-approved if the payment is validated, with the right party ; but in Accounting (AR) - Show payments received : in the field "From party ID" there isn't a party ID, instead there is ",[_NA_]" !!! And my Response Servlet creat

Re: Discussion: Main Content Layout Best Practices

2008-06-02 Thread Adrian Crum
The basic idea is to have a Skip Menu button very early in the page, so that sight impaired users can tab to that button, hit Enter, and jump over all of the main and sub navigation to go directly to the main content. By the way, when you are testing OFBiz's accessibility, you don't have to cl

[jira] Updated: (OFBIZ-1817) Typos in editInvoice.groovy script

2008-06-02 Thread Rashko Rejmer (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1817?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rashko Rejmer updated OFBIZ-1817: - Attachment: editInvoice.patch Patch for the issue. > Typos in editInvoice.groovy script > --

[jira] Created: (OFBIZ-1817) Typos in editInvoice.groovy script

2008-06-02 Thread Rashko Rejmer (JIRA)
Typos in editInvoice.groovy script -- Key: OFBIZ-1817 URL: https://issues.apache.org/jira/browse/OFBIZ-1817 Project: OFBiz Issue Type: Bug Components: accounting Affects Versions: SVN trunk

[jira] Updated: (OFBIZ-1467) JUNIT test case for finding and editing a party(DemoCustomer)

2008-06-02 Thread Awdesh Parihar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Awdesh Parihar updated OFBIZ-1467: -- Attachment: find_edit_party.patch Thanks Vikas In this patch I followed your suggestion and use

[jira] Commented: (OFBIZ-1645) Screens to manage Forecast in SFA webapp

2008-06-02 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601564#action_12601564 ] Jacopo Cappellato commented on OFBIZ-1645: -- ... and of course we should add a form

[jira] Commented: (OFBIZ-1645) Screens to manage Forecast in SFA webapp

2008-06-02 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601562#action_12601562 ] Jacopo Cappellato commented on OFBIZ-1645: -- Another cool feature we could implemen

[jira] Commented: (OFBIZ-194) Implement sales forecast analysis

2008-06-02 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601558#action_12601558 ] Jacopo Cappellato commented on OFBIZ-194: - Another cool feature we could implement t

[jira] Commented: (OFBIZ-194) Implement sales forecast analysis

2008-06-02 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601557#action_12601557 ] Jacopo Cappellato commented on OFBIZ-194: - Thanks Pranay & Chirag, your patch is in

Re: Discussion: Main Content Layout Best Practices

2008-06-02 Thread Jacques Le Roux
Adrian, This is great, I would like to have a look at the Skip Menu button, hope I will find time (I'm willing to do too much things at the same time these last times and I do just a few of them) Thanks Jacques From: "Adrian Crum" <[EMAIL PROTECTED]> In the UI work I've done, I have tried to

Re: Build broken

2008-06-02 Thread Bruno Busco
Bilgin, thank you I only used build and not clean. With ant clean and then build everything works like a sharm !!! Many thanks and forgive me for the wrong error report. -Bruno 2008/6/2 Bilgin Ibryam <[EMAIL PROTECTED]>: > Did you do ant clean and then build after the svn update? > > Bilgin > >

Re: Build broken

2008-06-02 Thread Bilgin Ibryam
Did you do ant clean and then build after the svn update? Bilgin

Build broken

2008-06-02 Thread Bruno Busco
Hi, it seems that last trunk (rev. 662338) is broken. This is what I get when I go to http://localhost:8080/catalog/control/main: HTTP Status 500 - -- *type* Exception report *message* *description* *The server encountered an internal error () that prevented it from

[jira] Commented: (OFBIZ-1467) JUNIT test case for finding and editing a party(DemoCustomer)

2008-06-02 Thread Vikas Mayur (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601541#action_12601541 ] Vikas Mayur commented on OFBIZ-1467: Awdesh - patch looks good. One change that I wou