[jira] Assigned: (OFBIZ-1930) Added support for uploading additional Product Views (images)

2008-08-22 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-1930: -- Assignee: Ashish Vijaywargiya > Added support for uploading additional Product

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Adam Heath
Scott Gray wrote: Done in r688212 Yeah, that looks good.

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Scott Gray
Done in r688212 2008/8/23 Scott Gray <[EMAIL PROTECTED]>: > I'll go ahead and recommit it, I've run through a few processes that > were having issues and they seem fine now. > > Regards > Scott > > 2008/8/23 Scott Gray <[EMAIL PROTECTED]>: >> Oops not r687675 but r687578, I was looking at the subj

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Scott Gray
I'll go ahead and recommit it, I've run through a few processes that were having issues and they seem fine now. Regards Scott 2008/8/23 Scott Gray <[EMAIL PROTECTED]>: > Oops not r687675 but r687578, I was looking at the subject of this thread. > > 2008/8/23 Scott Gray <[EMAIL PROTECTED]>: >> Ada

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Scott Gray
Oops not r687675 but r687578, I was looking at the subject of this thread. 2008/8/23 Scott Gray <[EMAIL PROTECTED]>: > Adam, I reverted 687675 yesterday a few hours before you committed > your last fix, I think it's related to that. The base compare method > is still expecting a comparable rhs. >

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Scott Gray
Adam, I reverted 687675 yesterday a few hours before you committed your last fix, I think it's related to that. The base compare method is still expecting a comparable rhs. 2008/8/23 Adam Heath <[EMAIL PROTECTED]>: > Jacques Le Roux wrote: >> >> Yes, + clean and even a fresh DB. To reproduce : cr

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Jacques Le Roux
From: "Adam Heath" <[EMAIL PROTECTED]> To: Sent: Friday, August 22, 2008 10:51 PM Subject: Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java Jacques Le Roux wrote: Yes, + clean and even a fresh DB. To reproduce : create a fin account

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

2008-08-22 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624984#action_12624984 ] BJ Freeman commented on OFBIZ-1689: --- unless there has been a change ofbiz ver 4.0 only ru

Re: ProductConfigWorker and ProductConfigWrapper multiple issues - Please comment

2008-08-22 Thread Bilgin Ibryam
Quoting Ritesh Trivedi <[EMAIL PROTECTED]>: Hi Bilgin, For item #1 and #2 - makes sense. I didnt notice the fact that configwrapper instance was intended to be global. Can #3 and #5 be fixed? #5 is already marked as TODO in the code and should be fixed. Feel free to create a jira issue an

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Adam Heath
Jacques Le Roux wrote: Yes, + clean and even a fresh DB. To reproduce : create a fin account, then try to update it Please don't leave out any steps. Tell me exactly what you did, all of it.

Re: ProductConfigWorker and ProductConfigWrapper multiple issues - Please comment

2008-08-22 Thread Ritesh Trivedi
Hi Bilgin, For item #1 and #2 - makes sense. I didnt notice the fact that configwrapper instance was intended to be global. Can #3 and #5 be fixed? Bilgin Ibryam wrote: > > Quoting Ritesh Trivedi <[EMAIL PROTECTED]>: > > Hi Ritesh, comments inline > >> >> Hi, >> >> Have been trying to use c

Re: ProductConfigWorker and ProductConfigWrapper multiple issues - Please comment

2008-08-22 Thread Bilgin Ibryam
Quoting Ritesh Trivedi <[EMAIL PROTECTED]>: Hi Ritesh, comments inline Hi, Have been trying to use configure feature and am encountering several limitations (possible bug(s)/issues) with the current implementation. Both items #1 and #2 causes a bug where if you modify ProductConfigWrapper th

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Jacques Le Roux
Yes, + clean and even a fresh DB. To reproduce : create a fin account, then try to update it Jacques From: "Adam Heath" <[EMAIL PROTECTED]> Jacques Le Roux wrote: Thanks to Bilgin's help, I commited something in revision 688167. It works well but doint this I found an error which ends by j

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Adam Heath
Jacques Le Roux wrote: Thanks to Bilgin's help, I commited something in revision 688167. It works well but doint this I found an error which ends by java.lang.UnsupportedOperationException: = (=) You can easily repreoduce this error on the demo server while using Party Profile, but it's a ran

Re: ProductConfigWorker and ProductConfigWrapper multiple issues - Please comment

2008-08-22 Thread Ritesh Trivedi
#5 ConfigOption.equals method is totally incorrect !! - just checking based on selected field? there can be multiple options selected. At a very least, configOption id and configItem id needs to be compared too. Ritesh Trivedi wrote: > > Hi, > > Have been trying to use configure feature and am

[jira] Updated: (OFBIZ-1689) CASifying OFBiz

2008-08-22 Thread Shi Yusen (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shi Yusen updated OFBIZ-1689: - Remaining Estimate: 336h (was: 2016h) Original Estimate: 336h (was: 2016h) > CASifying OFBiz > ---

[jira] Resolved: (OFBIZ-1689) CASifying OFBiz

2008-08-22 Thread Shi Yusen (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shi Yusen resolved OFBIZ-1689. -- Resolution: Fixed Fix Version/s: (was: SVN trunk) Release Branch 4.0 > CA

[jira] Commented: (OFBIZ-1689) CASifying OFBiz

2008-08-22 Thread Shi Yusen (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12624962#action_12624962 ] Shi Yusen commented on OFBIZ-1689: -- The develop environment is Sun JDK 1.6, OFBiz 4.0, CAS

ProductConfigWorker and ProductConfigWrapper multiple issues - Please comment

2008-08-22 Thread Ritesh Trivedi
Hi, Have been trying to use configure feature and am encountering several limitations (possible bug(s)/issues) with the current implementation. Both items #1 and #2 causes a bug where if you modify ProductConfigWrapper the cache instances still remains unchanged as both the methods returns deep

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Jacques Le Roux
Here is a local log for the error appearing on FinAccounts screenlet in Party Profile. We get the same trying to update a Fin Account 2008-08-22 20:42:15,468 (http-0.0.0.0-18443-1) [ SimpleMethod.java:926:ERROR] runtime exception report ---

Re: svn commit: r687675 -/ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Jacques Le Roux
Thanks to Bilgin's help, I commited something in revision 688167. It works well but doint this I found an error which ends by java.lang.UnsupportedOperationException: = (=) You can easily repreoduce this error on the demo server while using Party Profile, but it's a random error. Actually try

[jira] Updated: (OFBIZ-1930) Added support for uploading additional Product Views (images)

2008-08-22 Thread Mridul Pathak (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak updated OFBIZ-1930: - Attachment: ProductAdditionalViews.patch Here is the patch. > Added support for uploading additi

[jira] Created: (OFBIZ-1930) Added support for uploading additional Product Views (images)

2008-08-22 Thread Mridul Pathak (JIRA)
Added support for uploading additional Product Views (images) - Key: OFBIZ-1930 URL: https://issues.apache.org/jira/browse/OFBIZ-1930 Project: OFBiz Issue Type: New Feature

Re: svn commit: r687675 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Bilgin Ibryam
On Fri, 2008-08-22 at 14:24 +0200, Jacques Le Roux wrote: > I wrote this > > Index: framework/common/config/CommonUiLabels.xml > === > --- framework/common/config/CommonUiLabels.xml (revision 687584) > +++ framework/common/config/Com

Re: svn commit: r687675 - /ofbiz/trunk/framework/widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2008-08-22 Thread Jacques Le Roux
I wrote this Index: framework/common/config/CommonUiLabels.xml === --- framework/common/config/CommonUiLabels.xml (revision 687584) +++ framework/common/config/CommonUiLabels.xml (working copy) @@ -1705,6 +1705,10 @@ �用

Re: svn commit: r687935 - in /ofbiz/trunk/applications/order: config/OrderUiLabels.xml webapp/ordermgr/request/RequestForms.xml

2008-08-22 Thread Jacques Le Roux
Hi Hans, Sorry, but it seems a bit more complicated :/ Below you introduced a new PageTitleRequestItemNotes but there is already a such label in this file. BTW key="PageTitleRequestItems"> is not properly placed. It should be above the pre-existing PageTitleRequestItemNotes which is for now the