[jira] Commented: (OFBIZ-2106) Visual Themes for Ecommerce

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666846#action_12666846 ] Jacques Le Roux commented on OFBIZ-2106: Bruno, What is the status of this issue p

[jira] Issue Comment Edited: (OFBIZ-2118) Drop-down Applications Bar

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666844#action_12666844 ] jacques.le.roux edited comment on OFBIZ-2118 at 1/23/09 10:57 PM: ---

[jira] Commented: (OFBIZ-2118) Drop-down Applications Bar

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666844#action_12666844 ] Jacques Le Roux commented on OFBIZ-2118: I like very much this new theme. But I hav

[jira] Reopened: (OFBIZ-2118) Drop-down Applications Bar

2009-01-23 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco reopened OFBIZ-2118: I think my last comment to this issue has not been posted to the ML (comment on closed issue?) so I re

Re: svn commit: r737176 - in /ofbiz/trunk/applications/accounting/webapp/accounting: agreement/AgreementForms.xml invoice/InvoiceForms.xml

2009-01-23 Thread Bruno Busco
Yes Jacques, you are right. I enabled the sorting only on columns where it was working. The others, being somehow calculated, are either not affected by the sort or will result into an empty table when sorted. -Bruno 2009/1/24 Jacques Le Roux > +1 (is this not possible on amounts, because they a

Re: svn commit: r737176 - in /ofbiz/trunk/applications/accounting/webapp/accounting: agreement/AgreementForms.xml invoice/InvoiceForms.xml

2009-01-23 Thread Jacques Le Roux
+1 (is this not possible on amounts, because they are calculated fields and not simply read from EE ?) Jacques From: "Bruno Busco" I have limited this change to those two screens to hear if we are all OK with this pattern. If yes I will go further trying to have all tables with the same sort

Re: [Travel Assistance] Applications for ApacheCon EU 2009 - Now Open

2009-01-23 Thread Jacques Le Roux
You beat me :o) (actually I sent one which is in cables somewhere...) Jacques From: "David E Jones" The Travel Assistance Committee is now accepting applications for those wanting to attend ApacheCon EU 2009 between the 23rd and 27th March 2009 in Amsterdam. The Travel Assistance Committee is

[jira] Updated: (OFBIZ-2128) product image auto scale

2009-01-23 Thread Eric DE MAULDE (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric DE MAULDE updated OFBIZ-2128: -- Attachment: productImageAutoScale.patch Patch to automatic resize original Image in product con

Fw: Re-Broadcast Request

2009-01-23 Thread Jacques Le Roux
Not easy to apply, but why not ... Jacques From: "Tony Stevenson" To: Sent: Friday, January 23, 2009 2:33 PM Subject: Re-Broadcast Request To all PMCs, The attached message was recently sent to committers@ community@ announce@ Could you please send this email onto you users@ and dev@ mail

One page checkout

2009-01-23 Thread Jacques Le Roux
Hi, Why is there only CC payment option in One page checkout ? Thanks Jacques

[jira] Closed: (OFBIZ-1970) unescaped html special characters create problems in pages

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1970?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-1970. -- Resolution: Duplicate There are already a lot of issues open about thid subject > unescaped ht

[jira] Closed: (OFBIZ-2122) Incomplete customization options for VisualThemes

2009-01-23 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco closed OFBIZ-2122. -- Resolution: Fixed Both appbar.ftl and messages.ftl are now redefinable in the theme > Incomplete custo

Re: svn commit: r729396 [1/2] - in /ofbiz/trunk: applications/accounting/config/ applications/accounting/entitydef/ applications/accounting/src/org/ofbiz/accounting/invoice/ applications/accounting/sr

2009-01-23 Thread Jacopo Cappellato
I would really prefer to keep it in the framework and just move the quickInitDataWarehouse (demo) service to somewhere else... any of the existing applications' components would be fine. Jacopo On Jan 5, 2009, at 2:11 AM, Bruno Busco wrote: I have read David's post and I understood that ha

[jira] Commented: (OFBIZ-2122) Incomplete customization options for VisualThemes

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666780#action_12666780 ] Jacques Le Roux commented on OFBIZ-2122: Should this issue stay opened ? (Bruno ?)

[jira] Reopened: (OFBIZ-2112) Minipol in eCommerce

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reopened OFBIZ-2112: Actually there is still an issue there : The following required parameter is missing: [IN] [cr

[Travel Assistance] Applications for ApacheCon EU 2009 - Now Open

2009-01-23 Thread David E Jones
The Travel Assistance Committee is now accepting applications for those wanting to attend ApacheCon EU 2009 between the 23rd and 27th March 2009 in Amsterdam. The Travel Assistance Committee is looking for people who would like to be able to attend ApacheCon EU 2009 who need some financial suppor

[jira] Commented: (OFBIZ-1477) Create a Wiki page to document/review the types and gl account types used by the GL posting services

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666776#action_12666776 ] Jacques Le Roux commented on OFBIZ-1477: Sure it is ! Thanks Sharan :) > Create a

Re: Security Issues

2009-01-23 Thread Jacques Le Roux
From: "David E Jones" Hello all. I'm actually a little surprised we're still where we are on this, so I'm putting some time into this... understanding that it will annoy as many people as it pleases (at first anyway...). In order to address various XSS and XSS-like security threats, I'd

Re: svn commit: r737194 - in /ofbiz/trunk/framework: minilang/dtd/simple-methods.xsd widget/dtd/widget-screen.xsd widget/src/org/ofbiz/widget/screen/IterateSectionWidget.java

2009-01-23 Thread Jacques Le Roux
Site updated in revision: 737204 Jacques From: Author: jonesde Date: Fri Jan 23 13:30:17 2009 New Revision: 737194 URL: http://svn.apache.org/viewvc?rev=737194&view=rev Log: Chanded a few more attribute names for consistency, based on feedback from Marco Modified: ofbiz/trunk/framework/mi

[jira] Updated: (OFBIZ-2070) New tool to get labels information

2009-01-23 Thread Marco Risaliti (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-2070: -- Attachment: APACHE2_HEADER_FOR_XML Hi Jacques, you have also to add this file on the root of O

[jira] Updated: (OFBIZ-2070) New tool to get labels information

2009-01-23 Thread Marco Risaliti (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-2070: -- Attachment: LabelsInfo10.patch Hi Jacques, I have tried to create it from svn client. Thanks

[jira] Commented: (OFBIZ-2128) product image auto scale

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666750#action_12666750 ] Jacques Le Roux commented on OFBIZ-2128: Hi Eric, Should I review or wait ? > pr

[jira] Closed: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2115. -- Resolution: Fixed Thanks Stephen, Well done, your patch is in trunk revision: 737200 Only 2

Re: Security Issues

2009-01-23 Thread Jacques Le Roux
+1, easy just have to refer to the main one to check, ie https://issues.apache.org/jira/browse/OFBIZ-1525 Jacques From: "Adrian Crum" David E Jones wrote: The best issues on this are: https://issues.apache.org/jira/browse/OFBIZ-1959 (newer one, good review of OFBiz security and applicabl

Re: Refactory on xsd files

2009-01-23 Thread David E Jones
On Jan 23, 2009, at 6:43 AM, mrisal...@libero.it wrote: Yes, I understood, it's only to remember us to do it on the OFBiz site too. What does we think about changing also those attributes ? element old-attribute new-attribute condition-expr field-name --> field This is not a

Re: svn commit: r737176 - in /ofbiz/trunk/applications/accounting/webapp/accounting: agreement/AgreementForms.xml invoice/InvoiceForms.xml

2009-01-23 Thread Bruno Busco
I have limited this change to those two screens to hear if we are all OK with this pattern. If yes I will go further trying to have all tables with the same sort column feature enabled (and the header-row-style="header-row-2"). WDYT? 2009/1/23 > Author: buscob > Date: Fri Jan 23 12:34:40 2009

[jira] Updated: (OFBIZ-2118) Drop-down Applications Bar

2009-01-23 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-2118: --- Attachment: ReducedThemeRedundancy.patch David, please find attached a new patch that tryes to reduce

Re: svn commit: r737186 - /ofbiz/trunk/themes/bluelight/includes/messages.ftl

2009-01-23 Thread David E Jones
That's a great step in the right direction, and should make themes in general easier to create and maintain. -David On Jan 23, 2009, at 1:57 PM, bus...@apache.org wrote: Author: buscob Date: Fri Jan 23 12:57:00 2009 New Revision: 737186 URL: http://svn.apache.org/viewvc?rev=737186&view=r

[jira] Updated: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Rufle updated OFBIZ-2115: - Attachment: 2009-01-14_001_shoppingcart.patch Made changes suggested by Adrian about using a Set

[jira] Issue Comment Edited: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1244#action_1244 ] srufle edited comment on OFBIZ-2115 at 1/23/09 1:03 PM: --- Woul

Re: Refactory on xsd files

2009-01-23 Thread David E Jones
Yes, that's what I use with Oxygen. There are already catalog files in various of the OFBiz components, right in the dtd directories along with the xsd files, so this is really easy. -David On Jan 23, 2009, at 3:59 AM, Jacques Le Roux wrote: Hi David, I had a look at how to do that in

[jira] Commented: (OFBIZ-1825) Colors and localisation for the calendar

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1271#action_1271 ] Jacques Le Roux commented on OFBIZ-1825: Hi Todor, Marco, I did a 1st cursory revi

[jira] Commented: (OFBIZ-2078) Error when receiving inventory

2009-01-23 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1253#action_1253 ] Adrian Crum commented on OFBIZ-2078: Erwan, I see you closed the issue. So is this fix

[jira] Commented: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1244#action_1244 ] Stephen Rufle commented on OFBIZ-2115: -- Would I want to do the first loop through and

[jira] Commented: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Adrian Crum (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1229#action_1229 ] Adrian Crum commented on OFBIZ-2115: Stephen - Maybe what you're looking for is a Set.

[jira] Commented: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1212#action_1212 ] Stephen Rufle commented on OFBIZ-2115: -- Sure I will change and resubmit. The attribute

Re: Security Issues

2009-01-23 Thread euronymous
Hi David I'm Michele OrrĂ¹, the one who published on you jira the issue you mentioned: https://issues.apache.org/jira/browse/OFBIZ-1959 Basically we are using Ofbiz trunk in our projects, when we need to build ecommerce, crm, facility management and so on: we also developed a few customization (

[jira] Commented: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666593#action_12666593 ] Jacques Le Roux commented on OFBIZ-2115: Stephen, Good catch on "if (UtilValidate.

Re: Security Issues

2009-01-23 Thread Adrian Crum
David E Jones wrote: The best issues on this are: https://issues.apache.org/jira/browse/OFBIZ-1959 (newer one, good review of OFBiz security and applicable comments, good tips to resolve) https://issues.apache.org/jira/browse/OFBIZ-260 (the old/original one, including my silly comment on it)

Re: Security Issues

2009-01-23 Thread Adrian Crum
David E Jones wrote: 1. validate input: consider not allowing HTML in any field by default, and require an attribute set on service attributes or possibly even entity fields to say that restricted/safe HTML is allowed, or any HTML is allowed; this will break some things that actually need HTML

[jira] Updated: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Rufle updated OFBIZ-2115: - Attachment: (was: 2009-01-08_001_OrderItemAtrributes.patch) > OrderServices.updateApprovedOrd

[jira] Updated: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen Rufle updated OFBIZ-2115: - Attachment: 2009-01-14_001_shoppingcart.patch Created a new patch after the tabs 2 spaces commit.

[jira] Commented: (OFBIZ-2070) New tool to get labels information

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666565#action_12666565 ] Jacques Le Roux commented on OFBIZ-2070: Oops, I did no get the right patch (I took

[jira] Commented: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666562#action_12666562 ] Jacques Le Roux commented on OFBIZ-2115: OFBIZ-2109 is already commited, no worries

[jira] Commented: (OFBIZ-2070) New tool to get labels information

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666561#action_12666561 ] Jacques Le Roux commented on OFBIZ-2070: Marco, Sorry but you did not update. I ha

[jira] Issue Comment Edited: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666560#action_12666560 ] srufle edited comment on OFBIZ-2115 at 1/23/09 7:21 AM: --- I th

[jira] Commented: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Stephen Rufle (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666560#action_12666560 ] Stephen Rufle commented on OFBIZ-2115: -- I think OFBIZ-2109 will also be effected. Shou

[jira] Closed: (OFBIZ-2109) ShoppingCartServices.loadCartFromOrder setting shipGroups

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2109. -- Resolution: Fixed > ShoppingCartServices.loadCartFromOrder setting shipGroups > ---

[jira] Commented: (OFBIZ-2109) ShoppingCartServices.loadCartFromOrder setting shipGroups

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666556#action_12666556 ] Jacques Le Roux commented on OFBIZ-2109: Thanks Stephen, Your patch is in trunk at

[jira] Commented: (OFBIZ-2115) OrderServices.updateApprovedOrderItems should update OrderItemAttributes

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666553#action_12666553 ] Jacques Le Roux commented on OFBIZ-2115: Please Stephen, Could you create a new pa

Re: [jira] Commented: (OFBIZ-2118) Drop-down Applications Bar

2009-01-23 Thread Pierre Smits
I love the eye candy. Well done! 2009/1/23 Bruno Busco (JIRA) > >[ > https://issues.apache.org/jira/browse/OFBIZ-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666470#action_12666470] > > Bruno Busco commented on OFBIZ-2118: > -

Re: Problem with Hotwax Demo

2009-01-23 Thread Tim Ruppert
Jacques, send me a request to my email and I'll get this going for you. Cheers, Tim -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 - "Jacques Le Roux" wrote: > I may help too > > Jacques > > From: "David E Jones" > > > > Are there any volunteers on

Re: Refactory on xsd files

2009-01-23 Thread mrisal...@libero.it
Yes, I understood, it's only to remember us to do it on the OFBiz site too. What does we think about changing also those attributes ? element old-attribute new-attribute condition-expr field-name --> field condition-object field-name --> field select-field field-name --> field or

[jira] Commented: (OFBIZ-2131) Anonymous checkout Submit purchase button does not work in IE7

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666528#action_12666528 ] Jacques Le Roux commented on OFBIZ-2131: I was ready to close this as not reproduct

[jira] Commented: (OFBIZ-2124) Ofbiz freeze

2009-01-23 Thread Philippe Mouawad (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666526#action_12666526 ] Philippe Mouawad commented on OFBIZ-2124: - A patch on the trunk. I can path the 4.0

Re: [jira] Commented: (OFBIZ-2118) Drop-down Applications Bar

2009-01-23 Thread Pierre Smits
Hi all, Does that mean that documentation regarding visual themes (http://docs.ofbiz.org/display/OFBIZ/Visual+Themes+-+How+to) doesn't apply anymore? Regards, Pierre 2009/1/23, Bruno Busco (JIRA) : > > [ > https://issues.apache.org/jira/browse/OFBIZ-2118?page=com.atlassian.jira.plugin.syste

Re: Please Migrate Apache OFBiz forums to Nabble2

2009-01-23 Thread Jacques Le Roux
Hi Will, Hope all is going well at Nabble, I can even wish you an happy new year (January is not finished ;o). Have you a chance to look at our forums ? There are any hurry anyway Thanks Jacques - Original Message - From: Will (via Nabble) To: Jacques Le Roux Sent: Tuesday,

[jira] Assigned: (OFBIZ-2109) ShoppingCartServices.loadCartFromOrder setting shipGroups

2009-01-23 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2109?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-2109: -- Assignee: Jacques Le Roux > ShoppingCartServices.loadCartFromOrder setting shipGroups >

Re: Tabs to 4 spaces

2009-01-23 Thread Jacques Le Roux
Done, rev. 737003 Jacques From: "Jacques Le Roux" If nobody disagree I will do that tomorrow. It will be a massive no functionnal change. Jacques From: "Jacques Le Roux" I will eventually do that later when the BigDecimal branch will have been merged Jacques From: "Jacques Le Roux" If

Re: Refactory on xsd files

2009-01-23 Thread Jacques Le Roux
Hi David, I had a look at how to do that in Oxygen. Are you using a catalog (.xcat) ? http://www.oxygenxml.com/doc/ug-oxygenEclipse/preferences-xml.html#preferences-xml-catalog Thanks Jacques From: "David E Jones" While we can update these immediately, with this stuff still up in the air

Re: Tabs to 4 spaces

2009-01-23 Thread Jacques Le Roux
From: "David E Jones" Trying to use this literally, the interpretation is: indent with 4 spaces, and don't ever use tabs. It says: "Four spaces should be used as the unit of indentation. The exact construction of the indentation (spaces vs. tabs) is unspecified. Tabs must be set exactly eve

Security Issues

2009-01-23 Thread David E Jones
Hello all. I'm actually a little surprised we're still where we are on this, so I'm putting some time into this... understanding that it will annoy as many people as it pleases (at first anyway...). In order to address various XSS and XSS-like security threats, I'd like to get some real

[jira] Commented: (OFBIZ-2118) Drop-down Applications Bar

2009-01-23 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666470#action_12666470 ] Bruno Busco commented on OFBIZ-2118: Hi All, I am happy to see you liked the new theme.

Re: Tabs to 4 spaces

2009-01-23 Thread David E Jones
Trying to use this literally, the interpretation is: indent with 4 spaces, and don't ever use tabs. It says: "Four spaces should be used as the unit of indentation. The exact construction of the indentation (spaces vs. tabs) is unspecified. Tabs must be set exactly every 8 spaces (not 4).

Re: Tabs to 4 spaces

2009-01-23 Thread Jeroen van der Wal
I totally agree to follow a convention but the first line in the convention says "The exact construction of the indentation (spaces vs. tabs) is unspecified.". So there's no need to replace tabs into spaces according to the convention. -Jeroen On Fri, Jan 23, 2009 at 10:34 AM, Jacques Le Roux < j

Re: Tabs to 4 spaces

2009-01-23 Thread Jacques Le Roux
Actually it's just a matter of convention and we chose this one http://java.sun.com/docs/codeconv/html/CodeConventions.doc3.html#313 The intention is to get rid of most of all these comments and changes we have to do as commiters... Patch ahead : 800 KB, 14574 lines (not the bigger I did, chan

[jira] Commented: (OFBIZ-2118) Drop-down Applications Bar

2009-01-23 Thread Pranay Pandey (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12666457#action_12666457 ] Pranay Pandey commented on OFBIZ-2118: -- I tried with this theme, looks cool. Thanks Br

Re: Tabs to 4 spaces

2009-01-23 Thread Jeroen van der Wal
Sorry for my late response, I've been away from a pc for a couple of days. We've had debates about tabs versus spaces several times and this quote reflects my opinion: "The debate over whether to use tab characters or spaces for indenting code is probably as old as Fortran. In fact, the arguing ov

Re: Refactory on xsd files

2009-01-23 Thread Jacques Le Roux
Done, rev 736973 Jacques From: Thanks a lot David, can someone also update the ofbiz site (www.ofbiz.org/dtds) wsd files according to this changes into the trunk ? Marco Thanks Marco! Hopefully I didn't miss too many of these, but with hundreds of them chances are I did... This one i

Re: Refactory on xsd files

2009-01-23 Thread David E Jones
While we can update these immediately, with this stuff still up in the air I don't see the hurry. If you need them for local validation during development, I recommend instead that you setup your XML editor to look at your local XSD files instead of the ones on the web site. If your XML e

[jira] Closed: (OFBIZ-2078) Error when receiving inventory

2009-01-23 Thread Erwan de FERRIERES (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-2078. - Resolution: Fixed The error was due to the recent modifications with UEL. > Error when r

Re: Refactory on xsd files

2009-01-23 Thread mrisal...@libero.it
Thanks a lot David, can someone also update the ofbiz site (www.ofbiz.org/dtds) wsd files according to this changes into the trunk ? Marco > > Thanks Marco! Hopefully I didn't miss too many of these, but with > hundreds of them chances are I did... > > This one is updated to be more consistent

Re: Problem with Hotwax Demo

2009-01-23 Thread David E Jones
Which request from Apache are you looking for? The main infra stuff that needs to be handled still for OFBiz are these in the board report: http://docs.ofbiz.org/display/OFBADMIN/ASF+Board+Report+2008-12 -David On Jan 23, 2009, at 12:56 AM, Hans Bakker wrote: Hi David, i just subscribe