Re: svn commit: r739651 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2009-01-31 Thread Adrian Crum
That shouldn't have changed. I will look into it. -Adrian --- On Sat, 1/31/09, David E Jones wrote: > From: David E Jones > Subject: Re: svn commit: r739651 - > /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java > To: dev@ofbiz.apache.org > Date: Saturday, January 31

Re: svn commit: r739651 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/LoginWorker.java

2009-01-31 Thread David E Jones
This is an interesting problem... on a related note what happened to the old functionality where if a label was not found the label itself was printed? I think that changed with some of the new XML-based stuff and it is unfortunate because with defaulting to the label name at least it isn

[jira] Commented: (OFBIZ-2142) error message of login service does not show with common/messages.ftl

2009-01-31 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669315#action_12669315 ] Hans Bakker commented on OFBIZ-2142: Thank you Scott, for fixing it! > error message o

[jira] Commented: (OFBIZ-2137) Artifact cleaning after recent changes on xsd files

2009-01-31 Thread Marco Risaliti (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669294#action_12669294 ] Marco Risaliti commented on OFBIZ-2137: --- Committed artifact_cleaning_party.patch into

[jira] Commented: (OFBIZ-2157) Take a copy of XUI sources

2009-01-31 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669293#action_12669293 ] BJ Freeman commented on OFBIZ-2157: --- do you think the authors of XUI will changes he lice

[jira] Commented: (OFBIZ-2137) Artifact cleaning after recent changes on xsd files

2009-01-31 Thread Marco Risaliti (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669292#action_12669292 ] Marco Risaliti commented on OFBIZ-2137: --- Committed artifact_cleaning_marketing.patch

[jira] Commented: (OFBIZ-2137) Artifact cleaning after recent changes on xsd files

2009-01-31 Thread Marco Risaliti (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669290#action_12669290 ] Marco Risaliti commented on OFBIZ-2137: --- Committed artifact_cleaning_manufacturing.pa

[jira] Updated: (OFBIZ-2070) New tool to get labels information

2009-01-31 Thread Marco Risaliti (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-2070: -- Attachment: LabelsInfo15.patch Hi Jacques, LabelsInfo15.patch contains some comments for prope

[jira] Closed: (OFBIZ-2142) error message of login service does not show with common/messages.ftl

2009-01-31 Thread Scott Gray (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray closed OFBIZ-2142. - Resolution: Fixed Thanks Hans, fixed in rev. 739651 > error message of login service does not show with

[jira] Assigned: (OFBIZ-2142) error message of login service does not show with common/messages.ftl

2009-01-31 Thread Scott Gray (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2142?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray reassigned OFBIZ-2142: - Assignee: Scott Gray > error message of login service does not show with common/messages.ftl > --

[jira] Commented: (OFBIZ-2070) New tool to get labels information

2009-01-31 Thread Marco Risaliti (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669282#action_12669282 ] Marco Risaliti commented on OFBIZ-2070: --- I have seen that some comments are after the

[jira] Updated: (OFBIZ-2070) New tool to get labels information

2009-01-31 Thread Marco Risaliti (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2070?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marco Risaliti updated OFBIZ-2070: -- Attachment: LabelsInfo14.patch Hi Jacques, Label manager now supports also comments at propert

[jira] Created: (OFBIZ-2157) Take a copy of XUI sources

2009-01-31 Thread Jacques Le Roux (JIRA)
Take a copy of XUI sources -- Key: OFBIZ-2157 URL: https://issues.apache.org/jira/browse/OFBIZ-2157 Project: OFBiz Issue Type: Improvement Components: specialpurpose/pos Affects Versions: SVN trunk

Re: svn commit: r739593 - in /ofbiz/site/dtds: 002_confirm_bod_004.xsd 068_sync_inventory_005.xsd 161B_process_shipment_001.xsd 161_show_shipment_005.xsd 196_acknowledge_delivery_001.xsd 197_receive_d

2009-01-31 Thread Jacques Le Roux
Reverted in revision 739627, I was not sure, I should have ask but it's as easier to revert anyway Jacques From: "David E Jones" These should NOT go on the ofbiz site as they are not XSDs from OFBiz (they are from an external source and just in the repo for reference to avoid having to g

Re: svn commit: r739593 - in /ofbiz/site/dtds: 002_confirm_bod_004.xsd 068_sync_inventory_005.xsd 161B_process_shipment_001.xsd 161_show_shipment_005.xsd 196_acknowledge_delivery_001.xsd 197_receive_d

2009-01-31 Thread David E Jones
These should NOT go on the ofbiz site as they are not XSDs from OFBiz (they are from an external source and just in the repo for reference to avoid having to get remote XSDs at runtime). They are from www.openapplications.org , as referenced inside the DTDs, ie: http://www.openapplications

Re: Question about hashed passwords in seed data

2009-01-31 Thread David E Jones
On Jan 31, 2009, at 11:18 AM, Jacopo Cappellato wrote: On Jan 31, 2009, at 7:55 PM, David E Jones wrote: On Jan 31, 2009, at 6:57 AM, Jacopo Cappellato wrote: On Jan 25, 2009, at 9:51 PM, David E Jones wrote: I should also concede that I may not have communicated very well... The syste

[jira] Updated: (OFBIZ-1945) Create/use order for POS save / load sale

2009-01-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-1945: --- Attachment: ofbiz-1945.patch An updated patch (merged with révision 739595) with some more ch

[jira] Closed: (OFBIZ-2156) Removing Login/Logout from AppBarMenu

2009-01-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2156. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Bruno Busco Thanks Bruno,

[jira] Commented: (OFBIZ-2156) Removing Login/Logout from AppBarMenu

2009-01-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669222#action_12669222 ] Jacques Le Roux commented on OFBIZ-2156: Finally I let it like that for the moment.

Re: Question about hashed passwords in seed data

2009-01-31 Thread Jacopo Cappellato
On Jan 31, 2009, at 7:55 PM, David E Jones wrote: On Jan 31, 2009, at 6:57 AM, Jacopo Cappellato wrote: On Jan 25, 2009, at 9:51 PM, David E Jones wrote: I should also concede that I may not have communicated very well... The system account definitely needs to be there, and in seed data.

[jira] Updated: (OFBIZ-2156) Removing Login/Logout from AppBarMenu

2009-01-31 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-2156: --- Attachment: HeaderLogOut.patch Please find attached an hopefully better patch. > Removing Login/Logo

[jira] Commented: (OFBIZ-2156) Removing Login/Logout from AppBarMenu

2009-01-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669217#action_12669217 ] Jacques Le Roux commented on OFBIZ-2156: So it's only a matter of color in header,

[jira] Commented: (OFBIZ-2156) Removing Login/Logout from AppBarMenu

2009-01-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669216#action_12669216 ] Jacques Le Roux commented on OFBIZ-2156: Forget my last comment, for a reason or an

[jira] Commented: (OFBIZ-2156) Removing Login/Logout from AppBarMenu

2009-01-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669214#action_12669214 ] Jacques Le Roux commented on OFBIZ-2156: Also not sure why yet but we got an issue

Re: [jira] Commented: (OFBIZ-2143) payrol entities and payrolinvoiceItemtype

2009-01-31 Thread David E Jones
On Jan 30, 2009, at 11:58 PM, Hans Bakker (JIRA) wrote: 2. Currently the salary is defined by the emplPosition -> employee positionType -> rate Amount. For smaller companies this is rather complicated. I would like to suggest add a rateTypeId on the employment to override this relationshi

[jira] Commented: (OFBIZ-2156) Removing Login/Logout from AppBarMenu

2009-01-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669210#action_12669210 ] Jacques Le Roux commented on OFBIZ-2156: Hi Bruno, It's almost OK with blue-light

Re: Question about hashed passwords in seed data

2009-01-31 Thread David E Jones
On Jan 31, 2009, at 6:57 AM, Jacopo Cappellato wrote: On Jan 25, 2009, at 9:51 PM, David E Jones wrote: I should also concede that I may not have communicated very well... The system account definitely needs to be there, and in seed data. The admin account we be a good thing to have in dem

Re: Adding more flexibility for the definition of entity-data-readers

2009-01-31 Thread David E Jones
If you haven't done so already then yeah, that would be the way to go (ie a new/different constructor). -David On Jan 31, 2009, at 1:50 AM, Jacopo Cappellato wrote: This is a good idea... I had a look at the code (EntityDataReaderInfo that extends ResourceInfo that extends NamedInfo) b

Re: svn commit: r739568 - in /ofbiz/trunk: applications/accounting/webapp/accounting/fixedasset/ applications/party/webapp/partymgr/party/ applications/product/webapp/facility/facility/ framework/comm

2009-01-31 Thread Jacques Le Roux
Hi Jacopo, Yes you are right, I did not think 1st but yes, this could introduce circular reference in case no demo data where used. Reverted in revision: 739574 Thanks Jacques From: "Jacopo Cappellato" Hi Jacques, I think it is a bad idea to hardcode demo data... Jacopo On Jan 31, 2009,

Re: svn commit: r739568 - in /ofbiz/trunk: applications/accounting/webapp/accounting/fixedasset/ applications/party/webapp/partymgr/party/ applications/product/webapp/facility/facility/ framework/comm

2009-01-31 Thread Jacopo Cappellato
Hi Jacques, I think it is a bad idea to hardcode demo data... Jacopo On Jan 31, 2009, at 3:57 PM, jler...@apache.org wrote: Author: jleroux Date: Sat Jan 31 14:57:28 2009 New Revision: 739568 URL: http://svn.apache.org/viewvc?rev=739568&view=rev Log: Make easier to see demonstration Modifie

Re: Question about hashed passwords in seed data

2009-01-31 Thread Jacopo Cappellato
On Jan 25, 2009, at 9:51 PM, David E Jones wrote: I should also concede that I may not have communicated very well... The system account definitely needs to be there, and in seed data. The admin account we be a good thing to have in demo data, but my objection is to always having admin ther

[jira] Updated: (OFBIZ-2156) Removing Login/Logout from AppBarMenu

2009-01-31 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-2156: --- Attachment: HeaderLogOut.patch > Removing Login/Logout from AppBarMenu >

[jira] Created: (OFBIZ-2156) Removing Login/Logout from AppBarMenu

2009-01-31 Thread Bruno Busco (JIRA)
Removing Login/Logout from AppBarMenu - Key: OFBIZ-2156 URL: https://issues.apache.org/jira/browse/OFBIZ-2156 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Br

Re: Question about hashed passwords in seed data

2009-01-31 Thread Jacopo Cappellato
David, this is a great suggestion and I have implemented it in rev. 739563. Here is the commit log: Three new ant targets defined: * run-install-readers to pass the comma separated list of data readers (IMO this task should be named "run-install" and the existing one should be renamed "run-

[jira] Closed: (OFBIZ-565) Load a sales order in POS

2009-01-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-565?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-565. - Resolution: Duplicate Fix Version/s: SVN trunk > Load a sales order in POS > --

Re: Adding more flexibility for the definition of entity-data-readers

2009-01-31 Thread Jacopo Cappellato
This is a good idea... I had a look at the code (EntityDataReaderInfo that extends ResourceInfo that extends NamedInfo) but I couldn't find an easy way to get an instance of a EntityDataReaderInfo without an org.w3c.dom.Element. Should I simply add a new constructor that accepts a string (t

[jira] Commented: (OFBIZ-2155) Amend typo in inlineProductDetail.ftl file's Java script.

2009-01-31 Thread Vivek Mishra (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669166#action_12669166 ] Vivek Mishra commented on OFBIZ-2155: - Thanks Jacques. -- Thanks & Regards -- Vivek

[jira] Closed: (OFBIZ-2155) Amend typo in inlineProductDetail.ftl file's Java script.

2009-01-31 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2155. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Thanks Vi

Re: svn commit: r739523 - /ofbiz/trunk/framework/images/webapp/images/maincss.css

2009-01-31 Thread Jacques Le Roux
Thanks for your help on this Bruno Jacques From: Author: buscob Date: Sat Jan 31 08:30:48 2009 New Revision: 739523 URL: http://svn.apache.org/viewvc?rev=739523&view=rev Log: Reverted rev. 739406 Actually the issue reported should be solved changing any custom AppMenu markup structure (see E

[jira] Updated: (OFBIZ-2155) Amend typo in inlineProductDetail.ftl file's Java script.

2009-01-31 Thread Vivek Mishra (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Vivek Mishra updated OFBIZ-2155: Attachment: inlineProductDetail.patch Changed name of java script function of inlineProductDetail.x

[jira] Created: (OFBIZ-2155) Amend typo in inlineProductDetail.ftl file's Java script.

2009-01-31 Thread Vivek Mishra (JIRA)
Amend typo in inlineProductDetail.ftl file's Java script. - Key: OFBIZ-2155 URL: https://issues.apache.org/jira/browse/OFBIZ-2155 Project: OFBiz Issue Type: Improvement Compon

[jira] Commented: (OFBIZ-2153) app-navigation style change breaks

2009-01-31 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669161#action_12669161 ] Bruno Busco commented on OFBIZ-2153: Well, the patch actually breakes the layout only i

[jira] Commented: (OFBIZ-2153) app-navigation style change breaks

2009-01-31 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669160#action_12669160 ] Bruno Busco commented on OFBIZ-2153: Jacques, the /sfa/control/FindSalesForecast has be

[jira] Commented: (OFBIZ-2153) app-navigation style change breaks

2009-01-31 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12669158#action_12669158 ] Bruno Busco commented on OFBIZ-2153: Stephen, the issue you report is due to a recent r