[jira] Closed: (OFBIZ-2229) WebTools WebSiteId

2009-03-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-2229. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Thanks Bru

[jira] Assigned: (OFBIZ-1235) Create the theme for the form widget

2009-03-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux reassigned OFBIZ-1235: -- Assignee: (was: Jacques Le Roux) > Create the theme for the form widget > -

Re: Cross-Site Request Forging (XSRF)

2009-03-05 Thread David E Jones
Yes, AJAX calls are an interesting point... If AJAX requests used the random token even a single call would reset the token and break things. If they did not use the random token they are a gaping security hole. I don't think we're going to do the random token thing, unless someone spon

[jira] Commented: (OFBIZ-1235) Create the theme for the form widget

2009-03-05 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679502#action_12679502 ] David E. Jones commented on OFBIZ-1235: --- You might want to wait until Jacopo posts hi

[jira] Commented: (OFBIZ-1235) Create the theme for the form widget

2009-03-05 Thread WeizhanGuo (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679486#action_12679486 ] WeizhanGuo commented on OFBIZ-1235: --- Now, we have created the 19 files of macro for the 1

[jira] Issue Comment Edited: (OFBIZ-1235) Create the theme for the form widget

2009-03-05 Thread WeizhanGuo (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679485#action_12679485 ] jack_guo edited comment on OFBIZ-1235 at 3/5/09 7:40 PM: --- change

[jira] Updated: (OFBIZ-1235) Create the theme for the form widget

2009-03-05 Thread WeizhanGuo (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WeizhanGuo updated OFBIZ-1235: -- Description: We are creating the "theme" for the ofbiz widget form, why we create this? We found it's

[jira] Reopened: (OFBIZ-1235) Widget Engine integrate with dojo

2009-03-05 Thread WeizhanGuo (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-1235?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] WeizhanGuo reopened OFBIZ-1235: --- change this issue to create the theme for the form widget > Widget Engine integrate with dojo >

Re: Test Practices and Patterns (was Re: svn commit: r750296 - in /ofbiz/trunk/framework/testtools: dtd/test-suite.xsd src/org/ofbiz/testtools/ModelTestSuite.java src/org/ofbiz/testtools/TestListCon

2009-03-05 Thread guo weizhan
I'm fine with the test-group, I think one test suite can have some groups and one group can contain some test cases. It's good for cases organization. As my experience, the test cases can share some precondition and post condition in group scope, also the groups can share precondition and post con

Re: Cross-Site Request Forging (XSRF)

2009-03-05 Thread Al Byers
David, I am trying to think of the effect this will have as applications have more and more AJAX calls. It seems like it would come down to implementing a central object for processing such requests and the developer would not need to worry about it, but then a mix of page requests and ajax calls

[jira] Updated: (OFBIZ-2229) WebTools WebSiteId

2009-03-05 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bruno Busco updated OFBIZ-2229: --- Attachment: WebToolsWebSite.patch > WebTools WebSiteId > -- > > Key:

[jira] Created: (OFBIZ-2229) WebTools WebSiteId

2009-03-05 Thread Bruno Busco (JIRA)
WebTools WebSiteId -- Key: OFBIZ-2229 URL: https://issues.apache.org/jira/browse/OFBIZ-2229 Project: OFBiz Issue Type: Improvement Components: framework Reporter: Bruno Busco Attachments: WebToo

Re: Cross-Site Request Forging (XSRF)

2009-03-05 Thread Jacques Le Roux
I agree with Adrian. As you well explained David, we can't expect to have a totally secured without paying some price (sometimes too high) in usability, etc. So yes +1 for this, I can't see a better way. Jacques From: "Adrian Crum" David, Thank you for the thorough explanation of the problem

Re: Cross-Site Request Forging (XSRF)

2009-03-05 Thread Adrian Crum
David, Thank you for the thorough explanation of the problem! From my perspective, any steps taken to improve security are a benefit. At the same time, any steps taken to improve security can be thwarted by a skilled hacker. I think a reasonable approach is to implement measures that improve

Cross-Site Request Forging (XSRF)

2009-03-05 Thread David E Jones
I've been thinking more about the XSRF problem and what we can do to make OFBiz more secure from this sort of attack. This is related to OFBIZ-1959 and there is more discussion and introduction to it there. The trick is that we want to allow certain things: 1. the client's IP address can c

Re: svn commit: r749959 - in /ofbiz/trunk: applications/ecommerce/webapp/ecommerce/WEB-INF/ framework/common/webcommon/WEB-INF/ framework/common/webcommon/includes/ framework/webapp/dtd/ framework/web

2009-03-05 Thread Jacques Le Roux
It works great! Jacques From: "David E Jones" After looking into this more, I think I found what you were running into. If you go to the product detail page, ie something like: http://localhost:8080/ecommerce/catalog/PROMOTIONS/p_GZ-2644 and then change the locale using the drop-down in

Re: svn commit: r749959 - in /ofbiz/trunk: applications/ecommerce/webapp/ecommerce/WEB-INF/ framework/common/webcommon/WEB-INF/ framework/common/webcommon/includes/ framework/webapp/dtd/ framework/web

2009-03-05 Thread David E Jones
After looking into this more, I think I found what you were running into. If you go to the product detail page, ie something like: http://localhost:8080/ecommerce/catalog/PROMOTIONS/p_GZ-2644 and then change the locale using the drop-down in the "Language" box on the right, then you'll get

Re: svn commit: r749959 - in /ofbiz/trunk: applications/ecommerce/webapp/ecommerce/WEB-INF/ framework/common/webcommon/WEB-INF/ framework/common/webcommon/includes/ framework/webapp/dtd/ framework/web

2009-03-05 Thread David E Jones
I wrote this stuff and what you wrote still doesn't make any sense to me... Are you saying this is an issue with the latest version? Are you using the second commit which fixed these issues or are you saying that somehow you don't want to use that and we should fix it in a different way

Re: svn commit: r749959 - in /ofbiz/trunk: applications/ecommerce/webapp/ecommerce/WEB-INF/ framework/common/webcommon/WEB-INF/ framework/common/webcommon/includes/ framework/webapp/dtd/ framework/web

2009-03-05 Thread Jacques Le Roux
I like this feature. In eCommerce it works well in simple cases, but not when you have selected a product and want to change language (we get "Product not found for Product ID !") and suppose to get right back to the selected product. I 1st thought it was because we have no productId in the URL, s

[jira] Commented: (OFBIZ-2205) Implemented recruitment in HR module

2009-03-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679235#action_12679235 ] Jacques Le Roux commented on OFBIZ-2205: Avdhesh, You should better ask such quest

[jira] Commented: (OFBIZ-2208) ServerHit aborts transactions when trying to create entries with duplicate startTime(s).

2009-03-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679231#action_12679231 ] Jacques Le Roux commented on OFBIZ-2208: Ha yes! I forgot this point, in case Kari

Re: how to write a test case

2009-03-05 Thread Adam Heath
Vikas Mayur wrote: > I appreciate your efforts in the recent commits to clean up test case > and its relative code. I am happy now people are getting off sleep and > want to contribute to this important part of the OFBiz. > > So just you know, almost every test case in accounting require certain

[jira] Commented: (OFBIZ-2208) ServerHit aborts transactions when trying to create entries with duplicate startTime(s).

2009-03-05 Thread David E. Jones (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679215#action_12679215 ] David E. Jones commented on OFBIZ-2208: --- This patches substantially changes an entity

Re: Test Practices and Patterns (was Re: svn commit: r750296 - in /ofbiz/trunk/framework/testtools: dtd/test-suite.xsd src/org/ofbiz/testtools/ModelTestSuite.java src/org/ofbiz/testtools/TestListConta

2009-03-05 Thread Tim Ruppert
Gentlemen, great debate. I will provide a bit more information a bit later as I don't want to answer without fully running thru all of the scenarios that everyone lays out. Adam - thanks for pushing on this - it's needed it for a long time. Cheers, Tim -- Tim Ruppert HotWax Media http://www.h

[jira] Updated: (OFBIZ-2218) Buyer should be able to specify PO# otherwise it should be generated automatically while placing a purchase order.

2009-03-05 Thread Bharat Soni (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharat Soni updated OFBIZ-2218: --- Attachment: (was: ofbiz-2218.patch) > Buyer should be able to specify PO# otherwise it should be

[jira] Updated: (OFBIZ-2218) Buyer should be able to specify PO# otherwise it should be generated automatically while placing a purchase order.

2009-03-05 Thread Bharat Soni (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bharat Soni updated OFBIZ-2218: --- Attachment: ofbiz-2218.patch The patch is now updated with i18n for error messages like "Error getti

[jira] Commented: (OFBIZ-2205) Implemented recruitment in HR module

2009-03-05 Thread avdhesh yadav (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679157#action_12679157 ] avdhesh yadav commented on OFBIZ-2205: -- Hello, I am new to ofbiz and recently started

[jira] Commented: (OFBIZ-2205) Implemented recruitment in HR module

2009-03-05 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679153#action_12679153 ] Ashish Vijaywargiya commented on OFBIZ-2205: Hello Abhinav, Thanks for letting

[jira] Commented: (OFBIZ-2208) ServerHit aborts transactions when trying to create entries with duplicate startTime(s).

2009-03-05 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679151#action_12679151 ] Jacques Le Roux commented on OFBIZ-2208: Thanks Karim, This looks like a good solu

[jira] Updated: (OFBIZ-2208) ServerHit aborts transactions when trying to create entries with duplicate startTime(s).

2009-03-05 Thread Karim Rahimpur (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karim Rahimpur updated OFBIZ-2208: -- Attachment: ServerHit.patch This solution is based on the following considerations: - there mu

[jira] Reopened: (OFBIZ-2208) ServerHit aborts transactions when trying to create entries with duplicate startTime(s).

2009-03-05 Thread Karim Rahimpur (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2208?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karim Rahimpur reopened OFBIZ-2208: --- Many thanks for your comments. The thing is that it really does not depend on which DBMS you use

[jira] Commented: (OFBIZ-2205) Implemented recruitment in HR module

2009-03-05 Thread Abhinav Vaid (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2205?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12679141#action_12679141 ] Abhinav Vaid commented on OFBIZ-2205: - Hello Ashish, Thanks for your comments and rena

Re: how to write a test case

2009-03-05 Thread Vikas Mayur
Adam, I appreciate your efforts in the recent commits to clean up test case and its relative code. I am happy now people are getting off sleep and want to contribute to this important part of the OFBiz. So just you know, almost every test case in accounting require certain pre-condition