[jira] Updated: (OFBIZ-2727) Enhance the existing FinAccount "transactions" screen to show more information about associated payments

2009-07-17 Thread Surya Kusumakar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surya Kusumakar updated OFBIZ-2727: --- Comment: was deleted (was: The following enhancements are done : 1.Shown more information abo

[jira] Commented: (OFBIZ-2727) Enhance the existing FinAccount "transactions" screen to show more information about associated payments

2009-07-17 Thread Surya Kusumakar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732856#action_12732856 ] Surya Kusumakar commented on OFBIZ-2727: The following enhancements are done : 1.Sh

[jira] Commented: (OFBIZ-2727) Enhance the existing FinAccount "transactions" screen to show more information about associated payments

2009-07-17 Thread Surya Kusumakar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732855#action_12732855 ] Surya Kusumakar commented on OFBIZ-2727: The following enhancements are done : 1.Sh

[jira] Updated: (OFBIZ-2727) Enhance the existing FinAccount "transactions" screen to show more information about associated payments

2009-07-17 Thread Surya Kusumakar (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2727?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Surya Kusumakar updated OFBIZ-2727: --- Attachment: EnhancementsInFinAccountTrans.patch Here is the patch for enhancements in FinAcco

Re: svn commit: r795024 [1/6] - in /ofbiz/branches/executioncontext20090716: ./ applications/content/src/org/ofbiz/content/content/ applications/order/src/org/ofbiz/order/order/ applications/party/src

2009-07-17 Thread BJ Freeman
+1 for interfaces. in Eclipse you notified when there is changes to the interface. Eclipse will add the missing items to the classes that depend on the interface. Plus they are good place to do Docs on the usage. Adrian Crum sent the following on 7/17/2009 5:07 PM: > --- On Fri, 7/17/09, David E J

Re: svn commit: r795024 [1/6] - in /ofbiz/branches/executioncontext20090716: ./ applications/content/src/org/ofbiz/content/content/ applications/order/src/org/ofbiz/order/order/ applications/party/src

2009-07-17 Thread Adrian Crum
--- On Fri, 7/17/09, David E Jones wrote: > There is a basic reason for this, and it's because I'm lazy > and also not sure how many of these "lower level" objects we > even want interfaces for. My preference would be to change all of it to interfaces. Higher level code should interact with int

[jira] Commented: (OFBIZ-2452) Security error in Catalog. Trying to delete

2009-07-17 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732787#action_12732787 ] BJ Freeman commented on OFBIZ-2452: --- https://issues.apache.org/jira/browse/OFBIZ-2737 fix

[jira] Commented: (OFBIZ-2737) Unable to remove child category from parent category

2009-07-17 Thread Pranay Pandey (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732778#action_12732778 ] Pranay Pandey commented on OFBIZ-2737: -- Please refer to this issue which got fixed OFB

Re: svn commit: r795024 [1/6] - in /ofbiz/branches/executioncontext20090716: ./ applications/content/src/org/ofbiz/content/content/ applications/order/src/org/ofbiz/order/order/ applications/party/src

2009-07-17 Thread David E Jones
There is a basic reason for this, and it's because I'm lazy and also not sure how many of these "lower level" objects we even want interfaces for. By doing it this way the ModelEntityInterface object is not meant to be used as a straight replacement of ModelEntity and does not have all

Re: svn commit: r792113 - /ofbiz/trunk/framework/base/src/org/ofbiz/base/util/UtilDateTime.java

2009-07-17 Thread Adrian Crum
The problem is in line 1647 of ModelFormField.java (which assumes the key is a String). Any fixes should be done there. -Adrian Anil Patel wrote: Adrian, I started to use ExpressionUIHelper.getMonthValueList() for populating months in form dropdown elements. We are facing problem when value

Re: svn commit: r795030 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/finaccount/FinAccountServices.xml

2009-07-17 Thread Ashish Vijaywargiya
+1 on Adrian's comment. -- Ashish On Fri, Jul 17, 2009 at 7:53 PM, Adrian Crum wrote: > I don't see where using UEL expressions is any different than using > BeanShell scriptlets: ${bsh:payment.statusId == 'PMNT_SENT' @or > payment.statusId == 'PMNT_RECEIVED';} - which are used a lot in the pro

Re: svn commit: r795030 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/finaccount/FinAccountServices.xml

2009-07-17 Thread Adrian Crum
I don't see where using UEL expressions is any different than using BeanShell scriptlets: ${bsh:payment.statusId == 'PMNT_SENT' @or payment.statusId == 'PMNT_RECEIVED';} - which are used a lot in the project. The code could be simplified further by using: property="AccountingPaymentStatus

[jira] Closed: (OFBIZ-2735) Implement a service to set the status of FinAccountTrans entity.

2009-07-17 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel closed OFBIZ-2735. --- Resolution: Fixed Applied to r795074. Thanks for contribution. > Implement a service to set the sta

[jira] Assigned: (OFBIZ-2735) Implement a service to set the status of FinAccountTrans entity.

2009-07-17 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel reassigned OFBIZ-2735: --- Assignee: Anil K Patel > Implement a service to set the status of FinAccountTrans entity. > -

[jira] Commented: (OFBIZ-2699) Create Payment Batches for Ar Payment

2009-07-17 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732500#action_12732500 ] Anil K Patel commented on OFBIZ-2699: - Current patch is in trunk r795064. Thanks. > Cr

[jira] Commented: (OFBIZ-2561) Implementing Customer Service functionality

2009-07-17 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732499#action_12732499 ] Hans Bakker commented on OFBIZ-2561: perhaps a interesting link for you to study? http:

[jira] Assigned: (OFBIZ-2699) Create Payment Batches for Ar Payment

2009-07-17 Thread Anil K Patel (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anil K Patel reassigned OFBIZ-2699: --- Assignee: Anil K Patel (was: Ashish Vijaywargiya) > Create Payment Batches for Ar Payment >

[jira] Commented: (OFBIZ-2561) Implementing Customer Service functionality

2009-07-17 Thread Hans Bakker (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732496#action_12732496 ] Hans Bakker commented on OFBIZ-2561: please read the comment we made. As far as i am co

[jira] Updated: (OFBIZ-2699) Create Payment Batches for Ar Payment

2009-07-17 Thread Arpit Singh Pandya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2699?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Singh Pandya updated OFBIZ-2699: -- Attachment: OFBiz_2699.patch Some Improvements in Deposit Slip Pdf. Thanks Jacopo for

Re: svn commit: r795030 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/finaccount/FinAccountServices.xml

2009-07-17 Thread Hans Bakker
I am sorry but the xml definition was much more clear and the whole equation togetherthe separate 'false' with uel not nice On Fri, 2009-07-17 at 16:24 +0530, Chirag Manocha wrote: > Comments Inline :- > > Hans Bakker wrote: > > Are you sure this is correct? > > > > In the original compa

[jira] Commented: (OFBIZ-2561) Implementing Customer Service functionality

2009-07-17 Thread Serveen Kaur (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732488#action_12732488 ] Serveen Kaur commented on OFBIZ-2561: - Hi We have not got any response from long time

[jira] Created: (OFBIZ-2737) Unable to remove child category from parent category

2009-07-17 Thread yt (JIRA)
Unable to remove child category from parent category Key: OFBIZ-2737 URL: https://issues.apache.org/jira/browse/OFBIZ-2737 Project: OFBiz Issue Type: Bug Components: product

[jira] Commented: (OFBIZ-2540) Improvements in Recruitment sub module in HR

2009-07-17 Thread Abhinav Vaid (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732485#action_12732485 ] Abhinav Vaid commented on OFBIZ-2540: - Hi We had made some improvements in recruitmen

[jira] Closed: (OFBIZ-2736) facilityId not processed correctly in case of quickShipPurchaseOrder

2009-07-17 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya closed OFBIZ-2736. -- Resolution: Fixed Thanks Mridul. Done at r795050 & 795054(RB9.04) -- Ashish > facilit

[jira] Assigned: (OFBIZ-2736) facilityId not processed correctly in case of quickShipPurchaseOrder

2009-07-17 Thread Ashish Vijaywargiya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ashish Vijaywargiya reassigned OFBIZ-2736: -- Assignee: Ashish Vijaywargiya > facilityId not processed correctly in case of q

[jira] Commented: (OFBIZ-2735) Implement a service to set the status of FinAccountTrans entity.

2009-07-17 Thread Sumit Pandit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732473#action_12732473 ] Sumit Pandit commented on OFBIZ-2735: - Yes you are correct it evaluate withdraw as nega

[jira] Updated: (OFBIZ-2736) facilityId not processed correctly in case of quickShipPurchaseOrder

2009-07-17 Thread Mridul Pathak (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mridul Pathak updated OFBIZ-2736: - Attachment: OFBIZ-2736.patch Here is the patch for the fix. > facilityId not processed correctly

[jira] Created: (OFBIZ-2736) facilityId not processed correctly in case of quickShipPurchaseOrder

2009-07-17 Thread Mridul Pathak (JIRA)
facilityId not processed correctly in case of quickShipPurchaseOrder Key: OFBIZ-2736 URL: https://issues.apache.org/jira/browse/OFBIZ-2736 Project: OFBiz Issue Type: Bug

Re: svn commit: r795030 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/finaccount/FinAccountServices.xml

2009-07-17 Thread Chirag Manocha
Comments Inline :- Hans Bakker wrote: Are you sure this is correct? In the original comparison there is a 'not' around the 'or' which i do not see in the UEL I also do not see much advantages in these kind of changes they only can create problems Regards, Hans On Fri, 2009-07-17 a

Re: svn commit: r795030 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/finaccount/FinAccountServices.xml

2009-07-17 Thread Hans Bakker
Are you sure this is correct? In the original comparison there is a 'not' around the 'or' which i do not see in the UEL I also do not see much advantages in these kind of changes they only can create problems Regards, Hans On Fri, 2009-07-17 at 10:23 +, apa...@apache.org wrote: >

[jira] Commented: (OFBIZ-2735) Implement a service to set the status of FinAccountTrans entity.

2009-07-17 Thread Jacopo Cappellato (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732441#action_12732441 ] Jacopo Cappellato commented on OFBIZ-2735: -- Sumit, your comments are good to me;

[jira] Commented: (OFBIZ-2735) Implement a service to set the status of FinAccountTrans entity.

2009-07-17 Thread Sumit Pandit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732439#action_12732439 ] Sumit Pandit commented on OFBIZ-2735: - Thanks Arpit for the patch. > Implement a servi

[jira] Updated: (OFBIZ-2735) Implement a service to set the status of FinAccountTrans entity.

2009-07-17 Thread Arpit Singh Pandya (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpit Singh Pandya updated OFBIZ-2735: -- Attachment: Set_Status_of_FinAccountTrans_OFBIZ-2735.patch Here is the patch of impleme

[jira] Commented: (OFBIZ-2735) Implement a service to set the status of FinAccountTrans entity.

2009-07-17 Thread Sumit Pandit (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732401#action_12732401 ] Sumit Pandit commented on OFBIZ-2735: - To implement this following changes will require