Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-27 Thread David E Jones
The reason to use SECAs is to avoid changing the current service. All you need to do is have another service run before the PartyRelationship create/update services that checks to see if there is a PartyRole record and if not create it. In fact, I believe there is already a service that does th

Re: svn commit: r893935 - /ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl

2009-12-27 Thread Ashish Vijaywargiya
I will create the new label soon. Thanks for your comment. -- Ashish On Mon, Dec 28, 2009 at 2:09 AM, Scott Gray wrote: > On 26/12/2009, at 4:10 PM, ash...@apache.org wrote: > >> Author: ashish >> Date: Sat Dec 26 03:10:26 2009 >> New Revision: 893935 >> >> URL: http://svn.apache.org/viewvc?rev=

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-27 Thread Jacques Le Roux
Hi David, I had a fresh look, I agree it can be easily written with simple-methods instead. I don't think I need SECAs, but I'm not quite sure right about that yet. I will rewrite it (notably the helpers are pretty useless). I was coding in Java and thought Java, so I forgot about the comfort m

Re: svn commit: r893935 - /ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl

2009-12-27 Thread Jacques Le Roux
From: "Scott Gray" On 26/12/2009, at 4:10 PM, ash...@apache.org wrote: Author: ashish Date: Sat Dec 26 03:10:26 2009 New Revision: 893935 URL: http://svn.apache.org/viewvc?rev=893935&view=rev Log: Conditional check. If "Internal Name" not found then check for "Product Name" and if both the v

Re: svn commit: r893935 - /ofbiz/trunk/applications/product/webapp/catalog/find/miniproductlist.ftl

2009-12-27 Thread Scott Gray
On 26/12/2009, at 4:10 PM, ash...@apache.org wrote: Author: ashish Date: Sat Dec 26 03:10:26 2009 New Revision: 893935 URL: http://svn.apache.org/viewvc?rev=893935&view=rev Log: Conditional check. If "Internal Name" not found then check for "Product Name" and if both the values are missing th

[jira] Updated: (OFBIZ-3374) UI upgrade, new lookups

2009-12-27 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3374: --- Attachment: lookups.patch IE Fix > UI upgrade, new lookups > --- > >

[jira] Updated: (OFBIZ-3374) UI upgrade, new lookups

2009-12-27 Thread Sascha Rodekamp (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sascha Rodekamp updated OFBIZ-3374: --- Attachment: lookups.patch Hi, i create a seperate decorator for the lookup layer and included

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-27 Thread Jacques Le Roux
Thanks for reviewing Scott, From: "Scott Gray" Hi Jacques, I haven't reviewed the actual logic but a few comments inline. Regards Scott HotWax Media http://www.hotwaxmedia.com On 27/12/2009, at 12:21 AM, jler...@apache.org wrote: Author: jleroux Date: Sat Dec 26 11:21:21 2009 New Revision

Re: svn commit: r893961 - in /ofbiz/trunk/applications/party: servicedef/ src/org/ofbiz/party/party/

2009-12-27 Thread Jacques Le Roux
From: "David E Jones" Thanks for your review Scott. There really are a lot of issues with this commit... Nothing harmful though (or I did not spot it in) From a higher level perspective, why is this implemented with so much code and so many new files? I think all that is needed to implemen