Re: Could we remove button-style-1 and button-style-2 ?

2011-01-29 Thread Bruno Busco
Adrian I think we are almost on the same page, please read inline. 2011/1/30 Adrian Crum > The application developer designs the application, not the graphic artist. > The graphic artist styles the application, he doesn't design it. > 100% agreed > > For example, I am a developer designing a

Re: Could we remove button-style-1 and button-style-2 ?

2011-01-29 Thread Adrian Crum
The application developer designs the application, not the graphic artist. The graphic artist styles the application, he doesn't design it. For example, I am a developer designing a screen. The screen requires two sets of links. The links in set A all share something in common, and the links i

Re: svn commit: r1065018 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml widget/MiscScreens.xml

2011-01-29 Thread Adrian Crum
No, the page title should NOT be changed. You're missing the point. The extra text is redundant and unnecessary. Please do NOT clutter up a simple tool with a lot of unnecessary text. -Adrian On 1/29/2011 2:42 PM, Bruno Busco wrote: Yes, you are right, the page title should be changed as well

[jira] Closed: (OFBIZ-4157) Incorrect CSS path for elRTE editor

2011-01-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4157. -- Resolution: Fixed Fix Version/s: SVN trunk Assignee: Jacques Le Roux Thanks Ren

[jira] Closed: (OFBIZ-3971) enhancement to create new tenants easier

2011-01-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3971. -- Resolution: Fixed Thanks Pierre, Your (slightly modified) patch is in trunk at r1065144 I h

Re: svn commit: r1065018 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml widget/MiscScreens.xml

2011-01-29 Thread Bruno Busco
Yes, you are right, the page title should be changed as well. I did not change it yet because I was using the Tomahawk theme and, in this theme, the page title is not visible because it is already present in the breadcrumb. The logic should be this: - for all styles that are rendered as simple str

Re: Could we remove button-style-1 and button-style-2 ?

2011-01-29 Thread Bruno Busco
Adrian, I am sorry to put again this on the table. I know we have already discussed about but I think that you are trying to better explain over and over a wrong concept. You can see how it is wrong when you say "In the original visual theme, the tab-bar decorator was used for the sub-menu at the t

Re: svn commit: r1065018 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml widget/MiscScreens.xml

2011-01-29 Thread Adrian Crum
Using the same logic, the page title should say "Layout Demo (page-title)" because it is rendered in the same way as . The whole point of the screen is to look at the markup - to understand how a screen's markup is composed and how various styles are applied. In other words, if you want to use

Re: svn commit: r1065018 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml widget/MiscScreens.xml

2011-01-29 Thread Bruno Busco
Adrian, I thougth this was usefull above all when different styles are rendered in the same way (i.e. h4, h5, h6). In this case, having different texts, helps understanding very easily even if not looking at the markup. -Bruno 2011/1/29 Adrian Crum > Bruno, > > At first glance, it might seem lo

[jira] Commented: (OFBIZ-3971) enhancement to create new tenants easier

2011-01-29 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988504#action_12988504 ] BJ Freeman commented on OFBIZ-3971: --- also check if this does not happen https://issues.ap

[jira] Updated: (OFBIZ-4157) Incorrect CSS path for elRTE editor

2011-01-29 Thread Rene Scheibe (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rene Scheibe updated OFBIZ-4157: Attachment: OFBIZ-4157-correct_css_path.patch this is sets the correct CSS path > Incorrect CSS pa

Re: jackrabbit branch

2011-01-29 Thread Adrian Crum
Something more things to think about... I believe Scott started exploring this option after coming to the conclusion that the current OFBiz Content component is a mess (Scott- correct me if I'm wrong). So, it might help to research previous mailing list discussions about the Content component

[jira] Created: (OFBIZ-4157) Incorrect CSS path for elRTE editor

2011-01-29 Thread Rene Scheibe (JIRA)
Incorrect CSS path for elRTE editor --- Key: OFBIZ-4157 URL: https://issues.apache.org/jira/browse/OFBIZ-4157 Project: OFBiz Issue Type: Bug Components: content Affects Versions: SVN trunk

[jira] Commented: (OFBIZ-3971) enhancement to create new tenants easier

2011-01-29 Thread BJ Freeman (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3971?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988497#action_12988497 ] BJ Freeman commented on OFBIZ-3971: --- please use the jira for comments it is easier to kee

Re: Could we remove button-style-1 and button-style-2 ?

2011-01-29 Thread Adrian Crum
One more thing that might help clear up any confusion... Some of the CSS class names were not the best choices (hindsight is 20-20). A more accurate name for the button-bar class would be link-group (or control-group), and then the button-style classes could be named group-style-1 and group-st

Re: svn commit: r1065018 - in /ofbiz/trunk/framework/webtools: config/WebtoolsUiLabels.xml widget/MiscScreens.xml

2011-01-29 Thread Adrian Crum
Bruno, At first glance, it might seem logical to have text describing each of the styles or elements being displayed, but it really isn't necessary - since the styles/elements can be seen when viewing the markup. -Adrian On 1/29/2011 6:22 AM, bus...@apache.org wrote: Author: buscob Date: Sa

Re: Could we remove button-style-1 and button-style-2 ?

2011-01-29 Thread Adrian Crum
I'm sure we discussed this just a few weeks ago, but I will go over it again... The button-style-1 and button-style-2 CSS classes are button-bar class decorators. The button-bar class has other decorators too - tab-bar and tool-bar. Altogether, there are four button-bar decorators. The butto

[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created

2011-01-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988469#action_12988469 ] Jacques Le Roux commented on OFBIZ-4127: This makes sense Bruno > Styles for the b

[jira] Closed: (OFBIZ-4156) infinite lookup ajax calls if key enter on the page with layer lookup forms

2011-01-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4156?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-4156. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks Leon, Your (slightly modified) patch

[jira] Commented: (OFBIZ-4127) Styles for the button-bar buttons are not created

2011-01-29 Thread Bruno Busco (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988464#action_12988464 ] Bruno Busco commented on OFBIZ-4127: Hi, I have posted something in the DEV ML and late

Could we remove button-style-1 and button-style-2 ?

2011-01-29 Thread Bruno Busco
Hi, again on this topic. I have seen that in the new Flat grey theme the button-style-1 and button-style-2 are rendered in the same way. I agree on this and was going to do the same on the Tomahawk theme. While doing this I asked myself if it does make sense to keep those two styles. They seems t

Re: svn commit: r1063233 - in /ofbiz/branches/release10.04/applications/product/widget/catalog: CommonScreens.xml ProductScreens.xml

2011-01-29 Thread Vikas Mayur
Jacques, I completely agree with you. Will keep an eye on others response and if required will revert. Regards Vikas On Sat, Jan 29, 2011 at 3:04 PM, Jacques Le Roux < jacques.le.r...@les7arts.com> wrote: > Vikas, > > If nobody see a problem with it and you are sure it's safe, why not... > Just

[jira] Closed: (OFBIZ-3765) Use CustomMethod for select order, quote and invoice hook to resolve id

2011-01-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3765?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3765. -- Resolution: Fixed Thanks Nicolas, Anne, Nicolas, your patch is in trunk at r1065014 > Use

Re: svn commit: r1064953 - in /ofbiz/trunk/framework/common: script/org/ofbiz/common/email/EmailServices.xml src/org/ofbiz/common/email/EmailServices.java

2011-01-29 Thread Ashish Vijaywargiya
Its been taken care in my recent r1064993. Now buildbot is returning success :-) -- Ashish On Sat, Jan 29, 2011 at 11:38 AM, Ashish Vijaywargiya < vijaywargiya.ash...@gmail.com> wrote: > Hello Jacopo, > > Yes, I noticed the buildbot failure notification. We are looking into it > and then will ge

Re: [jira] Commented: (OFBIZ-4154) Use ZXing to generic QR 2d barcode

2011-01-29 Thread Shi Yusen
Sure, I'll do it as you suggested several days later. Thank you, 在 2011-01-29六的 06:24 -0500,Jacques Le Roux (JIRA)写道: > [ > https://issues.apache.org/jira/browse/OFBIZ-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988434#action_12988434 > ] >

[jira] Commented: (OFBIZ-4154) Use ZXing to generic QR 2d barcode

2011-01-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988434#action_12988434 ] Jacques Le Roux commented on OFBIZ-4154: Yusen, I'd suggest a new Barcodes Menu in

End of month : Main New features

2011-01-29 Thread Jacques Le Roux
Please devs, don't forget to add your changes in Main New features with shorts explanations https://cwiki.apache.org/confluence/display/OFBIZ/Main+New+Features Thanks Jacques

[jira] Commented: (OFBIZ-4154) Use ZXing to generic QR 2d barcode

2011-01-29 Thread Shi Yusen (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988428#action_12988428 ] Shi Yusen commented on OFBIZ-4154: -- Hi Jacques, Yes, I agree with you. Only the jars and

buildbot success in ASF Buildbot on ofbiz-trunk

2011-01-29 Thread buildbot
The Buildbot has detected a restored build of ofbiz-trunk on ASF Buildbot. Full details are available at: http://ci.apache.org/builders/ofbiz-trunk/builds/1249 Buildbot URL: http://ci.apache.org/ Buildslave for this Build: isis_ubuntu Build Reason: Build Source Stamp: [branch ofbiz/trunk] 1064

[jira] Closed: (OFBIZ-3839) Wrong number of products coming in layered navigation functionality.

2011-01-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3839. -- Resolution: Fixed Assignee: Jacques Le Roux Thanks Amit, Your patch is in trunk at r1064

[jira] Commented: (OFBIZ-3186) Layered Navigation of Categories

2011-01-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988426#action_12988426 ] Jacques Le Roux commented on OFBIZ-3186: Hi Mridul, Why can't it stays side by sid

[jira] Commented: (OFBIZ-3868) Adding de UI Lables on framework CommonUILabels

2011-01-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988425#action_12988425 ] Jacques Le Roux commented on OFBIZ-3868: Ping > Adding de UI Lables on framework C

[jira] Commented: (OFBIZ-3862) Ajax requests prevent externalLoginKey parameters from working correctly

2011-01-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988423#action_12988423 ] Jacques Le Roux commented on OFBIZ-3862: Hi Bilgin, Yes I think it's a good idea

[jira] Commented: (OFBIZ-3897) Wicket component

2011-01-29 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988420#action_12988420 ] Jacques Le Roux commented on OFBIZ-3897: James, >From the recent exchanges on dev

Re: svn commit: r1063233 - in /ofbiz/branches/release10.04/applications/product/widget/catalog: CommonScreens.xml ProductScreens.xml

2011-01-29 Thread Jacques Le Roux
Vikas, If nobody see a problem with it and you are sure it's safe, why not... Just that it should be considered as really exceptional Thanks Jacques From: "Vikas Mayur" Sorry for late reply - Jacques. It does not relates to a real bug but I think the changes does no harm to the release eith

Re: jackrabbit branch

2011-01-29 Thread Sascha Rodekamp
That's good to hear. I will check in the next we. And create a wiki page for it. Am 28.01.2011 um 21:19 schrieb Scott Gray : > I do intend to return to the branch at some point, I just don't know when. > > Regards > Scott > > HotWax Media > http://www.hotwaxmedia.com > > On 29/01/2011, at 6:20